CDR Tickets

Issue Number 4043
Summary Update PDQ Summary Titles (Location of Registered Trademark)
Created 2016-03-11 09:45:40
Issue Type Improvement
Submitted By Sun, Victoria (NIH/NCI) [C] [X]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2016-05-13 17:35:47
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.180599
Description

Please add the trademark symbol before the mdash for both Patient and HP Versions of summaries (it should look like the example below):

  • "Adult Acute Lymphoblastic Leukemia Treatment (PDQ®)–Patient Version"

Comment entered 2016-03-11 14:59:50 by Englisch, Volker (NIH/NCI) [C]

Since we're modifying the summary title we will also need to modify the filter that's preparing the PDQ partner data. This filter strips out the added "-[Patient|HP] Version" text that's only intended for Cancer.gov display.

The filters to be modified are:

  • CDR000157.xml: Vendor Filter: Summary

  • CDR609947.xml: Vendor Filter: Convert CG to Public Data

Comment entered 2016-03-11 15:01:22 by Englisch, Volker (NIH/NCI) [C]

A new subversion branch has been created for this change at:
https://ncisvn.nci.nih.gov/svn/oce_cdr/branches/trademark-patch

Comment entered 2016-03-14 17:38:30 by Englisch, Volker (NIH/NCI) [C]

Blair made the change to the filter and we ran a before and after summary publishing job. I diff'ed the directories and didn't find any unexpected changes.

Next steps:

  • Blair adds a comment indicating the OCECDR-ID to the heading of the filter

  • We version the filter in Subversion

  • We run updateFilter.py to install the versioned filter as a publishable version

  • We run a Summary publishing job to push the documents to GK-BLUE for processing.

  • Rinse/repeat for CDR609947.xml

Comment entered 2016-03-14 18:01:54 by Learn, Blair (NIH/NCI) [C]

Steps 1 to 3 are complete. We'll pick up with the push job in the morning.

Comment entered 2016-03-16 12:28:06 by Englisch, Volker (NIH/NCI) [C]

Rinse/repeat for CDR609947.xml

The way the filter has been written there is no additional change necessary. The current template works properly.
However, we may want to clean up the filter. Currently the filter is written so that in a title like
Summary Title - HP Version (PDQ)
will extract the text before the n-dash (Summary Title) and the string after Version ((PDQ)) and concatenate these two. This logic works correctly with the old as well as the new titles.

We may want to update the code anyway if we want to avoid developer's confusion down the road. Someone may be asking why we're concatenating an empty string and the answer would be "because the string (PDQ) is now part of the first string.

Comment entered 2016-03-17 09:58:56 by gillbl

- what is left to be done so this can be updated to PROD?

Comment entered 2016-03-17 11:54:36 by Englisch, Volker (NIH/NCI) [C]

We did the filter change for the title and everything looks good. Currently, Gatekeeper on PINK is processing a batch of summaries and has done 470 summaries for the first phase.
The problem is that this weekend is server maintenance for CBIIT. Maintenance is scheduled starting on 6pm Saturday. The last time we ran a full Summaries job on Gatekeeper it ran until around 3pm on Saturday. We can run the update this weekend but it may be safer to wait until the following week or we split the summary updates into batches and finish what's left after the maintenance window.

What would you like us to do, Ben?

Comment entered 2016-03-17 15:06:02 by gillbl

Thank you , let's wait until next weekend to run the update

Comment entered 2016-03-17 17:31:31 by Englisch, Volker (NIH/NCI) [C]

Updated the following filter:

  • R13785: CDR609947 - Vendor Filter: Convert CG to Public Data

Comment entered 2016-03-17 17:48:11 by Englisch, Volker (NIH/NCI) [C]

I will run a test of the program CG2Public.py which is using the modified filter on Monday after the full publishing job ran.

Comment entered 2016-03-21 16:28:09 by Englisch, Volker (NIH/NCI) [C]

The test ran successfully. There were no surprises and the filters are ready to go to production.

Comment entered 2016-03-25 13:37:26 by Englisch, Volker (NIH/NCI) [C]

Due to system performance issues, we're holding off with the filter changes for this ticket. These filter changes will result in updating every single summary which will take around 20 hours during good times. The past week indicated the system running at less than half it's normal performance and the publishing job could run well over two days to complete.
We're holding off with the filter updates until the performance is back to normal.

Comment entered 2016-05-09 10:26:57 by gillbl

- while the performance issues have not been fully resolved they are improved. Would you be comfortable running this on PROD at some point in the near future? Would like to get it schedule if so.

Comment entered 2016-05-09 11:33:54 by Englisch, Volker (NIH/NCI) [C]

This change has been included into the Darwin branch. Therefore the titles will be updated as part of the Darwin release.

Comment entered 2016-05-09 12:01:20 by gillbl

thank you!

Elapsed: 0:00:00.001439