Issue Number | 3892 |
---|---|
Summary | [Misc Docs] Require Publishable Version for Publication of Changes in Misc Docs |
Created | 2015-04-03 17:13:36 |
Issue Type | Bug |
Submitted By | Juthe, Robin (NIH/NCI) [E] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2015-06-04 18:57:19 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.158268 |
As reported by Diana:
Judy made changes in RLSO to several MiscDocs this week (see below). When I was QCing a few summaries in Pubpreview this afternoon, I noticed that the changes were displaying in PP even though the MiscDocs had not been made publishable. Judy then ‘backed out’ of the changes but this didn’t seem to fix the problem.
I talked to Volker and he thinks it has to do with whether or not you make a version of the MiscDoc, not whether or not you publish it. He is going to look at the filter and see if he can shed some light.
Meanwhile, it’s a good bet that the summaries with About This PDQ Summary (and perhaps other summaryFrag MiscDocs) will publish with this problem. To see an example, look at the Disclaimer in Ovarian Epi, FT, and PP, which was hotfixed this week. The text I’ve shown in red is new text, the highlighted text was struck out in the MiscDoc.
As far as we can tell, this is only affecting ‘peripheral text’. It doesn’t look like there are problems in the body of the summaries.
Here are the docs that were updated on Wednesday, 4/1:
1. Patient Summary Fragments CDR0000584249
2. About CAM CDR0000445621
3. About this PDQ Summary CDR0000751603
4. Questions or Comments About This Summary; Contact us - Supportive
care summary CDR0000353162
5. To Learn More; To learn more - CAM patient summary CDR0000445623
Here is a link to the About This PDQ Summary section of the ovarian
summary that Diana mentions in her comment.
http://www.cancer.gov/cancertopics/pdq/treatment/ovarianepithelial/Patient/page9
This is the text she is referring to:
The information in these summaries should not be used to make decisions
about insurance reimbursement. More information on insurance coverage is
available on Cancer.gov on the Coping with Cancer: Financial, Insurance,
and Legal InformationManaging Cancer Care page.
We decided in today's status meeting to investigate why some miscellaneous docs require a publishable version to be published on Cancer.gov, while others require only a version. Ideally, all would require a publishable version but perhaps there is a good reason for this.
All but the following misc documents require a publishable version in order to be picked up by the vendor filters:
CDR0000684055/last - About this PDQ Summary, HP
CDR0000684064/last - Información sobre este sumario del PDQ
CDR0000751603/last - About this PDQ Summary, PT
CDR0000751604/last - Información sobre este sumario del PDQ
CDR0000733750/last - Disclaimer for HP
CDR0000733749/last - Disclaimer for HP-Spanish
I don't see a reason why we wouldn't want to require a publishable version for these 6 documents as well. If anybody disagrees please let me know.
For documentation purposes, this is the list of misc. docs that do require a publishable version in order to be picked up with a publishing job.:
name:Clinical Trial Search Link Text - English-HP;Standard wording/lastp
name:Clinical Trial Search Link Text - Spanish-HP;Standard wording;Spanish/lastp
name:Clinical Trial Search Link Text - English-Patient;Standard wording/lastp
name:Clinical Trial Search Link Text - Spanish-Patient;Standard wording;Spanish/lastp
CDR0000000367/lastp - Get More Information From NCI
CDR0000256873/lastp - Obtenga más infomación del NCI
CDR0000353162/lastp - Questions or Comments About This Summary
CDR0000353206/lastp - Preguntas u opiniones sobre este sumario
CDR0000256925/lastp - For More Information
CDR0000334953/lastp
CDR0000334954/lastp
CDR0000445623/lastp
CDR0000446984/lastp
CDR0000256873/lastp
CDR0000000372/lastp
CDR0000000366/lastp
CDR0000000374/lastp
CDR0000000373/lastp
CDR0000000371/lastp
CDR0000000366/lastp
CDR0000257146/lastp
CDR0000256974/lastp
CDR0000257147/lastp
CDR0000446985/lastp
CDR0000445621/lastp
CDR0000446985/lastp **
CDR0000759356/lastp **
CDR0000446985/lastp
CDR000000367/lastp
CDR0000256873/lastp
CDR0000445622/lastp
CDR0000446986/lastp
CDR0000575822/lastp
CDR0000575821/lastp
CDR0000575839/lastp
CDR0000575840/lastp
The following filter has been updated:
CDR000157.xml - Vendor Filter: Summary
This is ready for testing on DEV.
Volker, what is the best way to test this? Should we make a change in each of the six misc docs you listed above and create a non-publishable version, then run a publishing job and confirm that none of the changes were picked up?
Yes, there are multiple ways to test this but the most thorough
approach would be to run a publishing job before you're
making changes, then create a new version with changes to the misc.
docs, run a publishing job again and run a diff report.
Alternatively, you could just inspect the XML output of a filtered
summary (for each type) by using the Vendor Summary Set filter
set.
We will probably first have to fix the nct_id attribute error you've seen when testing PP before we can run a publishing job for summaries.
I have edited and versioned the following misc docs on DEV:
CDR0000684055/last - About this PDQ Summary, HP
CDR0000733750/last - Disclaimer for HP
CDR0000733749/last - Disclaimer for HP-Spanish
I could not edit the following misc docs since William has them checked out:
CDR0000684064/last - Información sobre este sumario del PDQ
CDR0000751604/last - Información sobre este sumario del PDQ
The following misc doc is currently blocked on DEV:
CDR0000751603/last - About this PDQ Summary, PT
I edited and versioned the following misc docs. They are ready now.
CDR0000684064/last - Información sobre este sumario del PDQ
CDR0000751604/last - Información sobre este sumario del PDQ
I ran a diff report on Friday that didn't show any changes between
the baseline and the test run. However, I believe I ran my baseline run
after Robin edited the English documents, so we can
only say for certain that the changes worked for the documents William
modified.
We can look at a couple of PP reports to confirm the edits aren't picked
up and/or run another diff on QA.
I've started my baseline publishing job on QA already. Since Robin is on
vacation I'm know for a fact that I'm ahead of her this time around.
:-)
The filter has been saved in subversion:
R13221: CDR000157 (Vendor Filter: Summary)
Volker, I edited and versioned each of the following Misc Docs on QA. I didn't make any of the versions publishable. Please run the post-publishing job when you have time. Thanks!
CDR0000684055/last - About this PDQ Summary, HP
CDR0000733750/last - Disclaimer for HP
CDR0000733749/last - Disclaimer for HP-Spanish
CDR0000684064/last - Información sobre este sumario del PDQ
CDR0000751604/last - Información sobre este sumario del PDQ
CDR0000751603/last - About this PDQ Summary, PT
I will need to run the publishing job over night. When I start the publishing job it will make the server nearly unusable for about an hour until all documents have been processed, so I'll have to wait until later tonight.
OK, sounds good. Thank you!
Has this publishing job been completed?
Oops! I keep forgetting to start it.
Do you think you'll run this job tonight so that we could look at it in the morning? Just trying to get an idea of how much longer we'll need to wrap up testing. Thanks!
If we don't need to look at anything on QA during our meeting I could
run the job at 1:30pm. It will take about 1 hour to complete.
I'll have to check with Alan if he's using QA tonight since he's working
until midnight.
Running it at 1:30 would be fine with me.
Do you have changes that are easy to identify? Due to the URL and SummaryAbstract changes there is a lot of output from the diff although it's most likely not related to the changes of the misc. docs.
Yes, the changes I made are something like "RJ TEST" at the beginning of the first paragraph in each misc doc.
The following changes have been identified:
URL change for TrialSearch from
://www.cancer.gov/Search/ClinicalTrialsLink.aspx?... http
to
://www.cancer.gov/search/ClinicalTrialsLink.aspx?... http
New elements SummaryKeyWords, SummaryKeyWord
New elements SummaryAbstract
URL change to board pages
://www.cancer.gov/cancertopics/pdq/adult-treatment-board
http://www.cancer.gov/espanol/pdq/consejo-cuidados-medicos-de-apoyo http
to
://www.cancer.gov/publications/pdq/editorial-boards/adult-treatment
http://www.cancer.gov/espanol/publicaciones/pdq/consejos-editoriales/cuidados-medicos-apoyo http
URL change for ExternalRef
="http://www.cancer.gov/espanol/cancer/... url
to
="/espanol/cancer/... url
No additional changes were identified
Ok, great, it seems none of my edits to the miscellaneous docs were picked up then. Thanks!
I'm not sure what to do to verify this issue. I think Volker was going to run another publishing job and make sure these docs didn't get picked up. Is that correct?
I reran the publishing job and everything looks good. Robin's changes that hadn't been made publishable were not picked up by the publishing filters.
A test to confirm that this ticket landed correctly on PROD would be
to modify a misc. document and create a version that's not publishable.
If something went wrong with the filter changes it would require another
large summary publishing job to "fix" the summaries next week.
Or we wait until the next time a misc. document needs to be updated or
maybe this already has been tested since William mentioned additional
changes on Monday evening?
As discussed at the status meeting we will not test this issue
separately but wait until the next time a misc. doc will have to be
updated.
Closing ticket.
Elapsed: 0:00:00.001394