PDQ Issues

Issue Number	3861
Summary	Summaries Citation report error
Created	2015-01-16 12:06:47
Issue Type	Bug
Submitted By	Beckwith, Margaret (NIH/NCI) [E]
Assigned To	alan
Status	Closed
Resolved	2015-01-30 10:45:27
Resolution	Fixed
Path	/home/bkline/backups/jira/ocecdr/issue.145055

Description

When Sharon and I try to run the Summaries Citation report, we get a python script error message.
Volker is on the case:
The program indicates a missing CDR-ID in the SummaryCitations report causing it to fail. The program should be modified to return with some meaningful message and we should submit a ticket for this.

Comment entered 2015-01-19 12:35:50 by Englisch, Volker (NIH/NCI) [C]

Bob/Alan, here is a bug that made it to PROD with the latest release of Ampere. I see the error on all tiers (can't check QA though since we're unable to connect to the DB). I'm seeing the following error message:

Traceback (most recent call last):
  File "D:\Inetpub\wwwroot\cgi-bin\cdr\SummaryCitations.py", line 74, in &lt;module&gt;
    cdrcgi.bail("Invalid CDR ID entered: %s" % cgi.escape(docId))
  File "D:\Python\lib\cgi.py", line 1035, in escape
    s = s.replace("&amp;", "&amp;amp;") # Must be done first!
AttributeError: 'NoneType' object has no attribute 'replace'

It looks to me that it's a problem related to Alan's security remediation.

Comment entered 2015-01-19 12:39:31 by Englisch, Volker (NIH/NCI) [C]

I forgot - you can recreate the error by running the report from the admin menu:

CIAT/OCCM Staff --> Reports 
                --> Summaries and Miscellaneous Documents 
                --> Summaries Citations

Comment entered 2015-01-19 13:29:19 by Kline, Bob (NIH/NCI) [C]

Bob/Alan, here is a bug that made it to PROD with the latest release of Ampere.

Ampere hasn't made it to PROD yet (we're only as far as QA).

Comment entered 2015-01-19 14:26:07 by Englisch, Volker (NIH/NCI) [C]

Oh, right, in that case it was the latest release before Ampere that caused the problem.

Comment entered 2015-01-20 15:29:23 by alan

This was indeed a bug I introduced. I fixed and tested it on DEV, then copied the fix to QA. When CBIIT gets QA working it can be tested there. Until then we probably have to wait for further testing since Bob has been making login authentication changes and tests on DEV that make it hard to use at this time.

The fix will be promoted to DEV when the "Mailer Hotfix" is promoted. If preferred, I can inquire about making a separate, earlier hotfix for this one file.

Comment entered 2015-01-23 10:33:40 by Beckwith, Margaret (NIH/NCI) [E]

Hi William, Would you mind testing this on QA? I am actually off today and was going to try and do it from home but don't think I can get into the CDR from here. Thank you!

Comment entered 2015-01-29 15:14:05 by Juthe, Robin (NIH/NCI) [E]

Added William and myself as watchers.

Comment entered 2015-01-30 10:45:40 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA

Comment entered 2015-02-16 09:30:10 by Osei-Poku, William (NIH/NCI) [C]

Verified on Stage.

Comment entered 2015-02-19 12:14:09 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD.

Elapsed: 0:00:00.001606

CDR Tickets