Issue Number | 3687 |
---|---|
Summary | Modify Vendor Filter to remove Source Title attribute from Vendor Output |
Created | 2013-12-09 14:49:39 |
Issue Type | New Feature |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2014-02-04 18:13:53 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.115846 |
The SourceTitle attribute was added to RelatedExternalRef element of the GTC schema and the ExternalRef element of the Summary schema. Please modify the vendor filters to exclude/remove this attribute.
The vendor cleanup filter has been modified on DEV.
This is ready for review.
Verified on QA
The filter has been installed on PROD:
R12246: CDR315588 - Module: Vendor Cleanup Templates
Please verify on PROD and close this ticket.
I have verified this on Prod. I think it is okay to proceed with the hot-fix.
Could we also include a term that was modified but didn't contain this Source attribute? I'm still a little nervous because these four documents all failed with the same error. In the case that they all fail we'd have to request the DB team to run manual database updates because a failed publishing job would block all following publishing jobs.
We ran a hot-fix for the failed documents and those were successfully updated in production.
There was an error related to this issue in last week's publishing. Below is an offline communication with Volker about it.
>>>>>>>>>>
I’m surprised this wasn’t caught when the filter changes to remove the
SourceTitle attribute was tested.
The filter appears to only remove the SourceTitle attribute properly
from the UseWith=”en” elements but not the Spanish ones.
Could you please reopen that issue to get this filter fixed? (OCECDR-3687)
Thanks,
Volker
___________________________________
Volker Englisch
NCI OCE - Communications Technology Branch
Contractor: Sapient Government Services
NCI: 240-276-6583
From: Osei-Poku, William William.Osei-Poku@icfi.com
Sent: Monday, February 03, 2014 11:41 AM
To: Englisch, Volker (NIH/NCI) [C]
Subject: RE: CBIIT-PROD: Status and Error Report for Weekly
Publishing
It says the SourceTitle attribute (in the GTC) is not declared. It appears that it is referring to the Vendor filters. Everything appears to be fine with the document. Could you please take a look?
46590 10 GlossaryTermName laboratory test; prueba de laboratorio [es]
ERROR
No declaration for attribute SourceTitle of element
RelatedExternalRef
------Original Message
From: Englisch, Volker (NIH/NCI) [C] volker@mail.nih.gov
Sent: Monday, February 03, 2014 9:59 AM
To: Osei-Poku, William
Subject: FW: CBIIT-PROD: Status and Error Report for Weekly
Publishing
FYI:
There is one document with a validation error.
Thanks,
Volker
This has been updated on DEV and is ready for testing.
Ready for testing on DEV.
Verified on DEV. Pub preview worked fine with the elements and attributes populated.
Could you please mark up a couple documents on QA?
I will then run a publishing job before and after the filter update.
Done on QA.
sentinel lymph node biopsy (GTN: 46712; GTC: 622341)
Gardasil (GTN: 661954; GTC: 661953)
uterus (GTN: 46645; GTC: 619886)
digestive system (GTN: 46446; GTC: 622140)
angiogenesis (GTN: 46529; GTC: 622207)
The following filter has been versioned in SVN:
R12311: CDR315588 - Module: Vendor Cleanup Templates
I'm currently running diff reports on QA.
The test publishing job listed 9 failures on QA before the update of the filter and none after the update of the filter.
The filter change has been copied to production.
Please verify on PROD and close this ticket.
Verified on QA.
Verified on PROD. Thanks!
Elapsed: 0:00:00.001399