CDR Tickets

Issue Number 3656
Summary Small Fixes
Created 2013-08-28 19:10:00
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2013-09-23 17:04:56
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.112552
Description

This issue captures small changes that need to be included in the next release but there doesn't exist a separate ticket.

Comment entered 2013-08-28 19:13:05 by Englisch, Volker (NIH/NCI) [C]

The following program needs to be moved to submit a message when the Jobmaster job fails due to 'max time exceeded':

  • R11994: SubmitPubJob.py

We may want to reduce the max time from 18 hours by the time this release goes to production.

Comment entered 2013-09-23 17:04:56 by Englisch, Volker (NIH/NCI) [C]

I believe this change was actually included in the last patch (R11994) and we didn't come across any additional of these 'small changes' since the patch.

Comment entered 2013-09-24 11:59:23 by alan

I've added a trivial change to cdrpub.py to query the database ctl table to see how many threads should be used in publishing. This enables us to experiment to find the most efficient thread count without requiring CBIIT to modify the script each time we want to change something.

Comment entered 2013-09-24 14:56:16 by Englisch, Volker (NIH/NCI) [C]

I've successfully tested Alan's changes on DEV.

A little side note. The log message 'Using N threads, defined in ctl table' will now be displayed for every filter event (not just for publishing events).

Comment entered 2013-09-24 15:07:45 by alan

Another side note. The version of cdr.py that has the updateCtl function that can be used to update the control table from a Python client is on DEV and in svn but is not in QA or PROD. I'll leave it out of QA for now as a test of our update script.

Comment entered 2013-09-25 14:56:05 by Englisch, Volker (NIH/NCI) [C]

PublishPreview on DEV works fine. On QA, however, access to the CSS files has been blocked. Wenling was able to have the firewall opened for access to www.qa.cancer.gov on port 80.
In order to have the same look-and-feel of Cancer.gov I'm going to modify the PP output to retrieve the CSS from the QA Cancer.gov. Files to be updated:

  • PublishPreview.py

Comment entered 2013-09-25 16:04:26 by Englisch, Volker (NIH/NCI) [C]

The following program has been modified

  • R12041: PublishPreview.py

Unfortunately, the changes can't be tested on QA at the moment as the PP doesn't work for Summaries and DrugInfos. However, one could use a Glossary Term for testing.

Comment entered 2013-09-27 12:10:58 by Englisch, Volker (NIH/NCI) [C]

{color:green}
We may want to reduce the max time from 18 hours by the time this release goes to production.

{color}

With the publishing job now running at a reasonable speed I have adjusted the parameter back.

  • PROD: 8 hours

  • DEV/QA: 12 hours

The following script has been updated:

  • R12047: SubmitPubJob.py

Comment entered 2013-10-04 14:55:03 by Englisch, Volker (NIH/NCI) [C]

I identified that the program FtpOtherData.py failed repeatedly due to a previous network failure. When this happens the lock file has to be manually removed before other FTP jobs will succeed.
I've added an email notification when such an error occurs.
The following program has been updated:

  • R12063: FtpOtherData.py

Comment entered 2013-10-29 14:02:08 by Englisch, Volker (NIH/NCI) [C]

Another little fix for production: The option to abort a push job that failed to properly finish copying all documents did not work because it listed 'Bach' as the data source. This has been fixed in DEV.

  • R12086: cdr2gk.py

Comment entered 2013-10-30 16:49:36 by Englisch, Volker (NIH/NCI) [C]

There were minor log string changes to this file that had not been versioned:

  • R12096: FtpOtherData.py

Comment entered 2013-11-01 17:02:42 by Kline, Bob (NIH/NCI) [C]

Two more small fixes:

  • R11998: /trunk/Utilities/Bin/DownloadCtrpTrials.py - fix typo in error logging code

  • R11996: /trunk/Utilities/UploadCtepReport.py - add missing check in getPassword() function

Elapsed: 0:00:00.001722