CDR Tickets

Issue Number 3596
Summary [GenProf] Default response in mailer email question
Created 2013-03-22 12:43:54
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2013-09-10 08:59:01
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107924
Description

BZISSUE::5295
BZDATETIME::2013-03-22 12:43:54
BZCREATOR::William Osei-Poku
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

It looks like the default selection (response) to the "Publish email address in directory" question in the mailer defaults to "Yes" regardless of the existing status of the attribute in the CDR record. So even if a Gen. Prof's CDR record currently has a "Not Public" attribute on the email, when he gets a mailer, the answer to the question will still say "Yes" (default to “Yes” as if we currently have it set to public) and he will have to change it to "No" each time a mailer is sent and we will always see it in the diff report as if there is a change but when we go into the record, there wouldn't be any change to make. Could you please look into this and fix it?

Comment entered 2013-09-03 17:10:18 by Kline, Bob (NIH/NCI) [C]

That value on the form isn't controlled by an attribute. We were told to use the value from

AdministrativeInformation/Directory/Include

(yes, I know that the label on the form says "email address" and this element doesn't mention email).

Please confirm that you want the logic changed, and I'll implement that change.

Comment entered 2013-09-03 17:50:25 by Osei-Poku, William (NIH/NCI) [C]

Yes, for Gen. Prof person, please change the logic so that the attribute controls the display on the mailer.

Comment entered 2013-09-04 09:39:32 by Kline, Bob (NIH/NCI) [C]

Volker:

I'm assigning this task to you because the change in the logic for this field on the mailers needs a change to the filters for the genetics professionals, in order to pass along the value of the Public attribute associated with the selected email address. Once the filters have been modified to supply this new information, you can assign the task back to me. Thanks.

Comment entered 2013-09-09 15:25:59 by Englisch, Volker (NIH/NCI) [C]

I modified the following filter in order for the Public="No" attribute to be picked up for the location email address.

  • R12011: CDR0000559215.xml - Vendor Filter: GeneticsProfessional

We probably want to run a diff report on QA before this gets promoted to PROD but I'd like to wait until I know there's nothing else to be done for the filter.

Comment entered 2013-09-09 15:26:54 by Englisch, Volker (NIH/NCI) [C]

Reassigned issue back to Bob as requested.

Comment entered 2013-09-10 08:26:39 by Kline, Bob (NIH/NCI) [C]

Do we need to notify the licensees of the change in the schema? Or are you stripping the new value out by a post-processing filter for the vendor output?

Comment entered 2013-09-10 08:59:01 by Kline, Bob (NIH/NCI) [C]

Ready for testing on DEV.

Comment entered 2013-09-10 11:27:32 by Englisch, Volker (NIH/NCI) [C]

I'll have to double-check but I'm pretty sure we're not providing email addresses for the GPs. They are only included to be picked up by the mailers and are then removed.

Still, we should run a diff report for the vendor output on QA.

Comment entered 2013-09-11 15:41:48 by Osei-Poku, William (NIH/NCI) [C]

Tested on DEV. It works as expected. Thanks!!

Comment entered 2013-11-01 17:46:44 by Kline, Bob (NIH/NCI) [C]

Also included for build:

  • R12014 /trunk/Mailers/GPMailers.py

Comment entered 2013-11-08 19:25:46 by Osei-Poku, William (NIH/NCI) [C]

I get a HTTP 403 Forbidden error when I try to access the test mailers.

Comment entered 2013-11-12 19:37:54 by Kline, Bob (NIH/NCI) [C]

Permissions fixed. Do we need to tell CBIIT to hold up on the rollout of the release?

Comment entered 2013-11-13 08:12:47 by Osei-Poku, William (NIH/NCI) [C]

Verified in QA. There is no need to delay the release.

Comment entered 2013-12-05 10:21:01 by Osei-Poku, William (NIH/NCI) [C]

Verified in Prod.

Elapsed: 0:00:00.000653