CDR Tickets

BZDATETIME::2011-12-09 13:28:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I've collected all of the Summary attachments for all of the summary types and listed in the attached document. The yellow-highlighted row lists content coming from the CDR document. All other section are attached by the vendor filters.

If there should be any additional changes from the original request please let me know.

Attachment SummaryAttachment.xls has been added with description: Attachments for all Summaries Types

BZDATETIME::2011-12-28 16:49:43
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

(In reply to comment #0)
> We would like to suppress the section called More Information completely so
> that it doesn't show on Cancer.gov.

Currently, there are three different "More Information" documents in use:
1) CDR256925 - For more information - CAM summary; English; HP
2) CDR334953 - For more information - Health professional summary; English; HP
3) CDR334954 - For more information - Health professional summary; Spanish; HP

Is it correct that we want to suppress the display of all three documents (including for the CAM summaries)?

BZDATETIME::2011-12-28 17:04:17
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::3

Yes.

BZDATETIME::2011-12-29 11:39:29
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

I've modified the vendor filters to re-arrange the summary attachments/misc. docs and listed them in the spreadsheet for review.

Attachment SummaryAttachment_new.xls has been added with description: Attachments for all Summaries Types (old vs. new)

BZDATETIME::2011-12-29 11:42:50
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::5

It looks like all of the Patient summaries are missing the Get More Information from NCI section.

BZDATETIME::2011-12-29 15:08:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

I dropped that section and it was hiding under the sofa but I found it and included it to the patient summaries.

BZDATETIME::2011-12-29 15:09:42
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

Updating the attachment.

Attachment SummaryAttachment_new.xls has been added with description: Attachments for all Summaries Types (old vs. new)

BZDATETIME::2012-01-05 12:20:17
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::8

We would like to make the changes to the health professional summaries and hold off on the patient summaries for now, pending some user testing we are doing in a few weeks.

BZDATETIME::2012-01-19 10:45:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

I've reverted the changes to the patient summaries in the filter
CDR000157 - Vendor Filter: Summary

This is ready for review on MAHLER.

BZDATETIME::2012-01-20 12:25:55
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::10

(In reply to comment #9)
> I've reverted the changes to the patient summaries in the filter
> CDR000157 - Vendor Filter: Summary
>
> This is ready for review on MAHLER.

I have reviewed many HP summaries and they all appear to be in the new order. I am just wondering though if this affects Spanish summaries and whether they should be reviewed also.

BZDATETIME::2012-01-20 12:26:59
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::11

Yes, we want the order of the sections in the Spanish summaries to be the same as in the English.

BZDATETIME::2012-01-20 13:29:24
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::12

(In reply to comment #11)
> Yes, we want the order of the sections in the Spanish summaries to be the same
> as in the English.

Thanks Margaret!

We have reviewed several summaries including Spanish summaries and they all show the new order so I think this can be promoted to Bach.

BZDATETIME::2012-01-20 15:22:43
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

I've versioned the changes to the filter in SVN:
CDR000157 - Vendor Filter: Summary - R10300

Please note that this can only be moved to production along with OCECDR-3441.

BZDATETIME::2012-01-25 16:55:30
BZCOMMENTOR::Robin Juthe
BZCOMMENT::14

(In reply to comment #13)
> I've versioned the changes to the filter in SVN:
> CDR000157 - Vendor Filter: Summary - R10300
> Please note that this can only be moved to production along with OCECDR-3441.

This looks good on Mahler except I noticed the subheadings underneath "About This PDQ Summary" are now displaying in the TOC. Don't think that was the case before (they do not display on the live site), but I actually do like seeing those subheadings since I think it could help users find info about permissions, reviewers, etc. Margaret, what do you think?

The subheadings also appear to be bold, while the other headings in the TOC are not.

BZDATETIME::2012-01-25 18:03:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

(In reply to comment #14)
> This looks good on Mahler except I noticed the subheadings underneath "About
> This PDQ Summary" are now displaying in the TOC.

This is very odd since the XML for the section (comparing the XML output on MAHLER with the output on BACH) is identical. I could imagine that Cancer.gov suppressed the display of sub-summary section in the very last SummarySection. Now that the About This section is not the last anymore the sub-section heading are being displayed and since those sub-section headings are listed within <Strong> tags in the Misc. Document they are displayed in bold in the TOC as well.

I can check on this with Blair.

BZDATETIME::2012-01-27 12:35:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

(In reply to comment #15)
> I can check on this with Blair.

I checked with Blair and neither of us has an explanation at the moment of why the sub-sections of the 'About PDQ' section are displayed after the re-ordering but did display before.
For the moment we may have to live with the fact that the TOC will change and fix it after the 6.4 rollout.
However, I would suggest to remove the <Strong> attribute from the section titles in the Misc. doc to ensure that the subsections aren't being listed in bold while the sections are listed normally.

BZDATETIME::2012-01-27 13:59:13
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::17

Robin and I looked at this on Franck and decided that for now, removing the strong tags is adequate so Robin is taking them out of the Misc. Doc. on Bach. We think that having the subsections show isn't bad, and we want to get feedback from the other Board Managers.

BZDATETIME::2012-01-27 14:00:56
BZCOMMENTOR::Robin Juthe
BZCOMMENT::18

I removed the strong tags on Bach.

This is ready to be promoted.

BZDATETIME::2012-01-27 14:13:58
BZCOMMENTOR::Volker Englisch
BZCOMMENT::19

Did you also make the changes on FRANCK? We could then run publish preview and confirm that the TOC subsection won't be displayed in bold.

These filters will be promoted tonight after the regular publishing job finished.

BZDATETIME::2012-01-27 14:14:53
BZCOMMENTOR::Robin Juthe
BZCOMMENT::20

(In reply to comment #19)
> Did you also make the changes on FRANCK? We could then run publish preview and
> confirm that the TOC subsection won't be displayed in bold.
> These filters will be promoted tonight after the regular publishing job
> finished.

Yes, we made the changes on Franck and verified that the section headings were not in bold in the TOC.

BZDATETIME::2012-01-27 22:17:28
BZCOMMENTOR::Volker Englisch
BZCOMMENT::21

Updating multiple related bugs at once:

The following filters have been updated on BACH:

• CDR000157 - Vendor Filter: Summary - R10300

• CDR271370 - Module: Vendor Filter Templates - R10264

• CDR712005 - Denormalization Filter: Summary Module - R10299

• CDR723649 - Denormalization Filter: Summary Module IDs - R10299

• CDR723518 - Denormalization Filter: Summary Count Tables and Figures

• R10299

• CDR723519 - Denormalization Filter: Summary Resolve Table and Figure Number

• R10308

• CDR335424 - Denormalization Filter: Summary - R10307

• CDR409593 - Copy XML for Summary Report - R10310

• CDR609947 - Vendor Filter: Convert CG to Public Data - R10309

The DTD has been updated:

• pdq.dtd - R10122

• pdqCG.dtd - R10306

The CSS has been updated:

• Summary.css - R10312

• Summary_structure.css - R10312

• Summary.ctm - R10311

The filter set 'Denormalization Summary Set' has been updated to include the following members:

• Denormalization Filter: Summary Add Board Member - Spanish

• Denormalization Filter: Summary Module

• Denormalization Filter: Summary Module IDs

• Denormalization Filter: Summary

• Denormalization Filter: Summary Citation Formatting

• Denormalization Filter: Summary Reference List

• Denormalization Filter: Summary Reference De-Dup

• Denormalization Filter: Summary Reference Numbering

• Denormalization Filter: Summary InLine Numbering

• Denormalization Filter: Summary Citation Wrapper Add

• Denormalization Filter: Summary Citation Wrapper Sort

• Denormalization Filter: Summary Count Tables and Figures

• Denormalization Filter: Summary Resolve Table and Figure Number

BZDATETIME::2012-01-31 17:23:52
BZCOMMENTOR::Robin Juthe
BZCOMMENT::22

We agreed on the following sequence for the last 4 sections of the patient treatment summaries:

Changes to This Summary
To Learn More About X Cancer
Get More Information From NCI
About PDQ

BZDATETIME::2012-02-01 10:38:42
BZCOMMENTOR::Robin Juthe
BZCOMMENT::23

This attachment shows the new sequence (in blue) for the final sections of the CAM, supportive care, screening, and prevention summaries. (Treatment, too, although that was described in the last comment.)

We would like to add the "About PDQ" section to the CAM summaries. It will be the final section.

Attachment Order of Summary Sections.xls has been added with description: Order of sections in patient summaries

BZDATETIME::2012-02-01 11:07:43
BZCOMMENTOR::Volker Englisch
BZCOMMENT::24

Just a note to all (including myself):

We should not put this in production until
a) all of the current Gatekeeper/Mobile issues have been resolved and
b) we coordinated the update with Blair/Prasad
because Blair's hair turns grey every time there are more than 50 updated summaries part of the publishing job.

BZDATETIME::2012-02-01 15:10:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::25

(In reply to comment #22)
> We agreed on the following sequence for the last 4 sections of the patient
> treatment summaries:
>
> Changes to This Summary
> To Learn More About X Cancer
> Get More Information From NCI
> About PDQ

The 'To Learn More About X Cancer' is coming from the document and not from the filters attaching misc. information.
Is it expected for the filter to flip the 'Changes to This Summary' and the 'To Learn More' sections or will this be done in the document itself?

BZDATETIME::2012-02-01 17:53:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::26

(In reply to comment #23)
> We would like to add the "About PDQ" section to the CAM summaries. It will be
> the final section.

Since each summary type owns an individual "About PDQ" misc. document I am assuming that we will create one of those for the CAM summaries as well unless there is an existing one I should be using.
For right now I have used the Adult Treatment version.

This is ready for review on MAHLER.
Please note, I have not done anything in regard to the 'To Learn More About...' section (comment 25).

BZDATETIME::2012-02-02 09:17:22
BZCOMMENTOR::Robin Juthe
BZCOMMENT::27

(In reply to comment #25)

> Is it expected for the filter to flip the 'Changes to This Summary' and the 'To
> Learn More' sections or will this be done in the document itself?

Maybe we could do this with a global change? Let's discuss today.

BZDATETIME::2012-02-09 11:13:55
BZCOMMENTOR::Volker Englisch
BZCOMMENT::28

The new order of summary sections is now displayed on Cancer.gov for the HP summaries.

However - and I know this has been discussed at least 87 times - it might be a good time to re-iterate the fact that the display of white space between summary sections still needs to be fixed or adjusted.

The white space between a main summary section following the Reference section looks great but the white space for the 'About This PDQ Summary' section is off as is the case whenever a section title is displayed without a previous Para-type element.
There should be more vertical white space above the 'About This PDQ Summary' and less vertical white space below.
There should be more vertical white space above the 'Get More Information...' summary section title as well.

Please follow this link as an example of the spacing issue:
http://cancer.gov/cancertopics/pdq/treatment/bladder/HealthProfessional/page1/AllPages#11
I'm not sure if a ticket for this exists in Sharepoint. I looked through most of the tickets but could not find anything related. If a ticket needs to be created I'd be happy to do this.

Note: This is also listed as Cancer.gov issue 9 in OCECDR-2832 comment #36.

BZDATETIME::2012-03-01 12:15:40
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::29

I think it is fine to:
1. Keep the Changes to this Summary and the To Learn More sections in the current order, and
2. To use the Adult Treatment version of the About PDQ section for the CAM summaries. [Note: I don't think we need to have separate versions for each type of summary (something else for the CIS team to work on this year!).]

BZDATETIME::2012-03-05 13:39:20
BZCOMMENTOR::Volker Englisch
BZCOMMENT::30

Updated the list of attachments to reflect the latest decision.

Attachment SummaryAttachment_new.xls has been added with description: Attachments for all Summaries Types (old vs. new)

BZDATETIME::2012-03-07 13:27:18
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::31

I think this looks fine. You can promote the patient summary changes.

BZDATETIME::2012-03-09 19:02:16
BZCOMMENTOR::Volker Englisch
BZCOMMENT::32

We had hoped to move this to production before the weekly publishing job but I was reading through the issue and realized that this filters can not go to production without the changes in OCECDR-3311.

Also, it seems that the changes to the patient summaries sections have not yet been reviewed. I have updated the filters on MAHLER and FRANCK:

• CDR000157 - Vendor Filter: Summary - R10347

• CDR271370 - Module: Vendor Filter Templates - R10347

This is ready for testing on FRANCK for the patient summaries.

BZDATETIME::2012-03-14 17:39:19
BZCOMMENTOR::Volker Englisch
BZCOMMENT::33

Have the changes to the patient summaries sections already been reviewed? We were hoping to put this in production for Friday's weekly publishing job.

Please note, once we're putting these changes and the changes for OCECDR-3311 into production we will nearly publish every single summary during the following weekly publishing job. The changes for this bug will affect every patient summary and the changes in OCECDR-3311 will affect every HP summary that contains a table.

BZDATETIME::2012-03-14 18:16:56
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::34

I got python script errrors for every patient summary I looked at on Mahler and Franck:
<type 'exceptions.Exception'> Python 2.7.1: D:\Python\python.exe
Wed Mar 14 18:14:53 2012

A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred.
D:\Inetpub\wwwroot\cgi-bin\cdr\PublishPreview.py in ()
349 #fp.close()
350 except:
=> 351 cdrcgi.bail('Error in PubPreview: ' + str(cdr2gk.pubPreview(doc, flavor)))
352
353 #----------------------------------------------------------------------
cdrcgi = <module 'cdrcgi' from 'D:\cdr\Lib\Python\cdrcgi.pyc'>, cdrcgi.bail = <function bail>, builtin str = <type 'str'>, cdr2gk = <module 'cdr2gk' from 'D:\cdr\Lib\Python\cdr2gk.py'>, cdr2gk.pubPreview = <function pubPreview>, doc = '\n\n<Summary id="CDR0000062697" LegacyPDQID="1189"...Modified>2010-10-22</DateLastModified></Summary>\n', flavor = 'Summary'

BZDATETIME::2012-03-14 19:02:09
BZCOMMENTOR::Volker Englisch
BZCOMMENT::35

According to the error message it's an 'Internal Server Error' meaning Gatekeeper/Percussion is having problems. I will need to talk to Blair tomorrow.

BZDATETIME::2012-03-15 16:44:08
BZCOMMENTOR::Volker Englisch
BZCOMMENT::36

Blair reported that the PP problems on FRANCK have been fixed. I haven't been able to check it out myself but please go ahead.

BZDATETIME::2012-03-16 10:39:52
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::37

We have reviewed the order of sections for English summaries and they are all okay. There were some stray text on Mahler but I guess that is just a Mahler issue. We'll review the text on Bach when it is promoted. We are waiting for the Spanish Summaries to be reviewed. I will let you know when it is completed.

BZDATETIME::2012-03-16 11:06:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::38

Could you please tell me more about the "stray text"? What text, what filters did you run?

At this point MAHLER is very much out of sync from BACH and it is especially tricky to keep track of new filters and filter sets. I would like to double-check that everything is correct on FRANCK before I do the promotion of the filter changes.

BZDATETIME::2012-03-16 12:06:42
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::39

(In reply to comment #38)
> Could you please tell me more about the "stray text"? What text, what filters
> did you run?
>
> At this point MAHLER is very much out of sync from BACH and it is especially
> tricky to keep track of new filters and filter sets. I would like to
> double-check that everything is correct on FRANCK before I do the promotion of
> the filter changes.

Well, the stray text is just in the Breast Cancer and Pregnancy summary on Mahler so it is not coming from either a misc doc or from the vendor filters. We are only reviewing this in pub preview.

(In reply to comment #37)
> We are waiting for
> the Spanish Summaries to be reviewed. I will let you know when it is completed.

Spanish summaries have been reviewed with no problems found so we are good to go.

BZDATETIME::2012-03-16 16:05:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::40

The following filters have been copied to FRANCK and BACH:
CDR271370 - Module: Vendor Filter Templates - R10347
CDR000157 - Vendor Filter: Summary - R10347

I've also updated the filter sets on BACH to make the adjustment for the QC reports to display insertion/deletion markup for content within summary modules.
The following filter sets have been created or adjusted:

• Denormalization Summary Module Set (new)

• Denormalization Summary Set

• QC QD Summary Patient Set

• QC QD Summary Patient Set (Bold/Underline)

• QC QD Summary Set

• QC QD Summary Set (Bold/Underline)

• QC Summary Patient Set

• QC Summary Patient Set (Bold/Underline)

• QC Summary Set

• QC Summary Set (Bold/Underline)

• Vendor QC Summary Set

• Vendor Summary Set

Please verify the changes on Cancer.gov after tonight's publishing job.

BZDATETIME::2012-03-19 16:32:01
BZCOMMENTOR::Volker Englisch
BZCOMMENT::41

It looks to me that all patient summary sections are now displayed on Cancer.gov according to our new list.

BZDATETIME::2012-03-21 11:54:59
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::42

(In reply to comment #41)
> It looks to me that all patient summary sections are now displayed on
> Cancer.gov according to our new list.

We've also reviewed some of the trials on Cancer.gov and they all look good.

BZDATETIME::2012-03-30 12:56:09
BZCOMMENTOR::Volker Englisch
BZCOMMENT::43

Robin indicated that she had looked at the new order of the sections as well and this issue can be closed now.