CDR Tickets

BZDATETIME::2011-12-02 14:34:47
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I've modified the vendor post-processing filter to remove the elements and attributes that have just been added for Cancer.gov: Included/ExcludedDevices attributes, PermaTargs elements, MobileURL elements.

For the IncludedDevices/ExcludedDevices I'm currently only handling the cases that are possible based on the information in the schema. If we're starting to allow multiple devices to be specified as in "mobile ebook screen" the filters would need to be modified.
I am wondering if I should write the filters in a way that those future cases could be handled, too (even though we wouldn't be able to test them at this point)?

The filter modified was
CDR609947 - Vendor Filter: Convert CG to Public Data

This is ready for testing on MAHLER.

I tested using the document CDR650101.

BZDATETIME::2011-12-29 11:23:47
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2

(In reply to comment #1)

> The filter modified was
> CDR609947 - Vendor Filter: Convert CG to Public Data
>
> This is ready for testing on MAHLER.
>
> I tested using the document CDR650101.

Should I use the filter document tool to test this or use pub preview?

BZDATETIME::2011-12-29 11:44:30
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

You will not be able to use the PP report because this would only show you what will be displayed on Cancer.gov but (a) the attribute are not being displayed to the user and (b) the removal of these attributes is happening as an additional step after Gatekeeper received the PDQ data.

This is something that needs to be checked in the XML.
Let me look at this issue again, I may need to give you additional instructions on how to best review this.

BZDATETIME::2011-12-30 16:46:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

This is what you can do to test:
a) Prepare a document to include IncludedDevices/ExcludedDevices attributes.
b) Filter that document using the UI
http://mahler.nci.nih.gov/cdrFilter.html
by entering your modified document and the filter set
set:Vendor Summary Filter
c) Look at the XML output to confirm that the attributes are displayed
d) Validate the output to confirm that the GK DTD validates the output.
e) Modify the DTD to pdq.dtd and validate the output to confirm that the
licensee DTD does not accept the output data without warnings and errors.
f) Add the modified filter
name:Vendor Filter: Convert CG to Public Data
and modify the DTD to pdq.dtd
g) Look at the XML output to confirm that the attributes are removed from the
output.
h) Validate the output to confirm that the licensee DTD validates the output.

BZDATETIME::2012-01-03 13:17:20
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

I am getting a python script error when I click on the "Submit Filter Request" button.

"A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred.
D:\Inetpub\wwwroot\cgi-bin\cdr\Filter.py in ()
319
320 doc = cdr.filterDoc(session, filtId, docId = docId, docVer = docVer,
....... "

Let me know if you want me to paste the entire error here.

How are the word "set" and the colon supposed to be spaced? I copied what you wrote above and pasted it exactly as you have it and I got "Unable to find filter set: Vendor Summary Filter". However, when I bring a space between the word "set" and the colon, I get the python script error above.

I am using the following document for testing:
CDR0000257989

BZDATETIME::2012-01-03 14:18:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

Please replace
set:Vendor Summary Filter
with
set:Vendor Summary Set

BZDATETIME::2012-01-04 13:51:58
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::7

a), b), c) d) done without any problems.
Besides the sections I manually added the attributes, I found the attributes in the following sections:

To Learn More About Adult Acute Lymphoblastic Leukemia
Changes to summary
About PDQ
Get More Information From NCI

I assume you would complete e) and f) and let me know to verify g)?

BZDATETIME::2012-01-04 15:11:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

(In reply to comment #7)
> I assume you would complete e) and f) and let me know to verify g)?

No, you would do this in the same filter interface you're using for a) - d) since this would be the true QC. Items (a) - (d) are merely a confirmation that there is actually content that would need to be removed.

BZDATETIME::2012-01-04 15:33:36
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

(In reply to comment #8)
> (In reply to comment #7)
> > I assume you would complete e) and f) and let me know to verify g)?
>
> No, you would do this in the same filter interface you're using for a) - d)
> since this would be the true QC. Items (a) - (d) are merely a confirmation
> that there is actually content that would need to be removed.

Then, I will need further instructions on steps e) and f) since this would be the first time I am going to be doing this. For example, for step e), how do I modify the DTD?

BZDATETIME::2012-01-04 15:40:09
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

(In reply to comment #9)
> For example, for step e), how do I modify the DTD?

Sorry, since you've never done this before it may not be obvious to you.
On the Document Filtering form you navigate to the field DTD and where it says 'pdqCG.dtd' just change that to 'pdq.dtd'.

If you're having problems with this we could get together after our meeting tomorrow and I'll show you. It'll take no more than 5 minutes.

BZDATETIME::2012-01-04 16:07:32
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

f) is done with errors. It looks like that should be expected, right? I will call you about g) for clarification.

BZDATETIME::2012-01-04 16:24:15
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::12

(In reply to comment #11)
> f) is done with errors. It looks like that should be expected, right? I will
> call you about g) for clarification.

Correction: The above was meant for step e) and not f).

I can now confirm that steps a) through h) have been completed and the results were as expected. Thanks for explaining the steps to me, Volker.

BZDATETIME::2012-01-20 17:55:55
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

Adding dependency.

BZDATETIME::2012-01-27 15:00:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14

The following filter has been copied to FRANCK:
CDR609947 - Vendor Filter: Convert CG to Public Data - R10309

Things to do tonight:

• install filter
  CDR609947 - Vendor Filter: Convert CG to Public Data - R10309

• update DTD
  pdq.dtd - R10122
  pdqCG.dtd - R10306

BZDATETIME::2012-01-27 22:17:31
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

Updating multiple related bugs at once:

The following filters have been updated on BACH:

• CDR000157 - Vendor Filter: Summary - R10300

• CDR271370 - Module: Vendor Filter Templates - R10264

• CDR712005 - Denormalization Filter: Summary Module - R10299

• CDR723649 - Denormalization Filter: Summary Module IDs - R10299

• CDR723518 - Denormalization Filter: Summary Count Tables and Figures

• R10299

• CDR723519 - Denormalization Filter: Summary Resolve Table and Figure Number

• R10308

• CDR335424 - Denormalization Filter: Summary - R10307

• CDR409593 - Copy XML for Summary Report - R10310

• CDR609947 - Vendor Filter: Convert CG to Public Data - R10309

The DTD has been updated:

• pdq.dtd - R10122

• pdqCG.dtd - R10306

The CSS has been updated:

• Summary.css - R10312

• Summary_structure.css - R10312

• Summary.ctm - R10311

The filter set 'Denormalization Summary Set' has been updated to include the following members:

• Denormalization Filter: Summary Add Board Member - Spanish

• Denormalization Filter: Summary Module

• Denormalization Filter: Summary Module IDs

• Denormalization Filter: Summary

• Denormalization Filter: Summary Citation Formatting

• Denormalization Filter: Summary Reference List

• Denormalization Filter: Summary Reference De-Dup

• Denormalization Filter: Summary Reference Numbering

• Denormalization Filter: Summary InLine Numbering

• Denormalization Filter: Summary Citation Wrapper Add

• Denormalization Filter: Summary Citation Wrapper Sort

• Denormalization Filter: Summary Count Tables and Figures

• Denormalization Filter: Summary Resolve Table and Figure Number

BZDATETIME::2012-02-09 10:25:59
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

The vendor filter changes had been implemented and tested successfully. However, I failed to modify the program
CG2Public.py
to actually apply those changes for the Summaries post process. A licensee contacted me indicating that the summaries didn't validate.

I've made the necessary changes, tested them on MAHLER and moved the change to production for Friday's weekly publishing job.

I still need to fix the data that's currently on the FTP site.

BZDATETIME::2012-02-14 17:43:44
BZCOMMENTOR::Volker Englisch
BZCOMMENT::17

The last weekly publishing job finished without problems.

BZDATETIME::2012-03-14 16:59:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18

The mobile portion of this issue is in production but we're keeping the issue around until the deep-linking portion has been tested and promoted.

BZDATETIME::2012-05-22 13:53:14
BZCOMMENTOR::Volker Englisch
BZCOMMENT::19

The filter in production already removes the PermaTargs block from the vendor data and there is nothing else to do here except for testing.

BZDATETIME::2012-08-06 16:26:14
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

Per discussion at last week's status meeting it is unclear at this point when the permatargs will be used for the first time and we're closing this issue at this point.