CDR Tickets

BZDATETIME::2011-09-08 11:42:42
BZCOMMENTOR::Alan Meyer
BZCOMMENT::1

This looks pretty easy. I think we did it once before.

I'll work on it this afternoon.

BZDATETIME::2011-09-08 15:40:10
BZCOMMENTOR::Alan Meyer
BZCOMMENT::2

It turns out that there is a little twist to this.

The levels of evidence are stored in two different places. One
place is the coversheet generating program. The other is in the
database itself. The two are almost identical. The only
difference I saw was in item IV, which looks as follows:

Coversheet:

"Opinions of respected authority/authorities based on clinical
experience, report of an expert committee, consensus
statement, or authoritative review."

Database:

"Opinions of respected authority(s), report of an expert
committee, consensus statement, or authoritative review."

I think the difference in usage between these two is that the
coversheet is printed and sent out, but the response that is
recorded is going to just be a number that identifies one of the
four values in the database. If that's right, then the effect of
changing the database is that all of the old responses as well as
the new ones will appear as if they used the new wording.

That's probably okay and may indeed be exactly what we want. If
so, I'll change both places.

If that's not what we want then everything gets complicated. We
could live with separate coversheet and database values (which
we're doing now with item IV above.) Or I could modify the
software and the database to support old and new values based on
when the data was entered - a potentially risky and expensive
proposition that is probably not worth doing if we're going to
replace the system.

So, should I modify both places?

When I get the answer, I'll probably make the changes in the
development system only so that they can be tested before
promoting them to production.

There's also an implication for the new CiteMS and EBMS systems
if we need to support evolving levels of evidence values, which I
imagine that we do. I can think of two approaches to handling a
change:

1. Freeze existing records while adding new or modified levels
of evidence for future records.

That introduces ongoing complication into the system but
produces an accurate history of the responses.

2. Map old levels of evidence into new ones when we change so
that the entire database is consistent with respect to levels
of evidence.

That simplifies the software in many ways and makes the
entire database consistent at all times but may give a
misleading history of responses to a citation if the changes
in levels of evidence are very significant.

We don't need to solve that problem right now for this task, but
I'm including Cynthia, Bob and Robin H. on this Bugzilla task so
that they'll be aware of the issue.

BZDATETIME::2011-09-08 15:59:11
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::3

We definitely need to have a discussion about this! I am confused by a couple of things:

1. The changes that Robin asked me to make on her coversheet involved levels 2 and 3, not level 4. So now I am not sure what she is seeing on the coversheet relative to what is in the system.
2. I didn't realize that we were capturing the LOE from the coversheets in a database at all. I know we talked about that for the new system, but I thought we decided that was just going to be a text field.

So, for now, don't make any changes until we can sort this out.

BZDATETIME::2011-09-08 16:06:00
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

(In reply to comment #3)
> I know we talked about that for the new system, but I thought
> we decided that was just going to be a text field.

Right, and that's how it's implemented in the prototype. Each board has it's own document for LOE guidelines, and the reviewers enter free text in the LOE field.

BZDATETIME::2011-09-08 16:06:49
BZCOMMENTOR::Bob Kline
BZCOMMENT::5

(In reply to comment #4)
> Each board has it's own document ....

Sorry. Each board has its own document ....

BZDATETIME::2011-09-08 16:44:32
BZCOMMENTOR::Alan Meyer
BZCOMMENT::6

I discussed the issues with Margaret and showed her the screen
that's used to enter reviewer responses into the system. My
understanding of our discussion was as follows:

Although Bonnie may be recording responses in the system, the
responses aren't actually used for anything.

The new system won't be controlling these values at all. The
data will be text strings.

I should go ahead and implement the changes in the coversheet
and not modify the database.

I'll do that now in the test version of the Citation Management
System.

BZDATETIME::2011-09-08 17:07:52
BZCOMMENTOR::Alan Meyer
BZCOMMENT::7

I installed the change in the test system. I'm hoping I made the change in the right place, but I don't know how to test it. So I'll ask someone else to do that.

To get to the test system go to:

http://citems-dev.nci.nih.gov/Logon.asp

Logon with your regular username and use your regular password with "test" in front. For example, if regular your username="JohnDoe" and your regular password is "abcXYZ", login with:

Username: JohnDoe
Password: testabcXYZ

Let me know about any problems.

BZDATETIME::2011-09-08 17:09:18
BZCOMMENTOR::Alan Meyer
BZCOMMENT::8

(In reply to comment #7)

> ... if regular your username="JohnDoe" ...

should, of course, have been

... if your regular username="JohnDoe" ...

BZDATETIME::2011-09-29 10:45:16
BZCOMMENTOR::Alan Meyer
BZCOMMENT::9

(In reply to comment #7)
> I installed the change in the test system.
...
> Let me know about any problems.

There's nothing recorded in Bugzilla since I made the changes in the test system on September 8.

Has anyone checked this yet?

Should it be put into production?

BZDATETIME::2011-09-29 11:01:06
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::10

When I try to log in using the link and the user name and password you supplied I get a message that they are incorrect.

BZDATETIME::2011-10-04 11:47:35
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::11

Robin qc'd this and said it looks fine. Please promote. Thanks.

BZDATETIME::2011-10-04 17:06:36
BZCOMMENTOR::Alan Meyer
BZCOMMENT::12

I spotted a typo in the new coversheet where I wrote "Restrospective" instead of "Retrospective".

I fixed it and then installed the modified coversheet in development and production and committed the change to our version control archive.

I'm marking the issue resolved-fixed.

BZDATETIME::2011-10-06 12:27:55
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::13

Closing issue.

BZDATETIME::2011-10-06 12:28:14
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::14

Whoops, forgot to check Closed!