CDR Tickets

BZDATETIME::2011-09-01 12:21:28
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::1

Notes from email summarizing meeting with Bryan and Bob:

Mobile pretty url
• We will add an element for a mobile pretty url in the metadata section of the summaries (where the regular pretty url is).

• Lisa will review the site map in Percussion and will give us a spreadsheet with urls to populate the element in the CDR.

BZDATETIME::2011-09-06 09:47:51
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

Element added to metadata block on Mahler; ready for user testing.

BZDATETIME::2011-09-14 15:34:13
BZCOMMENTOR::Bob Kline
BZCOMMENT::3

It wasn't part of the original specs, but I made the new element optional to avoid problems on Bach while we wait for the global to populate the element (which Margaret subsequently said wouldn't be added to all of the documents, so it needed to be optional anyway).

BZDATETIME::2011-11-23 16:00:22
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

I have the partial URLs from the cancer.gov team. What should go in the front of the url? "http://cancer.gov"? "http://m.cancer.gov"? Something else.

BZDATETIME::2011-11-23 17:07:28
BZCOMMENTOR::Bob Kline
BZCOMMENT::5

(In reply to comment #4)
> I have the partial URLs from the cancer.gov team. What should go in the front
> of the url? "http://cancer.gov"? "http://m.cancer.gov"? Something else.

Bryan said to use the version with "m." in front of "cancer.gov"; here are the results of a test run on Mahler:

http://mahler.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2011-11-23_16-42-01

Ready for user review. I didn't get the display strings from them, so I cloned the text content of the SummaryURL elements.

BZDATETIME::2011-12-14 12:47:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

Blair is asking for test data including the MobileURL element.
Is there already something on MAHLER that I can give him?

BZDATETIME::2011-12-14 14:03:28
BZCOMMENTOR::Bob Kline
BZCOMMENT::7

(In reply to comment #6)
> Blair is asking for test data including the MobileURL element.
> Is there already something on MAHLER that I can give him?

Not yet. I posted the results of the test-mode run for the users to review. As soon as that's done I can run it in live mode.

BZDATETIME::2011-12-20 09:15:27
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::8

I looked at the test run and it looked good. I only had one question, and that was on the very first entry. It showed two mobile urls for some reason, and the first one is not correct (it looks like the regular pretty url). Otherwise, ready to run on Mahler in live mode, and send the data to cancer.gov. Sorry it took me so long to get to this.

<MobileURL cdr:xref="http://m.cancer.gov/cancertopics/pdq/treatment/vulvar/Patient">
? ---— ----
+ <MobileURL cdr:xref="http://m.cancer.gov/topics/treatment/bycancer/vulvar/Patient">
? +++++++++

• Vulvar Cancer (PDQ®): Treatment - Mobile
  ? ---------
  + Vulvar Cancer (PDQ®): Treatment

BZDATETIME::2011-12-20 14:07:13
BZCOMMENTOR::Bob Kline
BZCOMMENT::9

(In reply to comment #8)
> I looked at the test run and it looked good. I only had one question, and that
> was on the very first entry. It showed two mobile urls for some reason, and
> the first one is not correct (it looks like the regular pretty url).
> Otherwise, ready to run on Mahler in live mode, and send the data to
> cancer.gov. Sorry it took me so long to get to this.
>
>
>
> <MobileURL
> cdr:xref="http://m.cancer.gov/cancertopics/pdq/treatment/vulvar/Patient">
> ? ---— ----
> + <MobileURL
> cdr:xref="http://m.cancer.gov/topics/treatment/bycancer/vulvar/Patient">
> ? +++++++++
> - Vulvar Cancer (PDQ®): Treatment - Mobile
> ? ---------
> + Vulvar Cancer (PDQ®): Treatment

I guess Volker had probably edited that document by hand. I could modify the software to skip over documents which already had the element, but it might be safer if you just take the element back out of that document, Volker. What do you think?

BZDATETIME::2011-12-20 15:28:59
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

(In reply to comment #9)
> I guess Volker had probably edited that document by hand.

That is very likely. I've modified at least one of the summaries for testing.

BZDATETIME::2011-12-22 09:25:06
BZCOMMENTOR::Bob Kline
BZCOMMENT::11

(In reply to comment #9)

> I guess Volker had probably edited that document by hand. I could modify the
> software to skip over documents which already had the element, but it might be
> safer if you just take the element back out of that document, Volker. What do
> you think?

(In reply to comment #10)

> That is very likely. I've modified at least one of the summaries for testing.

Still not clear what I should do. Will you be backing out the edits you made, or do I need to modify the program to handle cases where the element is already present?

BZDATETIME::2011-12-22 09:40:38
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

(In reply to comment #11)
> Still not clear what I should do. Will you be backing out the edits you made

We are talking about MAHLER here, right?
I didn't plan on reverting the edits but if could if you need me to. What's the problem with acknowledging that not everything will look exactly as it would on BACH since we're dealing with test data on MAHLER and continue as is?

BZDATETIME::2011-12-22 09:48:47
BZCOMMENTOR::Bob Kline
BZCOMMENT::13

Works for me, if you're confident that Blair or Bryan won't hit you with questions about why the URLs in the test documents you're giving them don't match what they gave me in the spreadsheet.

BZDATETIME::2011-12-22 10:44:05
BZCOMMENTOR::Bob Kline
BZCOMMENT::14

(In reply to comment #13)
> Works for me, if you're confident that Blair or Bryan won't hit you with
> questions about why the URLs in the test documents you're giving them don't
> match what they gave me in the spreadsheet.

Bryan said that we do need to make sure the values match what was in the spreadsheet. However, as it turns out, I had already written the software to handle this case, replacing an existing element if I found one. What Margaret thought she saw wasn't actually in the modified document as she reported it (the diff output had two elements, but that was because it was showing the change between the document before modification and after modification. The actual "new" version of the document only had one instance of the element, matching what was in the spreadsheet. I have run the job in live mode on Mahler, so you should be able to provide them with test pub data. You might want to spot-check the published output to make sure it looks right.

BZDATETIME::2012-01-13 13:38:57
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

Blair was wondering why the MobileURLs all ended in 'Patient'? He was under the impression that we wouldn't publish HP summaries to go to the mobile site and therefore the 'Patient' wasn't necessary.

Just wanted to mention this here in case we would want to make a change before going live.

BZDATETIME::2012-01-13 13:50:58
BZCOMMENTOR::Bob Kline
BZCOMMENT::16

(In reply to comment #15)

> Blair was wondering why the MobileURLs all ended in 'Patient'? He was under
> the impression that we wouldn't publish HP summaries to go to the mobile site
> and therefore the 'Patient' wasn't necessary.

I used the URLs they gave me. I can replace them if they want to give me a new set, but let's make sure they're all agreed on what they'll be so we don't end up in an endless flip-flop.

BZDATETIME::2012-01-13 13:56:54
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::17

I suspect they want to differentiate between the HP and Patient in case they do use the PDQ HP sums in the future. But we should check with Lisa/Bryan--those are the urls they told us to use.

BZDATETIME::2012-01-27 11:46:17
BZCOMMENTOR::Bob Kline
BZCOMMENT::18

I want to confirm what I will be doing tonight to get the mobile support into production. Here's my understanding of the sequence of events:

(1) Volker runs the weekly publishing job with old data & filters
(2) Volker calls me to let me know the publishing job is finished
(3) I promote the CdrCommonBase and SummaryCommon schema changes
(4) Volker installs the new publishing filters
(5) I run the global change to add the new MobileURL elements
(6) I call Volker to let him know the global change job is finished
(7) Volker runs a hot-fix for the patient treatment summaries
(8) Volker lets the CG team know the hot-fix is done
(9) They take it from there

Step (4) can actually happen concurrently with steps (3) and (5). The filters to be promoted in step (4) are identified elsewhere.

The schemas promoted in step (3) will add:

• IncludedDevices attribute

• ExcludedDevices attribute

• TableNumber element

• FigureNumber element

• ReferencedTableNumber element

• ReferencedFigureNumber element

• PermaTargTitle attribute

• PermaTargId attribute

• PermaTargUrl attribute

All of these new attributes and elements are optional, so their addition to the schema should be benign, as long as the ones for table/figure numbering and deep linking aren't actually used. According to my understanding of this weekend's release event, I wouldn't technically need to promote any schemas tonight, because the optional MobileURL element, which is the only new element which has to be in place for me to run the global change in step (5), has already been installed on Bach, and the only IncludedDevices and ExcludedDevices elements to be used for the release rollout are the ones Volker's filters will inject according to the business rules he has been given. However, since the 6.4 release means users are supposed to have the ability to manually add those elements to Summaries, my take is that I should promote the schemas tonight.

We expect the phone call in step (2) to happen some time between 9 and 10 this evening, but I will have my cell phone and the other necessary equipment with me at all times in order to take care of steps (3), (5), and (6). I anticipate the call in step (6) to be less than an hour later than the call in step (2). My cell phone is 703.244.8081.

Please read over the above description carefully and let me know if anything is wrong. I will not do anything unless at least Volker confirms that my understanding of what should be done is correct.

BZDATETIME::2012-01-27 11:51:15
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::19

Bob, this looks correct to me based on what Volker told me, but Volker will really need to verify. The only possible correction is the addition of the Include/Exclude device attributes since there are a couple of places in the content where we will add those manually. But that mayn not need to be done until before the content is released on or about Feb. 10.

BZDATETIME::2012-01-27 12:55:28
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

(In reply to comment #18)
> Please read over the above description carefully and let me know if anything
> is wrong. I will not do anything unless at least Volker confirms that my
> understanding of what should be done is correct.

Yes, this is exactly what is planned but I would change 'phone call' with 'email or phone call' since the boys are typically going to bed around that time and it's easier to keep Blair, Bryan, and Nick in the loop by sending emails.

BZDATETIME::2012-01-27 13:00:00
BZCOMMENTOR::Bob Kline
BZCOMMENT::21

(In reply to comment #20)

> ... I would change 'phone call' with 'email or phone call' ....

OK.

BZDATETIME::2012-01-27 16:09:51
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22

Just a short note:
The SummaryModuleLink is a new element as well but it appears that it's already available on BACH.

BZDATETIME::2012-01-27 21:29:42
BZCOMMENTOR::Bob Kline
BZCOMMENT::23

The filters have been promoted and the global change to populate the new MobileURL elements has completed successfully.

BZDATETIME::2012-01-27 21:30:41
BZCOMMENTOR::Bob Kline
BZCOMMENT::24

BTW, I backed up the schemas in case something goes horribly wrong and we have to roll back.

BZDATETIME::2012-01-30 11:54:08
BZCOMMENTOR::Bob Kline
BZCOMMENT::25

(In reply to comment #23)
> The filters have been promoted and the global change to populate the new
> MobileURL elements has completed successfully.

I meant to write "The schemas have been promoted ...."

BZDATETIME::2012-02-16 11:58:16
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::26

Closing issue since mobile site launched without any issues.