CDR Tickets

BZDATETIME::2011-06-02 09:22:18
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

Why do I get the feeling that this request is coming from Diana? My wife said Diana surely must be German. :-)

BZDATETIME::2011-06-03 10:40:06
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

As usual, I will have to decide if this change can be implemented using CSS.

If the patient reports are being printed from the browser we'll be able to use CSS. However, if the reports are being printed after they have been converted to MS-Word CSS won't be an option.

Are these reports that are being converted to Word?

BZDATETIME::2011-06-16 12:37:45
BZCOMMENTOR::Robin Juthe
BZCOMMENT::3

(In reply to comment #2)
> Are these reports that are being converted to Word?

I think I answered this is last week's meeting, but just so it's in the issue...

Yes, these are converted to Word.

BZDATETIME::2011-06-17 16:16:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

Just wondering: Are we going to include a replacement for these two items similarly to what we're doing with the images or are we dropping these without a hint of the existing KeyPoint table/To Learn More section?

BZDATETIME::2011-06-17 17:55:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

I've made the changes to the options page on MAHLER. The program modified is
QcReport.py

BZDATETIME::2011-06-21 09:14:04
BZCOMMENTOR::Robin Juthe
BZCOMMENT::6

(In reply to comment #4)
> Just wondering: Are we going to include a replacement for these two items
> similarly to what we're doing with the images or are we dropping these without
> a hint of the existing KeyPoint table/To Learn More section?

Yes, we would like a replacement for these items similar to images (or reference lists in HP summaries) but we would like to keep it very "modest" since the purpose of suppressing these items is to be "green". Maybe something like:

Note: Key Point box display suppressed

Note: To Learn More section display suppressed

BZDATETIME::2011-08-02 11:05:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

I've finished the changes for these two 'GoGreen' options.
a) Key Point boxes
The Key Point boxes are now suppressed by default and the display needs to
be turned on. The boxes have been replaced with a single row of text:
Key Point box display suppressed
The background is the same as for the KeyPoint boxes.

b) To Learn More section
The TLM section is now suppressed by default and the display needs to be
turned on. The section is replaced with a single row of text:
To Learn More section display suppressed
The background for the box is grey.
Caveat:
The To Learn More section is coming from the CDR document and I don't have
control over it. Therefore, the identifier to suppress this SummarySection
is a title beginning with "To Learn More About". Any other SummarySection
starting with such a title will be suppressed as well!

c) Bonus Item: Image Display
I'm realizing that we're trying to save empty space and trees. I therefore
modified the image placeholder a little to remove the blank lines above and
below the text for the image placeholders and have these display similarly
to the KeyPoint placeholder boxes.

Question:
These two options have been added to a new group for options called "Go Green Options". I am thinking we should move the two existing options
Display images instead of placeholder
and
Display the HP Reference Section
to this Go Green section as well.
Do you agree or should we keep those options where they are?

The following filters have been updated:
CDR434822 - QC Filter Templates - Summary
CDR380958 - Module: STYLE QC Summary
CDR339576 - Module: InLine Markup Formatter

This is ready for review on MAHLER.

BZDATETIME::2011-08-02 17:12:37
BZCOMMENTOR::Robin Juthe
BZCOMMENT::8

(In reply to comment #7)
> This is ready for review on MAHLER.

A bonus, even?! This looks good. I agree with moving the display images option to the GoGreen menu, but let's keep the display reference list option where it is for now. I'm actually wondering why need that option at all on the patient QC reports--I will check with Diana.

I have a couple picky requests:

1. Could the background color of the "To Learn more display suppressed" line be something other than gray? It looks like a comment and the black text on gray background is a little harder to read (especially when printed). Something lighter would be preferable.

2. The image placeholder is now a bit TOO squished I think. See CDR 62884 (Merkel cell HP). The placeholder line for the image hugs the text that immediately precedes it. Could we add one line of white space?

Thanks!

BZDATETIME::2011-08-02 18:16:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

(In reply to comment #8)
> 1. Could the background color of the "To Learn more display suppressed"
> line be something other than gray?

Anything you like - I'm completely flexible when it comes to colors.
Feel free to suggest anything that looks good. For now I've changed it to a lighter gray.

> 2. The image placeholder is now a bit TOO squished I think.

Oh no! We don't want to squish anybody. I've added about half a line (5 pixels) of space around the placeholder. Let me know if this is enough space or if I should add more.
Did you really mean you wanted "white" space above and below or is blue space acceptable, too?

BZDATETIME::2011-08-10 16:28:39
BZCOMMENTOR::Robin Juthe
BZCOMMENT::10

(In reply to comment #9)
> (In reply to comment #8)
> Anything you like - I'm completely flexible when it comes to colors.
> Feel free to suggest anything that looks good. For now I've changed it to a
> lighter gray.

How about a light pink? (so it stands apart from comments but is still easy to read)

> Oh no! We don't want to squish anybody. I've added about half a line (5
> pixels) of space around the placeholder. Let me know if this is enough space
> or if I should add more.
> Did you really mean you wanted "white" space above and below or is blue space
> acceptable, too?

I really meant a line of white space here (outside the placeholder). I think it would make it easier to separate the summary text from the image and caption if they are set apart a bit. We can live with it as is though if this is more difficult to program.

BZDATETIME::2011-08-10 18:27:14
BZCOMMENTOR::Volker Englisch
BZCOMMENT::11

(In reply to comment #10)
> How about a light pink?

Done.

> I really meant a line of white space here (outside the placeholder).

Done.

I was also able to correct the color/weight/etc. when converting to MS-Word. It was related to that Word bug that doesn't recognize CSS definitions of
*.classname
and expects it as
.classname

Please take another look.

BZDATETIME::2011-08-10 22:57:45
BZCOMMENTOR::Robin Juthe
BZCOMMENT::12

(In reply to comment #11)
> Please take another look.

Looks great! Verified on Mahler. Please promote to Bach.

BZDATETIME::2011-08-11 11:14:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

The following program and filters have been copied to FRANCK and BACH:
QcReports.py - 10176

CDR434822 - R10177: QC Filter Templates - Summary
CDR380958 - R10177: Module: STYLE QC Summary
CDR339576 - R10177: Module: InLine Markup Formatter

Please verify on BACH, close this bug and save some trees.

BZDATETIME::2011-08-11 11:46:45
BZCOMMENTOR::Robin Juthe
BZCOMMENT::14

(In reply to comment #13)
> The following program and filters have been copied to FRANCK and BACH:
> QcReports.py - 10176
> CDR434822 - R10177: QC Filter Templates - Summary
> CDR380958 - R10177: Module: STYLE QC Summary
> CDR339576 - R10177: Module: InLine Markup Formatter
> Please verify on BACH, close this bug and save some trees.

Verified on BACH. Thanks! Closing issue.

BZDATETIME::2011-09-01 16:35:22
BZCOMMENTOR::Robin Juthe
BZCOMMENT::15

I'm re-opening this issue in order to do two things:

1. We'd like to change to default options such that the images, key point boxes, and to learn more sections are displayed by default.

2. We'd like to change the wording of the Go Green options such that the actions taken (by checking the boxes) are "green" rather than the opposite. The options should read:

Go Green Options

• Replace images with placeholders.

• Replace key point boxes with placeholders.

• Replace to learn more sections with placeholders.

BZDATETIME::2011-09-02 11:08:41
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

(In reply to comment #15)
> I'm re-opening this issue in order to do two things:

You said "two" things but I have the feeling you really meant "three" things:
1. Change Default
Done. Everything is displayed by default

2. Change wording of GoGreen options.
Done.

3. Add an option to check/uncheck all GoGreen options together.
Done.

This is ready for review on MAHLER.

BZDATETIME::2011-09-02 14:25:29
BZCOMMENTOR::Robin Juthe
BZCOMMENT::17

(In reply to comment #16)
> (In reply to comment #15)
> > I'm re-opening this issue in order to do two things:
> You said "two" things but I have the feeling you really meant "three" things:
> 1. Change Default
> Done. Everything is displayed by default
> 2. Change wording of GoGreen options.
> Done.
> 3. Add an option to check/uncheck all GoGreen options together.
> Done.
> This is ready for review on MAHLER.

Sure, we'll take the third option! But, could we only have that option for select all on the patient QC report interfaces? It doesn't really add anything to the HP form since there's only one "go green" option.

BZDATETIME::2011-09-06 10:30:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18

(In reply to comment #17)
> But, could we only have that option for select all on the patient QC
> report interfaces?

I pretty much knew you would ask this but I thought there may be a chance we're adding another option. :-)

I've removed the "Check All" for the HP summaries. Please check it out on MAHLER.

BZDATETIME::2011-09-06 11:41:46
BZCOMMENTOR::Robin Juthe
BZCOMMENT::19

(In reply to comment #18)
> I've removed the "Check All" for the HP summaries. Please check it out on
> MAHLER.

Verified on Mahler. Please promote these changes to Bach.

Thanks!

BZDATETIME::2011-09-06 15:54:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

The following program has been copied to FRANCK and BACH
QcReports.py - 10194

Please verify on BACH and close this bug.

BZDATETIME::2011-09-07 13:31:15
BZCOMMENTOR::Robin Juthe
BZCOMMENT::21

(In reply to comment #20)
> The following program has been copied to FRANCK and BACH
> QcReports.py - 10194
> Please verify on BACH and close this bug.

Verified on Bach. Closing this issue.