CDR Tickets

Issue Number 3368
Summary [Summaries] Board Membership and Invitation History Report
Created 2011-05-19 12:06:11
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-10-03 14:00:15
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107696
Description

BZISSUE::5061
BZDATETIME::2011-05-19 12:06:11
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

We would like a new HTML report to help us track who we’ve invited to the Boards in the past, what their current (and past) membership statuses are, and reasons why they left PDQ. This information will be helpful in discussions about inviting new members.

The attached document has some specifications for how the report could be run and a sample of the output.

Comment entered 2011-05-19 12:06:53 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-05-19 12:06:53
BZCOMMENTOR::Robin Juthe
BZCOMMENT::1

Comment entered 2011-05-19 12:06:53 by Juthe, Robin (NIH/NCI) [E]

Attachment Board Membership and Invitation History Report.docx has been added with description: Specifications and Sample Report

Comment entered 2011-05-26 15:24:37 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-05-26 15:24:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

Do we want to create an HTML report or an Excel report?

Comment entered 2011-05-31 12:28:21 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-05-31 12:28:21
BZCOMMENTOR::Robin Juthe
BZCOMMENT::3

(In reply to comment #2)
> Do we want to create an HTML report or an Excel report?

HTML, please. Thanks.

Comment entered 2011-06-20 16:27:11 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-06-20 16:27:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

In the specs you are writing:
Could select a particular Board to run a Board-specific report or
ALL BOARDS since some members are on/have been invited to multiple Boards

Does the "... a particular Board ..." also include "multiple boards" or would it be only one board or all?

The board name is listed a one of the mandatory columns. Is this true even for a single board?

Comment entered 2011-06-20 16:33:41 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-06-20 16:33:41
BZCOMMENTOR::Robin Juthe
BZCOMMENT::5

(In reply to comment #4)
> In the specs you are writing:
> Could select a particular Board to run a Board-specific report or
> ALL BOARDS since some members are on/have been invited to multiple Boards
> Does the "... a particular Board ..." also include "multiple boards" or would
> it be only one board or all?
> The board name is listed a one of the mandatory columns. Is this true even for
> a single board?

Good questions!

1. Yes, we'd like to have the option to select one or more than one Board - not one or all as my specs implied.

2. Good point - the board name can be an optional column.

Thanks.

Comment entered 2011-06-24 12:58:32 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-06-24 12:58:32
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

I've completed the new report hopefully with all of the requirements specified.
BoardInvitationHistory.py

I've made one addition to the report, namely that the former board members are listed with a grey background.

When testing, please look at those persons who are members in multiple boards a little more closely.

This is ready for review on MAHLER.

Comment entered 2011-07-21 08:51:09 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-07-21 08:51:09
BZCOMMENTOR::Robin Juthe
BZCOMMENT::7

(In reply to comment #6)
> This is ready for review on MAHLER.

I've noticed a couple issues in reviewing this report so far.

1. Current membership. I'm seeing some members who are current Ed Board members being treated as former members, and former members being treated as current. It seems like the report might be looking for ANY current member=Yes category (Ed or Adv Board), though these should be considered separately.

-Example: CDR369806 - Marianne Berwick. She is a current Adv. Board member and a former Ed Board member. This information appears to be flipped in the report (she's showing as a former Adv Bd member and a current Ed Board member)

2. For many of the optional fields, the values in the report columns say "None". In many cases, this is because the element is not populated in the CDR record, but this isn't always the case. See CDR468943 - Susan Domchek as an example. She has areas of expertise, and invitation date, a response to invitation value, and a term start date, but each of these columns show up as "None" in the report. Other Board members have this information populated, though. I haven't figured out the pattern yet...

3. I got a python error when I tried running it for all boards.

Comment entered 2011-07-22 13:35:46 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-22 13:35:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

I've made some additional changes to correct the problems. Please take a look again on MAHLER.

Comment entered 2011-08-11 17:46:14 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-08-11 17:46:14
BZCOMMENTOR::Robin Juthe
BZCOMMENT::9

(In reply to comment #8)
> I've made some additional changes to correct the problems. Please take a look
> again on MAHLER.

I'm still reviewing these but I have a couple requests and 1 error.

1. Could you remove the gray shading for former members? I'm actually finding that confusing, esp. if I run the report for more than one Board and the person could be a former member of either one. Maybe it's something we could add as an option in the display later on.

2. Selecting the term end date brings up a column with the termination reason, rather than the term end date. Could you please check on this?

3. It actually wouldn't hurt to add the termination reason as another option on the interface though--see the ideas you're giving me?

4. Some of the Board member information is still not being pulled in correctly. See CDR369811, for example. Her record has an invitation date, response to invitation, and current membership of Yes, but each of these columns are filled with "None" in the report. CDR 369920 is another example.

Comment entered 2011-08-11 18:21:05 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-11 18:21:05
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

(In reply to comment #9)
> 1. Could you remove the gray shading for former members?

Done.

> 2. Selecting the term end date brings up a column with the termination reason,
> 3. It actually wouldn't hurt to add the termination reason

Actually, you had the termination reason included in your markup document and I have it included in the program but commented out. That's the reason why you're seeing the termination reason where the date should be.
I'll add the date and reason back in if you like if that's the last word (for now). :-)

> 4. Some of the Board member information is still not being pulled in
> correctly.

This is true for all Board members for which there doesn't exist the mandatory GovernmentEmployee element. As soon as that element is added to the record the information displays correctly.

Comment entered 2011-08-12 09:55:27 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-08-12 09:55:27
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11

(In reply to comment #10)
> I'll add the date and reason back in if you like if that's the last word (for
> now). :-)

Yes, please include both the term end date and the termination reason. Thanks!

> > 4. Some of the Board member information is still not being pulled in
> > correctly.
> This is true for all Board members for which there doesn't exist the mandatory
> GovernmentEmployee element. As soon as that element is added to the record the
> information displays correctly.

Would it be possible to get a list of all board member documents that do not have a govt employee element? We will probably want to add that element in (even with just a value of "unknown") in order for this report to be useful.

Comment entered 2011-08-12 12:30:46 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-12 12:30:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

I've added the Termination Reason back in and I've created the report indicating board members without the GovernmentEmployee element.

Comment entered 2011-08-12 12:31:44 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-12 12:31:44
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

Comment entered 2011-08-12 12:31:44 by Englisch, Volker (NIH/NCI) [C]

Attachment BoardMember_GEmissing.xls has been added with description: Board Members without GovernmentEmployee Element

Comment entered 2011-08-29 16:05:59 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-29 16:05:59
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14

This issue is waiting for the global in OCECDR-3408 to be completed.

Comment entered 2011-09-08 17:44:00 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-08 17:44:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

(In reply to comment #10)
> > 4. Some of the Board member information is still not being pulled in
> > correctly.
>
> This is true for all Board members for which there doesn't exist the mandatory
> GovernmentEmployee element. As soon as that element is added to the record the
> information displays correctly.

I wanted to mention that the rows for the persons for which many data fields where not displayed due to the missing GovernmentEmployee element are now populated correctly after the GlobalChange job ran on MAHLER under OCECDR-3408.

Comment entered 2011-09-22 11:53:17 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-22 11:53:17
BZCOMMENTOR::Robin Juthe
BZCOMMENT::16

(In reply to comment #15)
> (In reply to comment #10)
> > > 4. Some of the Board member information is still not being pulled in
> > > correctly.
> >
> > This is true for all Board members for which there doesn't exist the mandatory
> > GovernmentEmployee element. As soon as that element is added to the record the
> > information displays correctly.
> I wanted to mention that the rows for the persons for which many data fields
> where not displayed due to the missing GovernmentEmployee element are now
> populated correctly after the GlobalChange job ran on MAHLER under OCECDR-3408.

This looks great on Mahler. I verified that these individuals are displaying and the report seems to be working as it should.

I noticed one cosmetic issue. The area of expertise column does not have the cells outlined as in other columns. So there's a bunch of blank space if several person's areas of expertise are not populated in his/her records.

Due to the dependency of this issue on OCECDR-3408 we will hold on promoting it to Bach until that global has been run on Bach.

Comment entered 2011-09-23 13:59:17 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-23 13:59:17
BZCOMMENTOR::Volker Englisch
BZCOMMENT::17

(In reply to comment #16)
> The area of expertise column does not have the cells outlined as in other
> columns. So there's a bunch of blank space

As mentioned earlier, this "white space" is an IE special. All other browsers do display the cells along with cell borders. I've included added our special trick for the AreaOfExpertise column that we're already using for the Blank column.

The report has been versioned in SVN
BoardInvitationHistory.py - R10206

Comment entered 2011-09-29 11:13:44 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-29 11:13:44
BZCOMMENTOR::Robin Juthe
BZCOMMENT::18

(In reply to comment #17)
> (In reply to comment #16)
> > The area of expertise column does not have the cells outlined as in other
> > columns. So there's a bunch of blank space
> As mentioned earlier, this "white space" is an IE special. All other browsers
> do display the cells along with cell borders. I've included added our special
> trick for the AreaOfExpertise column that we're already using for the Blank
> column.
> The report has been versioned in SVN
> BoardInvitationHistory.py - R10206

Nice trick - the lines in the Area of Exptertise column look good.

Comment entered 2011-09-29 16:28:25 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-29 16:28:25
BZCOMMENTOR::Volker Englisch
BZCOMMENT::19

(In reply to comment #16)
> Due to the dependency of this issue on OCECDR-3408 we will hold on promoting it
> to Bach until that global has been run on Bach.

Since the Global now ran on BACH I've copied this report to FRANCK and BACH.

Please verify on BACH and close this bug.

Comment entered 2011-09-29 16:45:45 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-29 16:45:45
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

I forgot that I also needed to copy the script that creates the menus:
BoardManagers.py - R10213

Comment entered 2011-10-03 14:00:15 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-10-03 14:00:15
BZCOMMENTOR::Robin Juthe
BZCOMMENT::21

Verified on Bach. Looks great.

Closing issue!

Attachments
File Name Posted User
BoardMember_GEmissing.xls 2011-08-12 12:31:44 Englisch, Volker (NIH/NCI) [C]
Board Membership and Invitation History Report.docx 2011-05-19 12:06:53

Elapsed: 0:00:00.001220