CDR Tickets

BZDATETIME::2011-05-11 15:00:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I hope it's OK to drop the priority for these CTRP issues in order to move them to the bottom of my priority list. I'll move them up as soon as the work on these issues needs to resume.

BZDATETIME::2011-09-15 16:24:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

As discussed at the status meeting it is time to awake these CTRP issues from their beauty sleep and bring them back.
Changing priority.

BZDATETIME::2011-09-23 12:27:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

My feeling from yesterday's CDR status meeting was that it's OK to put these CTRP issues back in the box.
I'm lowering the priority for now.

BZDATETIME::2011-10-13 12:28:52
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::4

Changed issue title.

BZDATETIME::2011-11-02 09:56:22
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::5

Upped priority.

BZDATETIME::2011-11-17 16:22:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

As mentioned at our meeting I have modified the CTGov QC report on MAHLER. I selected one of the documents with CTRPInfo on FRANCK and copied it to MAHLER.

I pretty much left everything similar to the display of the location elements, so if you'd like different labels for the Address/Status/etc. please let me know.

The following filters have been updated:
CDR346703 - CTGovProtocol QC Report
CDR349687 - Denormalization Filter: CTGovProtocol

This is ready for review on MAHLER. (with CDR573235 as a sample doc)

BZDATETIME::2011-12-16 12:35:34
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::7

(In reply to comment #6)
> This is ready for review on MAHLER. (with CDR573235 as a sample doc)

This looks good on Mahler. Please promote to Franck and Bach.

BZDATETIME::2011-12-16 14:23:21
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

The following filters have been updated on FRANCK:
CDR346703 - CTGovProtocol QC Report - R10271
CDR349687 - Denormalization Filter: CTGovProtocol - R10271

I wasn't aware that this should already be copied to BACH. If we want the changes on BACH I will need to run a test publishing job for the CTGovProtocols on FRANCK first since the denormalization filter does affect the QC reports as well as the vendor output.

BZDATETIME::2011-12-16 15:15:50
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

(In reply to comment #8)
> The following filters have been updated on FRANCK:
> CDR346703 - CTGovProtocol QC Report - R10271
> CDR349687 - Denormalization Filter: CTGovProtocol - R10271
>
> I wasn't aware that this should already be copied to BACH. If we want the
> changes on BACH I will need to run a test publishing job for the CTGovProtocols
> on FRANCK first since the denormalization filter does affect the QC reports as
> well as the vendor output.

The new Schema is not on Bach yet so this can wait until it the schema is promoted to Bach.

BZDATETIME::2012-03-15 10:32:04
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::10

The CTRPOverallOfficial block has been added to the schema. Please make appropriate changes to the QC report filters.

BZDATETIME::2012-03-26 17:48:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::11

I'm not sure how to display the information for the PDQPerson element and how that information relates to the GivenName, MiddleInitial, Surname data of the CTRPOverallOfficial block.

BZDATETIME::2012-03-27 16:25:46
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::12

(In reply to comment #11)
> I'm not sure how to display the information for the PDQPerson element and how
> that information relates to the GivenName, MiddleInitial, Surname data of the
> CTRPOverallOfficial block.

The PDQPerson element is a link to the CDR record of the info provided for the GivenName, MiddleInitial, Surname. The link is dropped in only when there is an existing CDR record for this person (GivenName, MiddleInitial, Surname) and there is already a mapping for this person in the CDR. If there is no existing record in the CDR or if no mapping has been done for the record, the only information that is provided are the GivenName, MiddleInitial, Surname and address info, if available. In that case, the PDQPerson element will be empty and we will need to first create or find the record for this person (GivenName, MiddleInitial, Surname), include the person in the appropriate mapping table and then link the person in the protocol record. I hope this helps?

BZDATETIME::2012-04-10 19:42:05
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

(In reply to comment #12)
> The PDQPerson element is a link to the CDR record of the info provided for the
> GivenName, MiddleInitial, Surname.

Which information do you need to see in the QC report - the information from the Person document or the information displayed in the CTRPInfo block?
Same question for the address information.

I'm assuming you want to see the information from the protocol document.

BZDATETIME::2012-04-11 12:58:29
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::14

(In reply to comment #13)
> (In reply to comment #12)
> > The PDQPerson element is a link to the CDR record of the info provided for the
> > GivenName, MiddleInitial, Surname.
>
> Which information do you need to see in the QC report - the information from
> the Person document or the information displayed in the CTRPInfo block?
> Same question for the address information.
>
> I'm assuming you want to see the information from the protocol document.

Yes. In all cases, show the information from the protocol document. However, when that is not available, show the information from the person record.

BZDATETIME::2012-04-13 19:31:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

I finished the QC report displaying all of the data contained within the document but I still need to include denormalized data from the Person document.
Hopefully I will be able to finish that part on Monday.

BZDATETIME::2012-04-16 14:50:51
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

I am still confused about what needs to be displayed for the person information.

You said that the PDQPerson element would not always be available but it is listed in the schema as a mandatory element. You also said that the information from the Person document should be displayed if no other name information was available but the Surname element is mandatory as well and you will always have this listed.
With both, the name information from the protocol and the link to the Person document would you want to display only the protocol information or both, the protocol info and in addition the information of the Person document?

I hope I didn't misunderstand what you had said in comment 12 and comment 14.

BZDATETIME::2012-04-17 13:14:09
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::17

What we want displayed in the QC report is the information that will go on cancer.gov which in this case, will be the information that is coming from the protocol record (instead of the PDQPerson element). Would it be simpler to always display the information in the protocol record and then display CDR ID of the PDQ Person (possibly with a link to the QC report of the person record?). Since we are now doing all the mapping work outside of the protocol document (using the mapping interface), it looks like in all cases, the PDQPerson element and the information in the protocol document should be available.

BZDATETIME::2012-04-17 14:25:21
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18

That's what I have done for the moment.

Why don't you take a look at what's ready and let me know what you would like me to change?
I have used the document CDR573235 on MAHLER as an example.

BZDATETIME::2012-04-17 14:41:02
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::19

(In reply to comment #18)
> That's what I have done for the moment.
>
> Why don't you take a look at what's ready and let me know what you would like
> me to change?
> I have used the document CDR573235 on MAHLER as an example.

It would probably be better to install this on Franck since that is where we have the ctrp data.

BZDATETIME::2012-04-17 15:04:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

I have no problems copying the changes to FRANCK but I would still prefer for you to first take a look at the QC report on MAHLER. If you can already identify a problem on MAHLER by looking at that single document which I prepared then it would save time for both of us.
However, if you feel strongly about looking on FRANCK I'll spend the extra time and move the filters.

BZDATETIME::2012-04-17 15:32:59
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::21

I have looked at the document on Mahler. The links don't stand out because they are of similar color to the background color. Can you change the links to a different color?

Apart from that everything seems to be okay.

BZDATETIME::2012-04-17 16:47:53
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22

(In reply to comment #21)
> Can you change the links to a different color?

It is possible to change the color but it would be better to think if this is the best solution. In order to change the color for the links you would need to decide many more questions such as

• Do we want to change the color for all links or just the links of the CTRP
  section; for all QC reports or just the CTGovProtocols?

• What should be the color for the link itself, the link when hovering over, a
  visited link?

It would be much simpler to adjust the background color instead and make it, for instance, lighter.

BZDATETIME::2012-04-17 17:44:35
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::23

(In reply to comment #22)
> (In reply to comment #21)
> > Can you change the links to a different color?

> It would be much simpler to adjust the background color instead and make it,
> for instance, lighter.

Actually, feel free to change the background color to a diffferent color that contrasts well with the links color. This shold not affect the background color in XMetal, right ?

BZDATETIME::2012-04-17 19:07:21
BZCOMMENTOR::Volker Englisch
BZCOMMENT::24

The two modified filters have been copied to FRANCK:
CDR349687: Denormalization Filter: CTGovProtocol - R10378
CDR346703: CTGovProtocol QC Report - R10378

This is ready for review on FRANCK

BZDATETIME::2012-04-26 10:13:00
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::25

(In reply to comment #24)
> The two modified filters have been copied to FRANCK:
> CDR349687: Denormalization Filter: CTGovProtocol - R10378
> CDR346703: CTGovProtocol QC Report - R10378
>
> This is ready for review on FRANCK

This looks good on Franck. Thank you!

BZDATETIME::2012-07-20 17:43:42
BZCOMMENTOR::Volker Englisch
BZCOMMENT::26

Would you like me to go ahead and copy the updated QC report to BACH, too?

BZDATETIME::2012-07-26 10:59:35
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::27

(In reply to comment #26)
> Would you like me to go ahead and copy the updated QC report to BACH, too?

Yes. Please do. We are no longer doing any tests on Frank.

BZDATETIME::2012-07-27 16:50:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::28

The two filters have been copied to BACH:
CDR349687: Denormalization Filter: CTGovProtocol - R10378
CDR346703: CTGovProtocol QC Report - R10378

This is ready for review on BACH.

BZDATETIME::2012-10-05 10:02:58
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::29

(In reply to comment #28)
> The two filters have been copied to BACH:
> CDR349687: Denormalization Filter: CTGovProtocol - R10378
> CDR346703: CTGovProtocol QC Report - R10378
>
> This is ready for review on BACH.

Verified on Bach. Issue closed. Thank you!