CDR Tickets

BZDATETIME::2010-10-22 11:03:16
BZCOMMENTOR::Robin Juthe
BZCOMMENT::1

Per the discussion in yesterday's status meeting, we will not be adding additional values to the existing "Audience" attribute. Instead, we will add two new attributes.

"Duration" with the option Permanent
"Source" with the option advisory-board

For any comment that is flagged as Permanent, the audience would by default be Internal.
For any comment that is flagged as advisory-board, the audience would by default be External.
(The default audience options could be manually changed on a case by case basis.)

This will give us more flexibility to add more options down the road (e.g., additional sources).

BZDATETIME::2010-10-22 11:04:06
BZCOMMENTOR::Robin Juthe
BZCOMMENT::2

I'm attaching a file with some examples of Permanent comments from the Genetics summaries. Most are instructional to CIAT.

Attachment Examples of Permanent Comments.doc has been added with description: Examples of Permanent Comments

BZDATETIME::2010-10-28 15:20:59
BZCOMMENTOR::Robin Juthe
BZCOMMENT::3

Changing title to [Summary]... for consistency purposes.

BZDATETIME::2010-10-29 18:01:48
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

Attributes installed on Mahler; ready for user testing.

BZDATETIME::2010-11-01 12:55:14
BZCOMMENTOR::Robin Juthe
BZCOMMENT::5

The attributes look fine on Mahler.

We had talked about having default audience values of Internal for Permanent comments and External for Advisory Board comments (comment 1). Since all comments are added as Internal by default first, is it not possible to change the comment to external when you add the source=advisory-board?

BZDATETIME::2010-11-01 13:07:05
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

(In reply to comment #5)
> The attributes look fine on Mahler.
>
> We had talked about having default audience values of Internal for Permanent
> comments and External for Advisory Board comments (comment 1). Since all
> comments are added as Internal by default first, is it not possible to change
> the comment to external when you add the source=advisory-board?

I can, if you want, create a macro which catches the event for a change of the source attribute and makes the parallel change to the audience attribute.

BZDATETIME::2010-11-01 13:14:20
BZCOMMENTOR::Robin Juthe
BZCOMMENT::7

I don't think this is really what we want since it would still have to be reviewed on a case-by-case basis so it wouldn't really save any time. It's probably easier just to select the appropriate audience as we go since we will already be in the attribute inspector adding the source anyway. Thank you though.

It's fine to promote these changes to Bach.

BZDATETIME::2010-11-01 14:39:22
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

(In reply to comment #7)
> I don't think this is really what we want since it would still have to be
> reviewed on a case-by-case basis so it wouldn't really save any time.

Was there something else you had in mind?

BZDATETIME::2010-11-05 11:10:40
BZCOMMENTOR::Bob Kline
BZCOMMENT::9

(In reply to comment #8)
> (In reply to comment #7)
> > I don't think this is really what we want since it would still have to be
> > reviewed on a case-by-case basis so it wouldn't really save any time.
>
> Was there something else you had in mind?

I'm holding off on promoting these until I'm confident there wasn't something else you were hoping we could do that hasn't been done.

BZDATETIME::2010-11-12 09:44:29
BZCOMMENTOR::Robin Juthe
BZCOMMENT::10

My thought was that when a user selected "Advisory-Board" from the Source picklist, that the audience would automatically become "External" (although this could be manually changed in the attribute inspector). And when a user selected Duration "Permanent", then the audience would automatically be "Internal" (again, it could be adjusted on a comment-by-comment basis). Would this be difficult to implement? It's not a necessity, just an idea for the sake of convenience.

BZDATETIME::2010-11-12 12:43:49
BZCOMMENTOR::Bob Kline
BZCOMMENT::11

(In reply to comment #10)
> My thought was that when a user selected "Advisory-Board" from the Source
> picklist, that the audience would automatically become "External" (although
> this could be manually changed in the attribute inspector). And when a user
> selected Duration "Permanent", then the audience would automatically be
> "Internal" (again, it could be adjusted on a comment-by-comment basis). Would
> this be difficult to implement? It's not a necessity, just an idea for the sake
> of convenience.

I think that's what I was offering to do in comment #6, but in the next comment you said that wasn't what you wanted. I'm confused. :-)

BZDATETIME::2010-11-12 12:47:30
BZCOMMENTOR::Robin Juthe
BZCOMMENT::12

Sorry! I guess I am too - I must have misunderstood what you were proposing. I thought a macro would be a way to apply that change to all comments in the document, not one by one, but that's probably not the case.. Let's talk about this in the next CDR meeting.

BZDATETIME::2010-11-18 16:30:25
BZCOMMENTOR::Bob Kline
BZCOMMENT::13

We agreed in the status meeting that what I was offering to do in comment #6 was desirable, but unfortunately I discovered on investigation that XMetaL does not expose the event we would need access to in order to implement the macro.

BZDATETIME::2010-11-19 09:27:33
BZCOMMENTOR::Robin Juthe
BZCOMMENT::14

Bummer. So, I took another look on Mahler and I think everything looks good as is. Please promote these changes to Bach.

I will put in separate issues for modifications to the QC reports.

BZDATETIME::2010-11-19 10:14:28
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

(In reply to comment #14)
> I will put in separate issues for modifications to the QC reports.

I can hardly wait. :-)

BZDATETIME::2010-11-22 10:41:46
BZCOMMENTOR::Bob Kline
BZCOMMENT::16

New attributes installed on Bach; please check (and close if OK).

BZDATETIME::2010-11-22 13:36:05
BZCOMMENTOR::Robin Juthe
BZCOMMENT::17

Verified attributes on BACH. Closing issue.