CDR Tickets

Attachment Drug Indications Report.doc has been added with description: Spec and sample for Drug Indications Report

BZDATETIME::2010-07-29 09:31:51
BZCOMMENTOR::Robin Juthe
BZCOMMENT::1

Assigned to Volker.

BZDATETIME::2010-07-29 10:56:16
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

I am guessing that the output format for this report should be HTML (not Excel), right?

BZDATETIME::2010-07-29 10:56:56
BZCOMMENTOR::Robin Juthe
BZCOMMENT::3

That's correct. Thanks.

BZDATETIME::2010-07-30 16:14:30
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

I have three of these reports nearly ready:
a) list of indications
b) report by indication (with and without brand name)

I will change the CSS to make them pretty once I have the other two report (report by drug name) completed.

BZDATETIME::2010-08-10 17:56:22
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

I have a question in regard to the report order by Drug Name.

When the user selects an indication (i.e. 'breast cancer') what should be displayed in the 'Indication' column:
a) All indications for that drug (one of which would be 'breast cancer' or
b) Only those indications that have been selected?

(I noticed that the above comment hadn't been submitted before my week out for training but I can't tell if this was all that I had to say. Let's just keep it here as is for now.)

BZDATETIME::2010-08-16 11:08:05
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

The report has been created and is ready for review on MAHLER.

BZDATETIME::2010-08-18 14:40:24
BZCOMMENTOR::Robin Juthe
BZCOMMENT::7

I reviewed the report on Mahler and I think it looks really good! I have a couple comments:

1. Now that we've added the option to select a drug name, I think we should make it clear on the user interface that the user should select EITHER a drug name OR an indication(s). To do so, I propose that we group the options related to selection by indication together, followed by an "OR", and then group the options related to selection by drug name. So, the first group would contain the Select Indication(s) picklist, the Select Display Type for Indication(s) options, and the Select Report Type options (except for Single Drug with Indication(s)). The second group would contain the Select Drug Name drop-down list and the Select Report Type option for a Single Drug with Indication(s) Report.

2. In the Single Drug with Indication(s) report, would it be possible to add the CDR ID of the drug information summary in parentheses following the Drug Name? This CDR ID should link to the QC report for the DIS, as in the other report types.

3. A couple of minor style things.

(a) I realized that in the original sample attachment I provided, I was inconsistent about the column heading for indications, such that in some cases the column is named "Indication" and in other cases it is named "Approved Indication". Could you please change those columns named "Indication" to "Approved Indication" for consistency? This will also match the name of the element.

(b) I noticed that the font size is different for in the text in the Indication column in two of the report types - Indications and Drug Names Only and Indications and Drug Names (with Brand Names). I prefer the larger font size (as is present in the other columns and in other views of this report).

I think that's it for me, but it will be good to have Diana and Deb take a look at this as well.

Thanks!

BZDATETIME::2010-08-19 17:03:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

(In reply to comment #7)
> 2. In the Single Drug with Indication(s) report, would it be possible to add
> the CDR ID

Done.

> 3. A couple of minor style things.
> (a) Could you please change those columns named "Indication" to
> "Approved Indication" for consistency?

Done.

> (b) I noticed that the font size is different for in the text

Fixed.

I'm still trying to make changes to the user interface (item [1.]) without having to rewrite too much of the existing program but I'll come up with something useful soon.

BZDATETIME::2010-08-19 17:10:23
BZCOMMENTOR::Robin Juthe
BZCOMMENT::9

Thanks, Volker. Before you make too many changes to the user interface, I wanted to let you know that I met with Deb and Diana this afternoon and they requested some changes to the interface and report (one of which is to remove the "search by drug name" and "single drug with indications" options). I will post all of their feedback from our meeting shortly.

BZDATETIME::2010-08-19 18:38:55
BZCOMMENTOR::Robin Juthe
BZCOMMENT::10

OK, here are some comments from my meeting with Diana and Deb this afternoon:

1. As I mentioned above, we do not need the "Search by Drug Name" or "Single Drug with Indication(s)" options. It was agreed that this function was secondary and could easily be pulled from the QC report for an individual drug. This also cuts down on the confusion on the user interface from having too many options.

2. Some changes are requested to the user interface. The preferred sequence is basically flipped from how it reads currently. The order should be (1) "Select Report Type", (2) "Select Display Type", and (3) "Select Indication(s)".

3. In the "Display Indications for Each Drug" display option, they felt the data would be easier to use (as when copying/pasting into Word) if it were in a list, rather than in a table, and if all bullets were removed. The suggested display is to have an indication followed by indented drug names, as below.

breast cancer
trastuzumab (CDRXXXXX)
raloxifene hydrochloride (CDRXXXXX)
cervical cancer
topotecan hydrochloride (CDRXXXX)

4. For both the "Indications and Drug Names Only" and "Indications and Drug Names with Brand Name(s)" report types, bullets are not needed within the table as previously requested. Please also remove the bullets from the list of all indications.

5. In the "Display Indications for Each Drug" display, please alphabetize the results by drug name (second column).

6. The option to "Display Drugs for Each Indication" WITH the report type "Indicaitons and Drugs With Brand Names" is not needed. It was decided that this information wasn't very useful since the drug names (and, in turn, Brand names) might be repeated several times in the report if it had multiple indications. They would like to have a separate report to show all drug names with all Brand names (without indication). I will open a separate issue for that report since I don't think it should fall under the Indications Report and, as Volker mentioned, it will be faster to run it as a separate report.

**Question for Deb/Diana – do you still want to be able to view the Brand names in parentheses for the "Display Indications for Each Drug" report type?** (I don't think it would hurt to keep that option.)

7. Another thing I just noticed. It looks like only 2 drug names are showing up for each indication, even when there are more than 2. For example, "breast cancer" and "multiple myeloma and other plasma neoplasms" each have 3 drugs with this indication, but only 2 are visible when you run the "Display drugs for each Indication" report.

BZDATETIME::2010-08-23 10:10:41
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11

(In reply to comment #10)

> ****Question for Deb/Diana – do you still want to be able to view the Brand
> names in parentheses for the "Display Indications for Each Drug" report
> type?**** (I don't think it would hurt to keep that option.)

Diana and Deb would like to keep the option to show Brand names for this report.

BZDATETIME::2010-08-23 15:06:17
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

(In reply to comment #10)
> 1. As I mentioned above, we do not need the "Search by Drug Name" or "Single
> Drug with Indication(s)" options.

Removed.

> 2. Some changes are requested to the user interface. The preferred sequence is
> basically flipped from how it reads currently. The order should be (1) "Select
> Report Type", (2) "Select Display Type", and (3) "Select Indication(s)".

Done.

> 3. In the "Display Indications for Each Drug" display option, they felt the
> data would be easier to use (as when copying/pasting into Word) if it were
> in a > list, rather than in a table, and if all bullets were removed. The
> suggested display is to have an indication followed by indented drug
> names, as below.
>
> breast cancer
> trastuzumab (CDRXXXXX)
> raloxifene hydrochloride (CDRXXXXX)
> cervical cancer
> topotecan hydrochloride (CDRXXXX)

It says here the "Display Indications for Each Drug" display option but I think this should have been the "Display Indication(s) for each Drug" option, right?

The report currently displays two or three columns depending if we're including the Brand Names or not.
If we do include the Brand names how would we want those to be displayed?
I picked one option for now but that might not be the option the users would prefer.

> 4. For both the "Indications and Drug Names Only" and "Indications and Drug
> Names with Brand Name(s)" report types, bullets are not needed within the
> table as previously requested. Please also remove the bullets from the list
> of all indications.

Done.

> 5. In the "Display Indications for Each Drug" display, please alphabetize the
> results by drug name (second column).

Done.

> 6. The option to "Display Drugs for Each Indication" WITH the report type
> "Indicaitons and Drugs With Brand Names" is not needed.

Removed.

> 7. Another thing I just noticed. It looks like only 2 drug names are showing
> up for each indication, even when there are more than 2. For example, "breast
> cancer" and "multiple myeloma and other plasma neoplasms" each have 3 drugs
> with this indication, but only 2 are visible when you run the "Display drugs
> for each Indication" report.

Which would be the third drug for "breast cancer"?
I actually do only pick up 2 drugs with my query for this indication, Raloxifene Hydrochloride and Ixabepilone.

BZDATETIME::2010-08-26 16:18:58
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

(In reply to comment #12)
> Which would be the third drug for "breast cancer"?
> I actually do only pick up 2 drugs with my query for this indication,
> Raloxifene Hydrochloride and Ixabepilone.

This was interesting. For some reason the path for the ApprovedIndication had been removed from the query_term table and only a few of those (old) entries still existed.
I've added the path to the table again, re-indexed and now all 21 of the drugs with "breast cancer" indications are listed.

We will need to remember to do this on BACH, too once we move the report to production.

BZDATETIME::2010-08-26 16:35:47
BZCOMMENTOR::Robin Juthe
BZCOMMENT::14

Now there is plenty of data to look at 🙂 Thanks, Volker.

Another thing I noticed – In the "Display Indication(s) for Each Drug" Display type, the drug names are repeated in the report as many times as they have indications. For example, bleomycin, which has 8 indications, is listed 8 times in the report. Is it possible to remove duplicates?

BZDATETIME::2010-08-31 09:57:14
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

I think we're very close now.

I've made the changes to sort the drug names as well as the indications, removed the duplicates, and made some CSS changes.

This is ready for review on MAHLER.

BZDATETIME::2010-09-02 12:14:55
BZCOMMENTOR::Robin Juthe
BZCOMMENT::16

we ARE getting close!

Deb and Diana are meeting today to review the report again. In the meantime, I noticed one thing that needs to be fixed:

The Brand names are only displaying for the last drug listed for each indication in the "Display Drugs for Each Indication" report with the option selected to include brand names.

For example:

Indication: Hodgkin lymphoma

Bleomycin (CDR615384)
Bleomycin Sulfate (CDR633980)
Cyclophosphamide (CDR557430)
Dacarbazine (CDR649947)
Doxorubicin Hydrochloride (CDR542867)
Vincristine Sulfate (CDR599877)
Vincasar PFS

Where only the Brand name for Vincristine Sulfate displays.

BZDATETIME::2010-09-07 17:20:19
BZCOMMENTOR::Volker Englisch
BZCOMMENT::17

Adding additional comment from Deb.

-----------------------

From: Price, Deborah (NIH/NCI) [E]
Sent: Thursday, September 02, 2010 1:57 PM
To: Harrison, Robin (NIH/NCI) [E]; Englisch, Volker (NIH/NCI) [C]
Cc: Blais, Diana (NIH/NCI) [E]
Subject: Indications reports - just a couple of more revisions

Hi Robin and Volker,

Thanks again for our terrific Indications Reports! Diana and I especially like the bright green table!

In addition to the change Robin just submitted (about having all the brand names shown, not just for the last drug),
we only have the following change requests:

Approved Indications for Drug Information Summaries Report
(Indications and Drug Names Only and Display Drugs for each Indication)
1. Remove “Indication:” and put the indication itself flush left.
2. Include only drugs that have been made publishable.
Approved Indications for Drug Information Summaries Report
(Indications and Drug Names with Brand Names and Display Drugs for Each Indication)
1. Would be better displayed as a table, if possible. Alphabetize on generic drug name with corresponding brand names in a separate column.
That’s it; we are soooooooo close!
Thanks so much again for these terrific reports. They will be immensely helpful.
Deb

BZDATETIME::2010-09-07 17:29:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18

(In reply to comment #17)
> In addition to the change Robin just submitted (about having all the brand
> names shown, not just for the last drug),

This has been fixed.

> Approved Indications for Drug Information Summaries Report
> (Indications and Drug Names Only and Display Drugs for each Indication)
> 1. Remove “Indication:” and put the indication itself flush left.

Done.

> 2. Include only drugs that have been made publishable.

Done.

> Approved Indications for Drug Information Summaries Report
> (Indications and Drug Names with Brand Names and Display Drugs for Each
> Indication)
> 1. Would be better displayed as a table, if possible.
> Alphabetize on generic drug name with corresponding brand names
> in a separate column.

I'm now displaying the report without brand names as a list and the report with drug names as a table, however both sorted by indication. I'm not sure whey we want to sort this report by drug name in the presence of the drug report?

This is ready for another round on MAHLER.

BZDATETIME::2010-09-16 09:12:42
BZCOMMENTOR::Robin Juthe
BZCOMMENT::19

(In reply to comment #18)

> I'm now displaying the report without brand names as a list and the report with
> drug names as a table, however both sorted by indication. I'm not sure whey we
> want to sort this report by drug name in the presence of the drug report?
> This is ready for another round on MAHLER.

I agree these should be sorted by indication, as you have them; if sorted by drug name, they would be the same as the Display Indications for Each Drug report. This looks good.

One minor request: now that the word "Indication:" has been removed from the list report of the indications and drug names/display drugs for each indication report, could you please make the indication itself bold? This way when this information is copied/pasted into Word, it will be more clear which is the indication and which are the drug names (since the indentation is lost in that conversion).

Then, I think this is ready to promote.

Thanks!

BZDATETIME::2010-09-16 10:32:12
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

(In reply to comment #19)
> ... could you please make the indication itself bold? This way when this
> information is copied/pasted into Word, it will be more clear which is the
> indication and which are the drug names (since the indentation is lost in that
> conversion).

I changed the indication to display in bold but I'm wondering how you're loading the report to Word? Do you copy/paste it?

When I copy/paste the report does display the indentation correctly. However, I can't use the Edit with Word button because this only converts the initial page.

BZDATETIME::2010-09-16 10:39:44
BZCOMMENTOR::Robin Juthe
BZCOMMENT::21

(In reply to comment #20)
> (In reply to comment #19)
> I'm wondering how you're
> loading the report to Word? Do you copy/paste it?

Yes, I was copying/pasting the report. Before everything was left-justified, but now, the indentation is preserved. Anyway, I still think the bold text makes it easier to read. Thanks.

Please promote this to BACH.

BZDATETIME::2010-09-16 10:43:13
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22

(In reply to comment #21)
> Yes, I was copying/pasting the report. Before everything was left-justified,
> but now, the indentation is preserved.

Ahh! You know what? This is certainly the same problem that we just "fixed" for the Summary Comments report to have the colors show up. I modified the class selectors this morning from *.name to .name which is probably the reason why the report is now showing up with the indentation.

BZDATETIME::2010-09-16 10:47:06
BZCOMMENTOR::Robin Juthe
BZCOMMENT::23

Ok, glad to hear I'm not going crazy!!

BZDATETIME::2010-09-16 11:15:16
BZCOMMENTOR::Volker Englisch
BZCOMMENT::24

The following programs have been copied to FRANCK and BACH:
DrugIndicationsReport.py - R9894
DrugInfoReports.py - R9896

Please verify on BACH and close this bug.

BZDATETIME::2010-09-21 09:18:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::25

Robin, I'm not sure if you are waiting for William to close this issue but since you had requested the report and William wasn't really involved with this it probably makes sense if you closed the issue.

BZDATETIME::2010-09-22 17:27:52
BZCOMMENTOR::Robin Juthe
BZCOMMENT::26

Verified on BACH. Closing this issue. Thanks!