PDQ Issues

Issue Number	3076
Summary	Create GP mailer filter set
Created	2010-02-03 17:33:18
Issue Type	Improvement
Submitted By	Kline, Bob (NIH/NCI) [C]
Assigned To	Englisch, Volker (NIH/NCI) [C]
Status	Closed
Resolved	2010-04-01 17:02:44
Resolution	Fixed
Path	/home/bkline/backups/jira/ocecdr/issue.107404

Description

BZISSUE::4752
BZDATETIME::2010-02-03 17:33:18
BZCREATOR::Bob Kline
BZASSIGNEE::Volker Englisch
BZQACONTACT::Bob Kline

We need to assemble publication information for GP documents the same way we do for other types: the vendor filter set is comprised of the mailer filter set for the output document type and a post-processing filter which strips out the information needed for mailers but not wanted for the published documents (for example, a contact block whose UsedFor attribute contains the token GPMailer but not the token GP). Please create the new mailer filter set, ensuring that it does not discard information needed for the GP mailers, and the post-processing filter which strips information not wanted for the published GP docs.

Comment entered 2010-02-22 12:00:37 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-22 12:00:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

Bob, you had mentioned you would like me to create a separate address block for the GP Mailer if the 'UsedFor' attribute contained the 'GP GPMailer' tokens.
Where you thinking for me to create a GPMailer block for all documents or just for the ones with the GPMailer token?

Comment entered 2010-02-22 12:55:18 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-02-22 12:55:18
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

There shouldn't be any without exactly one contact block with the GPMailer token. Are you seeing some?

Comment entered 2010-02-22 13:07:12 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-22 13:07:12
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

(In reply to comment #2)
> Are you seeing some?

I haven't looked. I thought the GPMailer token would only be used if the address is different from the default and I was wondering how you would have wanted that to be handled.

Comment entered 2010-02-22 13:59:46 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-02-22 13:59:46
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

The GPMailer token is how the default is indicated (for mailers).

Comment entered 2010-02-22 17:58:38 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-22 17:58:38
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

I've created/modified the filter sets to create a
Mailer GP Set
and I've modified the filters to create an address block just for the GP mailers as follows:
<PRACTICELOCATION @UsedFor="GPMailer">
...
</PRACTICELOCATION>

I will need to talk to Bob (or get a list from him) which other elements he still needs.

The change is currently on MAHLER.

Comment entered 2010-02-22 18:01:56 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-22 18:01:56
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

For my information:
The following filters have been modified:
CDR315588 - Module: Vendor Cleanup Templates
CDR559215 - Vendor Filter: GeneticsProfessional

Comment entered 2010-02-23 20:08:26 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-23 20:08:26
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

Bob, do you need me to move these filter changes to FRANCK (or BACH) or can you use them on MAHLER?

Comment entered 2010-02-24 09:18:57 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-02-24 09:18:57
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

Please install them on Franck.

Comment entered 2010-02-24 10:38:33 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-24 10:38:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

Done.

Please note: I've only created the GPMailer address block for you at this point.
You did mention a few other things but wanted to let me know the
complete list. Just let me know when you come across something
else missing and I'll add it.

Comment entered 2010-02-25 14:54:20 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-25 14:54:20
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

Unfortunately, I had to copy the following filter to BACH today
CDR315588 - Module: Vendor Cleanup Templates

This GenProf vendor filter change and the filter change for OCECDR-3075 are sharing the same module and when I copied the filters for OCECDR-3075 to BACH the publish preview report for the Person/GP documents failed.

I've copied this filter to BACH since the implemented changes only remove the data included for the GP Mailers and we're currently not processing any GP data.

Comment entered 2010-02-26 18:49:54 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-26 18:49:54
BZCOMMENTOR::Volker Englisch
BZCOMMENT::11

The following filters have been copied to FRANCK and BACH (per request in OCECDR-2954 comment 92):
CDR315588 - R9505: Module: Vendor Cleanup Templates
CDR559215 - R9505: Vendor Filter: GeneticsProfessional

Comment entered 2010-03-10 15:13:19 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-03-10 15:13:19
BZCOMMENTOR::Bob Kline
BZCOMMENT::12

(In reply to comment #9)
> Done.
>
> Please note: I've only created the GPMailer address block for you at this
> point.
> You did mention a few other things but wanted to let me know the
> complete list. Just let me know when you come across something
> else missing and I'll add it.

I'll also need the fax number and web address for the GPMailer location.

Comment entered 2010-03-10 17:18:40 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-10 17:18:40
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13

(In reply to comment #12)
> I'll also need the fax number and web address for the GPMailer location.

Please try it now.

Comment entered 2010-03-10 17:21:38 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-03-10 17:21:38
BZCOMMENTOR::Bob Kline
BZCOMMENT::14

Which server?

Comment entered 2010-03-10 17:22:55 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-10 17:22:55
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15

FRANCK and MAHLER.

Comment entered 2010-03-10 17:27:09 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-03-10 17:27:09
BZCOMMENTOR::Bob Kline
BZCOMMENT::16

You might need to put on Bach: it doesn't fail gracefully if it can't find everything it needs; filtering 664600 on Franck gets me this (it succeeded on Bach):

<Errors>
<Err>XSLT error: code: 61
msgtype:error
code:61
module:Sablotron
URI:cdr:CDR40478/last
line:76
msg:could not open document 'cdr:CDR665454/last'
</Err>
</Errors>

Comment entered 2010-03-10 17:32:14 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-10 17:32:14
BZCOMMENTOR::Volker Englisch
BZCOMMENT::17

I don't like it but there you go. It's on BACH now.

Comment entered 2010-03-10 17:37:20 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-03-10 17:37:20
BZCOMMENTOR::Bob Kline
BZCOMMENT::18

(In reply to comment #17)
> I don't like it but there you go. It's on BACH now.

Thanks.

I understand why you don't like it, and I'd be just as happy (more, in fact) if instead you were to defer failure until the final cleanup for publishing when you don't find everything you need. The mailers won't need everything that the publishing job needs. That would be more work than might be worth while, though.

Will the names for these two elements be mixed case (in contrast with the other elements, whose names are all uppercase)? That's fine, as long as it's permanent and stable.

Comment entered 2010-03-10 18:03:00 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-10 18:03:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::19

(In reply to comment #18)
> Will the names for these two elements be mixed case

Yes.

Comment entered 2010-03-17 11:10:04 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-17 11:10:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

There is one more change that needs to be implemented.
The vendor filter doesn't display the email addresses with the Public=No attribute but Bob needs these email addresses regardless of the attribute.

I will therefore need to make some minor adjustments to the filter sets to include the email addresses for the GPMailer address block.

Comment entered 2010-03-23 16:53:55 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-23 16:53:55
BZCOMMENTOR::Volker Englisch
BZCOMMENT::21

I've made the changes to display the phone and email information in the GPMailer address block even if the attribute Public=No has been specified so that Bob will be able to display the entire address information for the mailers.

Comment entered 2010-03-24 13:32:43 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-24 13:32:43
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22

I've ran another publishing job on FRANCK for these GP documents. The resulting documents were identical to the previous set of GP documents.

Comment entered 2010-04-01 17:02:44 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-04-01 17:02:44
BZCOMMENTOR::Volker Englisch
BZCOMMENT::23

As discussed at this week's status meeting this issue is resolved and can get closed.

Elapsed: 0:00:00.001346

CDR Tickets