CDR Tickets

Issue Number 3055
Summary Summary Citations Sorting
Created 2009-12-31 10:27:28
Issue Type Bug
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2010-02-04 15:46:15
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107383
Description

BZISSUE::4731
BZDATETIME::2009-12-31 10:27:28
BZCREATOR::Volker Englisch
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

Victoria noticed that some of the citations on the Male Breast Cancer summary (CDR62745-V83) weren't sorted/combined properly in the publish preview view.
The citations that should be sorted and combined as in
[9-11]
are instead displayed as
[10, 11, 9]

Comment entered 2009-12-31 11:31:08 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2009-12-31 11:31:08
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

A quick look at the document and the filters shows that this is a problem due to the fact that there are comments listed between the citations and the order in which the document is being processed.

The citations are being displayed like this:
<Citation>First citation</Citation>
<Comment>Some comment</Comment>
<Citation>Second citation</Citation>
<Comment>Another comment</Comment>
<Citation>Third citation</Citation>

The summary filters takes consecutive citations and sorts these in the denormalization step. The comments, however, are removed in the vendor filter step. If I remember correctly this has been done because the Summary QC reports do display the Comments and therefore we can't throw those out too early in the process.
We may be able to remove the Comment elements in a different step by creating an additional filter set and tweaking all of the summary filter sets.
In the interim putting the comments at the end of a list of Citations might be an acceptable workaround.

Comment entered 2010-01-28 14:16:36 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-01-28 14:16:36
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

Volker:

If there were any conclusions on this at last week's meeting, could you capture them here in a comment? Thanks!

Comment entered 2010-02-02 10:23:25 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-02-02 10:23:25
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

Bob suggested to extend the task in OCECDR-2998 to allow a comment attribute for the Citation elements in order to associate a comment with a specific citation and avoid the sorting problem but Margaret thought we could leave the Citation element as is and emphasize to the users that comments between citations are not allowed.

Unless I misunderstood our discussion there's nothing left to be done for this issue and it could be closed.

Comment entered 2010-02-04 15:46:15 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-02-04 15:46:15
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::4

(In reply to comment #3)
> Bob suggested to extend the task in OCECDR-2998 to allow a comment attribute for
> the Citation elements in order to associate a comment with a specific citation
> and avoid the sorting problem but Margaret thought we could leave the Citation
> element as is and emphasize to the users that comments between citations are
> not allowed.
>
> Unless I misunderstood our discussion there's nothing left to be done for this
> issue and it could be closed.

Per today's CDR status meeting, this issue can be closed.

Closed!

Elapsed: 0:00:00.001676