CDR Tickets

BZDATETIME::2009-10-28 12:07:35
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

Just wanted to make sure (before I jump on this, which is now the highest-priority task in my queue) that the following question (which I posted to the email thread running outside the tracker before this issue was created) doesn't fall through the cracks:

Just checking since this would be a substantial task: what overlap (if
any) would there be between this enhancement to the mailers and the new
web site for board members?

BZDATETIME::2009-10-29 11:38:22
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::2

Just thought I would mention that I had forgotten that we have images in a couple of HP summaries right now and it doesn't seem to break the mailers which is what I was thinking would happen. So we can go ahead and put the images in the summaries to show on Cancer.gov while we work on this. I am not sure where it fits in the priority list relative to the other things we want to do. We should discuss this.

BZDATETIME::2009-10-29 16:47:31
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::3

Changed priority to P4.

BZDATETIME::2009-10-30 08:20:28
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::4

I think this should even be a lower priority than 4 so that it falls under the other things Bob is working on.

BZDATETIME::2009-10-30 14:10:04
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

(In reply to comment #4)
> I think this should even be a lower priority than 4 so that it falls under the
> other things Bob is working on.

Sure - I have changed it to a 6 for now. Thanks!

BZDATETIME::2009-11-10 14:27:01
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

I've done some experimenting with the images for CDR62910, and it's become clear to me that there are some harsh trade-offs involved in this feature. For some of the taller images, I would have to shrink the image down to well under a fifth of what would fit on the page if I wanted to get LaTeX to position the image directly at the point in the document where the Media link is found (and I'm not sure I'm looking at the worst case). In order to get the same image to show up at the top of the following page (but after some text which follows the Media link in the CDR document) I would have to knock the image down to about half size. If it's acceptable to have the images appear at the end of the document, I can get them about the same size as you would get printing from the Cancer.gov web site (though even then the quality of the PostScript output is not as good as on Cancer.gov, which isn't itself really good to start with). Now these images may not be representative (they are mostly text), but you should take a look at what I've done so far. If you're in the office some time this afternoon, Margaret, perhaps you could stop by and look at the samples with me.

BZDATETIME::2009-11-13 11:32:41
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::7

We should go with the option that shows full size images and puts them at the end of the mailer document.

BZDATETIME::2009-12-03 09:09:58
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

I am running into some problems with the underlying engine which processes rules for converting XML documents into LaTeX. I decided to wait until Alan returns from vacation before proceeding any further with this task, since it will be more efficient for him to address the issues in this package (he's the only one who really understands how it works).

BZDATETIME::2009-12-21 11:48:56
BZCOMMENTOR::Bob Kline
BZCOMMENT::9

Alan:

The fix for cdrxmllatex.py appears to be working correctly.

Margaret:

I'm making good progress on this task, but I just noticed that the LaTeX processor is inserting "Figure [N]: " in front of the caption, where [N] is an automatically incremented number representing the position of the illustration in the sequence of all illustrations appearing in the document. This results in things like "Figure 1: Figure 1: ..." in the printed output, because the users are doing the same thing. Except it's not exactly the same thing, because the users aren't numbering the illustrations carefully, so what we actually have in the output is:

Figure 1: Figure 1: ....
Figure 2: Figure 2: ....
Figure 3: Figure 1: ....
Figure 4: Figure 2: ....

Should we have the users take "Figure N: " out of the caption element, letting the software generate the correct numbering? Or should we have the users fix the numbering in the CDR document, and investigate how to suppress the prefix generated by the LaTeX process? Or should we try to suppress the automatically generated prefix and leave the CDR documents the way they are? I guess the final option would be to leave the correct numbers generated by the LaTeX processor, as well as allow the users to put any numbering system they want in (though I'm having a hard time imagining a successful argument for this course of action).

BZDATETIME::2010-01-04 14:06:44
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::10

I can't quite remember whether we came to a decision about how to handle the figure numbering. I know Lakshmi wanted to explore various options for having references to the figures in the text and the figures themselves be automatically numbered. For right now it seems like we should suppress the automatic numbering in the mailers and go with what the users have put in until we decide on a longer term solution. We can discuss this at our meeting on Thurs.

BZDATETIME::2010-01-04 17:30:22
BZCOMMENTOR::Bob Kline
BZCOMMENT::11

(In reply to comment #10)

> For right now it seems like we should suppress the automatic numbering
> in the mailers and go with what the users have put in until we decide
> on a longer term solution.

I did some research to find out how to do this, and installed and tested the package required on Mahler. It appears to work correctly. Will have something the users can test before long.

BZDATETIME::2010-01-07 16:58:47
BZCOMMENTOR::Bob Kline
BZCOMMENT::12

Implemented on Mahler and Franck; ready for user testing. I put in on Franck so you'd be able to test CDR62910 with the version that's got the images.

BZDATETIME::2010-01-12 11:57:02
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::13

(In reply to comment #12)
> Implemented on Mahler and Franck; ready for user testing. I put in on Franck
> so you'd be able to test CDR62910 with the version that's got the images.

The images show correctly at the end of the summary. Please promote to Bach.

Margaret:
In the part of the summary where the images are referenced as "See Figure 1" etc, the images follow directly after, but this is not so when the mailer is printed. A more descriptive phrase like "See Figure 1 at the end of the summary" might be helpful (for the printed format) but we cannot do this in the summary document because it will not be accurate on cancer.gov. I am not sure if this is something we should be concerned about.

BZDATETIME::2010-01-12 12:07:25
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::14

Yes, the numbering of figures in an issue we need to address. We decided that since the caption will show with the image and it says what the figure number is, that we will go with that until we come up with a better solution. This means (of course) that the figures should be numbered sequentially from the beginning to the end of the summary.

BZDATETIME::2010-01-12 12:16:08
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::15

I agree that this can be promoted to Bach. It does reinforce to me that we need to get higher quality images whenever possible in the future. They are really fuzzy looking--more so in the mailer than on Cancer.gov.

BZDATETIME::2010-02-04 13:54:38
BZCOMMENTOR::Bob Kline
BZCOMMENT::16

Get this out the door!

BZDATETIME::2010-02-04 15:18:50
BZCOMMENTOR::Bob Kline
BZCOMMENT::17

Promoted to Bach and Franck.

BZDATETIME::2010-02-05 09:57:06
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::18

When I tried to run the preview mailer for the Merkel Cell HP summary on Bach I got the following error: A problem occurred in a Python script.

d:\cdr\Log\tmpuqc57l.html contains the description of this error. D:\Python\lib\cgitb.py:173: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 value = pydoc.html.repr(getattr(evalue, name))

It worked fine when I ran it for Male Breast Cancer, which doesn't have any illustrations.

BZDATETIME::2010-02-05 10:39:57
BZCOMMENTOR::Bob Kline
BZCOMMENT::19

Please give it another try.

BZDATETIME::2010-02-05 10:52:13
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::20

Looks great! Issue closed.