CDR Tickets

Issue Number 3006
Summary [Genetics Directory] Publish Preview for person document type
Created 2009-10-30 08:37:07
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2010-01-28 11:24:16
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107334
Description

BZISSUE::4682
BZDATETIME::2009-10-30 08:37:07
BZCREATOR::William Osei-Poku
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

In OCECDR-2847 new elements have been added to the person document type for
the genetics professional directory. Since the genetics professional person documents would be published, please generate a publish preview for these documents.

Comment entered 2009-11-17 18:43:35 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2009-11-17 18:43:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I've added the PublishPreview button to the Person toolbar by modifying
Cdr.mcr

Comment entered 2009-11-17 18:58:22 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2009-11-17 18:58:22
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

FYI:
Before we can use the publish preview report for GeneticsProfessionals we will need to have the Gatekeeper software changed because it currently does not allow this document type to be processed.

Comment entered 2009-12-15 14:46:46 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2009-12-15 14:46:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

Blair has finished the Cancer.gov modifications for the GeneticsProfessional PP.

I've made changes to the program
PublishPreview.py
to display an error if the PP is being used for a Person document that doesn't contain GP information.

Blair needs to do one minor change at his end: currently the FirstName and LastName are displayed without a space in between.
I need to check why the email address is not being included in the vendor output.

A sample of the PP may be viewed here
http://mahler.nci.nih.gov/cgi-bin/cdr/PublishPreview.py?Session=guest&DocId=CDR0000651940&Version=cwd

Comment entered 2009-12-22 17:03:56 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2009-12-22 17:03:56
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

The following files have been copied to FRANCK and BACH to allow the publish preview reports to work for GenProf documents:
Cdr.mcr - R9445
PublishPreview.py - R9446

Obviously, there is no data on BACH at this point but it's working on FRANCK as expected.

Comment entered 2010-01-21 16:22:40 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-21 16:22:40
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

(In reply to comment #4)
> The following files have been copied to FRANCK and BACH to allow the publish
> preview reports to work for GenProf documents:
> Cdr.mcr - R9445
> PublishPreview.py - R9446
>
> Obviously, there is no data on BACH at this point but it's working on FRANCK as
> expected.

We agreed at the meeting today that this can be promoted to Bach next week (likely on Monday 01/25/10) along with OCECDR-2847.

Comment entered 2010-01-25 16:23:37 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-25 16:23:37
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6

On Franck, when the Legacy Data block is absent, publish preview produces an error message:

"CDRPreview web service error: The element 'GENETICSPROFESSIONAL' has invalid child element 'NAME'. List of possible elements expected: 'ID'.Validation error occurred when validating the instance document.,44,2"

When I insert the block and add text, I am able to get publish preview to work successfully. I am not sure if this is required for publish preview to work. However, since newly created records will not have legacy data I believe it should not be required for publish preview.

Comment entered 2010-01-25 16:26:14 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-25 16:26:14
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::7

(In reply to comment #6)
> On Franck, when the Legacy Data block is absent, publish preview produces an
> error message:
>
> "CDRPreview web service error: The element 'GENETICSPROFESSIONAL' has invalid
> child element 'NAME'. List of possible elements expected: 'ID'.Validation error
> occurred when validating the instance document.,44,2"
>
> When I insert the block and add text, I am able to get publish preview to work
> successfully. I am not sure if this is required for publish preview to work.
> However, since newly created records will not have legacy data I believe it
> should not be required for publish preview.

Example: CDR0000663575

Comment entered 2010-01-25 18:45:38 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-01-25 18:45:38
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

Yes, in order for the PublishPreview report to work you must send a document to Gatekeeper that is valid according to the DTD. If a mandatory field is missing you will not be able to run the report.

For the sample document, the ID element is missing.

Comment entered 2010-01-26 10:25:06 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-26 10:25:06
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

(In reply to comment #8)
> Yes, in order for the PublishPreview report to work you must send a document to
> Gatekeeper that is valid according to the DTD. If a mandatory field is missing
> you will not be able to run the report.
>
> For the sample document, the ID element is missing.

The problem is that for new records like CDR0000663575, there will be no Legacy ID. My suggestion is that it should not be required.

Comment entered 2010-01-26 13:06:38 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-01-26 13:06:38
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

I'm pretty sure that the Gatekeeper software requires the ID element, so making it optional would not work.
I'll check with Blair but if I remember correctly we want to enter the CDR-ID instead.

Comment entered 2010-01-27 12:05:08 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-27 12:05:08
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

I am getting the following error for each document on Bach:

      • Error: CDR0000664701 not a GeneticsProfessional Document

Bob, since Volker is in training, could you please look into this for me?

Comment entered 2010-01-27 12:20:36 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-01-27 12:20:36
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

I have half an hour to look at it. In the meantime (or until later today) please use the QC report.

Comment entered 2010-01-27 13:46:35 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-27 13:46:35
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::13

(In reply to comment #12)
> I have half an hour to look at it. In the meantime (or until later today)
> please use the QC report.

Unfortunately, the QC report changes has not been promoted to Bach yet. I will wait for you or Bob to promote it.

Comment entered 2010-01-27 17:44:08 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-01-27 17:44:08
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14

Publish preview and the QC report are now working on BACH.
The system is still reindexing all Person documents so it may be half an hour or so before all GenProf documents can be reviewed with PP.

Comment entered 2010-01-28 11:20:14 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-28 11:20:14
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::15

(In reply to comment #14)
> Publish preview and the QC report are now working on BACH.
> The system is still reindexing all Person documents so it may be half an hour
> or so before all GenProf documents can be reviewed with PP.

(In reply to comment #14)
> Publish preview and the QC report are now working on BACH.
> The system is still reindexing all Person documents so it may be half an hour
> or so before all GenProf documents can be reviewed with PP.

Publish Preview is working fine but the QC report does not display the Genetics information.

Comment entered 2010-01-28 11:24:16 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-01-28 11:24:16
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::16

I am closing this issue. I will open another issue for the enhancements.

Elapsed: 0:00:00.001911