CDR Tickets

BZDATETIME::2009-11-13 12:01:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I've talked to Diana about this and we agreed that, as a first step, we will sort this report alphabetically by title.

We will still need to talk to other users regarding the additionally requested changes. For instance
a) Should we have an option to only display English/Spanish or display both
but sorted by language?
b) Should we suppress the display of blocked documents or offer an option to
display these?

BZDATETIME::2009-11-13 13:42:51
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::2

Unless it is really difficult, I think it would be nice to be able to choose language. I am not sure about Blocked docs. It doesn't seem like it is that helpful to have them included, but we should ask CIAT.

BZDATETIME::2009-11-17 16:39:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

I have made some of the changes that I had talked about with Diana. We had agreed that I would make some small but helpful changes now and she would check with the board managers and CIAT folks to find out if any of the current functionality needed to be kept.

What I have done so far is the following:
1) I've modified the main select page to use the same format as most of our
other reports created lately (using fieldsets).
2) I've added a radio button to select if blocked documents should be included
in the output or not. The default is to exclude blocked documents.
3) When searching by title I've modified the intermediary page to

• remove the zeros from the CDR-ID

• highlight rows the mouse hovers over

• allow a selection to be made by clicking anywhere on the row
  4) For the results page I

• made the table and columns for each document type the same size

• the rows of the tables are now highlighted when the mouse hovers over them

• the output is now sorted by document title

• the zeros have been removed from the CDR-ID

As for the selection of the language we may need to decide how to handle the situation when all document types are being selected because not all document types do have English and Spanish versions.
Maybe we need to restrict the selection of the language to the display of a single document type?

Either way, I'm certain that Diana will find the current changes helpful and we might want to put this in production as is even before a decision has been made on the language.

BZDATETIME::2009-11-18 11:00:58
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::4

Diana has looked at this and said it works great, so we can go ahead and promote the changes you have done so far. We still need to decide how to handle the Spanish documents, but that can be a later phase. (Status still says Assigned, so I couldn't change it to verify.)

BZDATETIME::2009-11-18 13:12:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

The following program has been copied to FRANCK and BACH:
LinkedDocs.py - R9389

Please verify on BACH.

We had discussed that we would still like to select the language for the output but this would be limited to only individual document types selected and only summaries.

BZDATETIME::2009-12-08 13:33:11
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::6

Diana loves the changes to this report, but has one other small request:

Is it possible for the CDR ID# (in the left column of displayed results) to link to the document itself?

BZDATETIME::2009-12-09 13:00:43
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

(In reply to comment #6)
> Is it possible for the CDR ID# (in the left column of displayed results) to
> link to the document itself?

I've added a link to display the "report" but please be aware that we don't have QC reports for every document type that can show up in this results page. For those documents without an existing QC report (i.e. a Mailer document) the plain XML will be displayed.

This is ready for review on MAHLER.

BZDATETIME::2009-12-15 09:14:35
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::8

Note from Diana in testing on Mahler: There’s a little snag here. The link doesn’t work (the QC report won’t display) for reformatted patient summaries. It gives this error message: Redline/Strikeout QC Report not valid for reformatted patient summaries
It works for HP summaries and UNreformatted patient summaries, so it seems like “it” doesn’t know which type of QC report to pick in order to display the document?

BZDATETIME::2010-03-05 14:00:18
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

(In reply to comment #8)
> The link doesn’t work (the QC report won’t display) for reformatted patient
> summaries.

I've made changes to the program
QcReports.py

This program typically only detects the document type but, as we know is true for Summaries, we need more information in order to pick the correct filter set to run Summary QC reports.

When testing, please make sure to test for all QC types (R/S, B/U), all audience "types" (HP, patient - old formatting, patient - new formatting) as well as the special cases like Genetics Summaries.

BZDATETIME::2010-03-18 12:25:00
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::10

Here are Diana's comments:
"I checked this mostly for glossary links and they seemed to work well in the appropriate document types (patient summaries, protocols, drug information summaries). I checked linked docs for some other documents types but wasn’t able to do this thoroughly . Some worked OK, (e.g., certain citations, media docs). But some of the document types that I expected to link to HP summaries did not return any results. If you need me to check for doc. types other than glossary links and patient summaries, I’ll need some guidance.

The linked doc reports for glossary terms linked to summaries seem fine for reformatted and UNreformatted. HOWEVER, I’m not sure what Volker means by the “QC types R/S, B/U”. The CDR link in the linked docs report takes you to the summary QC report, not to the CDR document itself. So there’s no option to then check the R/S or B/U QC reports. I’m assuming the QC report it links to reflects the last published version? Maybe I’m confused.

When testing, please make sure to test for all QC types (R/S, B/U), all audience "types" (HP, patient - old formatting, patient - new formatting)

Please advise "

I believe that CIAT was going to do some testing on some of the other QC reports?

BZDATETIME::2010-03-22 12:57:22
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

(In reply to comment #10)
> Here are Diana's comments:

> I believe that CIAT was going to do some testing on some of the other QC
> reports?

I have tested this on all the major document types and they all appear to work fine. I have asked other CIAT staff to also test with the major document types they work with. I will let you know when all the tests have been completed. But I have a question:

For Person and Organization Document Types, there is a shortcut icon on their menus that generates the report for each of the documents when a user is in the individual document. Can you add this to all the other major document types?
If this is acceptable and you want to add another issue, let me know.

BZDATETIME::2010-03-22 13:05:58
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

(In reply to comment #11)
> For Person and Organization Document Types, there is a shortcut icon on their
> menus that generates the report for each of the documents when a user is in the
> individual document.

I don't understand how this question is related to the LinkedDoc Report.
Where do you see the icons? Is this in the Admin interface or XMetaL?

BZDATETIME::2010-03-22 13:54:23
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::13

(In reply to comment #12)
> (In reply to comment #11)
> > For Person and Organization Document Types, there is a shortcut icon on their
> > menus that generates the report for each of the documents when a user is in the
> > individual document.
>
> I don't understand how this question is related to the LinkedDoc Report.
> Where do you see the icons? Is this in the Admin interface or XMetaL?

In the person or organization record, the icon is on the toolbar. It is the 'chain' icon.

BZDATETIME::2010-03-22 14:17:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14

I see now. Yes, this has nothing to do with the change to the report itself (this issue) but with a change to XMetaL.
Please add a new issue to Bugzilla.

BZDATETIME::2010-03-23 09:55:03
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::15

(In reply to comment #14)
> Please add a new issue to Bugzilla.

Will do.

Please promote to Bach. We did not find any problems.

BZDATETIME::2010-03-23 10:47:08
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

The following programs have been copied to FRANCK and BACH:
LinkedDocs.py - R9533
QcReports.py - R9533

Please verify on BACH and close this bug.

BZDATETIME::2010-03-24 10:14:15
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::17

Diana ran this and said it worked great. Issue closed.