CDR Tickets

Issue Number 2993
Summary [Internal] Possible restructuring of Utilities directory
Created 2009-10-20 14:29:46
Issue Type Improvement
Submitted By Kline, Bob (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-02-10 16:05:20
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107321
Description

BZISSUE::4669
BZDATETIME::2009-10-20 14:29:46
BZCREATOR::Bob Kline
BZASSIGNEE::Volker Englisch
BZQACONTACT::Alan Meyer

As you have suggested, the Utilities directory under version control might benefit from more granular structure. Decide what subdivisions would make the most sense and apply them. Look at the contents of the Bin directory and decide whether some tools should be moved to/from that directory. Look at the files we have marked as obsolete and delete them from the head version of the repo.

I think you can go ahead and close issue #4643, unless you have run into problems you haven't mentioned.

Comment entered 2010-06-14 18:02:18 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-06-14 18:02:18
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

Bob, many of the files I should move don't exist anymore in the Utilities directory.
Can I just ignore those or have you created another place for them (in which case I should probably move similar file content to that space as well.
Example: Oncore.dtd was supposed to go to a directory DTD

Comment entered 2010-06-14 18:09:21 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-06-14 18:09:21
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

You can ignore anything you can't find using "dir /s" from the base trunk directory.

Comment entered 2010-06-16 13:11:00 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-06-16 13:11:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

I've updated the Utilities directory based on the list of files we had prepared way back when we switched from CVS to SVN.
This has been committed as version R9713.

We've now created a few directories within the Utilities directory. These are

  • Bin

  • Conversion

  • Demo

  • GlobalChange

  • Mailer

  • Report

  • ReportOneOff

I created the Bin directory but didn't put any files in there. Typical candidates would be ReindexByDocType.py, CountArmsLabel.py, or FileSweeper.py. However, these are programs currently used in scheduled or publishing jobs and we will need to modify the documentation and starter scripts. For now I'm leaving these where they are. We should, however, move them to the Bin directory as we're making changes to these files in the future.

Please double-check if there are any other files currently in the Utilities directory that we still might want to move to one of those new directories.

Comment entered 2010-09-23 10:22:14 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-09-23 10:22:14
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

Adjusting title.

Comment entered 2010-10-20 10:59:59 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-10-20 10:59:59
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

(In reply to comment #3)
> I created the Bin directory but didn't put any files in there. Typical
> candidates would be ReindexByDocType.py, CountArmsLabel.py, or FileSweeper.py.
> However, these are programs currently used in scheduled or publishing jobs and
> we will need to modify the documentation and starter scripts.

I've moved the following programs to the bin directory:

  • CheckDTDs.py

  • CountArmsLabel.py

  • FileSweeper.py

  • LoadZipCodes.py

  • ReindexByDocType.py (and other re-index scripts)

and I've modified the calling programs where necessary.
I'll leave it up to everyone else to move other scripts to the bin directory an modify the calling routines.

Please verify and close this bug.

Comment entered 2011-01-03 10:00:44 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-01-03 10:00:44
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

Alan, you are the QA for this item. Is there anything you think that still needs to be done on this issue at this point.

Comment entered 2011-01-26 12:33:01 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-01-26 12:33:01
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

Alan, was there anything else that needed to be done before closing this issue?

Comment entered 2011-02-10 16:04:18 by alan

BZDATETIME::2011-02-10 16:04:18
BZCOMMENTOR::Alan Meyer
BZCOMMENT::8

It's always possible to twiddle things but I think we've done enough on this task.

Comment entered 2011-02-10 16:05:20 by alan

BZDATETIME::2011-02-10 16:05:20
BZCOMMENTOR::Alan Meyer
BZCOMMENT::9

Closing.

Elapsed: 0:00:00.001623