| Issue Number | 85 |
|---|---|
| Summary | [Full Citation] Board Manager Action "No Further Action" Symbol |
| Created | 2013-10-31 09:59:12 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2013-12-18 15:16:05 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.114398 |
The symbol that is displayed for a Board manager action value of "no further action" should be the no symbol rather than the green check mark.
This has been implemented on DEV. I implemented exactly what was requested, in the most direct way possible. I noticed while I was making the change that the original code had mechanisms that might have been used for distinguishing between 'pass' and 'reject' actions. I saw that an EbmsTopicDecisions object was created for board manager actions, with an array of states passed in for the object's "pass" actions. This array (which included the "no further action" state) was ignored in the function to format a board manager action, which had hard-coded creation of the "pass" image. It occurred to me that I might delete the "no further action" state from the array, and rewrite the function to use the array to make the decision about which icon to display, but the code in this file is so complicated that there was a significant risk of inadvertently breaking something by removing one of the states from the array, without much more analysis than could be accomplished during the amount of time estimated for this ticket. Bottom line: what I've done accomplishes what was requested by the ticket.
Promoted to QA.
Verified on QA.
Verified on prod.
Elapsed: 0:00:00.000697