EBMS Tickets

The current version of citations.inc (r12059) has 6,342 lines. There are about a dozen functions which have over 100 lines, the largest of which is 934 lines long.

~JutheR: Following up on our discussion of this issue from yesterday: I think it's quite possible that a complete redesign of the so-called "Full Citation" page (which you realized wasn't what this ticket was created for) would be significantly easier that rewriting the existing code to preserve the current behaviour. For example, it would have been simpler for buttons on the form which add or modify decisions to bring up a new form to perform the requested action (without trying to embed it in a display of the complete "Full Citation" page), and then on completion of the action, redraw the "Full Citation" page, incorporating the results of the action. In addition to being simpler (and possibly eliminating the causes of things like the mysterious "conflicting hash" error messages), it might actually make the forms easier to use: I personally find it difficult sometimes to tell where the form I'm working with leaves off and the rest of the page in which the form is embedded picks up. Just some food for thought.

This is still a daunting task, but over the years we have made incremental improvements to the code each time we've touched this file, particularly in the organization and in-place documentation, so the level of effort to do the remaining cleanup and refactoring has dropped somewhat.

This is done.

Verified on ebms4.