| Issue Number | 789 |
|---|---|
| Summary | [Agenda page] Open links in a new window |
| Created | 2023-06-21 18:59:53 |
| Issue Type | New Feature |
| Submitted By | Shields, Victoria (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2023-06-30 13:41:01 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.349348 |
From the meeting agenda page, please make linked items open in a new browser window.
~vshields and ~juther I examined the code for
the module which creates the linking dialog window to try and figure out
what I could do to modify the default setting for the Open in new
window toggle, but found nothing. I did find an old enhancement
request ticket
submitted for a different branch of the module in 2016 asking for the
ability to modify the default setting for the button, but the ticket was
closed with the resolution "won't fix" on the grounds that it was too
easy to accomplish the desired modification with "a line of JS in your
theme" to justify complicating the module to add an administrative UI
interface for altering the setting. Unfortunately, the maintainer of the
module did not offer any clues as to what that "line of JS" would look
like. So I reached out to him on the Drupal Slack channel and asked if
he could tell me what to add to our theme's JavaScript in order to
modify the default for the button. He replied that since we're using a
different branch of the module than that for which the original request
was submitted (a branch intended for older versions of Drupal) he didn't
know off the top of his head how to do it with the newer branch of the
module. He said he would investigate and see if it were possible, but
only if I first share this web page with
you. I plan to tell him I have shared the advice with you and that your
response was that since this is a closed system and you have consulted
with the users of the site, who indicated the preference that most of
the links open the linked targets in a separate window, the advice
against using the target="_blank" attribute is less
applicable in this situation. If that response is not accurate, let me
know, and we'll come up with something else.
[Filling in some background from Thursday's status meeting] I explained that the links added in the Agenda and Notes fields have a button which can be used to control whether a given link opens the target is a separate window (or a separate tab in the same window, in modern browsers). I was asked to see if I could make the default for that button be "on" for new links.
Installed on DEV. The field has been moved out of the Advanced block and is now at the bottom of the form, defaulting to "ON" (I am told there's no way to control the position of the field, which I would rather have above the action buttons; oh, well).
Verified on DEV.
Verified on QA.
Verified on PROD.
Elapsed: 0:00:00.000544