| Issue Number | 626 |
|---|---|
| Summary | Incorrect tests for substrings |
| Created | 2022-04-03 09:39:34 |
| Issue Type | Bug |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-04-03 10:03:02 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.314500 |
The upgrade to PHP 7.4 uncovered a bug in the travel menu template. The code is trying to find out in a couple of places if the first character of a string is '#' but is doing it using indexing of the string, which doesn't work in PHP. Causes warnings to appear on the travel pages.
One of the few benefits of being in a pandemic is that the board members aren't doing a lot of traveling right now, so no one has noticed this bug. That won't continue forever, though.
Fixed on DEV.
I see that the warnings don't appear in production for some reason, so it's less urgent to deploy this fix. Maybe even safer not to, in case my fix breaks something. 😛
This problem (and this ticket) have been overtaken by a switch on CBIIT's part. They're now forcing us to upgrade Drupal to the latest version and PHP to 8.0.x, which breaks LOTS of stuff.
Elapsed: 0:00:00.000554