EBMS Tickets

Issue Number 62
Summary [General] Design - Submit/Filter/Reset buttons
Created 2013-09-17 14:06:54
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2013-11-12 10:43:02
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.113375
Description

TIR #2461 entered 2013-03-08 by Robin Juthe (Future Release status)

Design - Submit/Filter/Reset buttons

We'd like to review the naming and placement of all of the "submit", "save", "filter", "reset", etc. buttons in order to make them consistent, both in terms of the word used (if two words are used to mean the same thing) and the placement on the page. For example, sometimes "reset" is on the right and sometimes it's on the left. Putting this in for a future release.

Comment entered 2013-10-30 10:01:28 by Kline, Bob (NIH/NCI) [C]

Robin will provide a specific list of changes to be made.

Comment entered 2013-11-07 17:39:25 by Juthe, Robin (NIH/NCI) [E]

We've decided to place the "dominant" action (SUBMIT, FILTER, SEARCH, SAVE) on the right-hand side and the "null" action (RESET, CANCEL, PREVIEW) on the left-hand side of the page.

Here are the pages that need to be changed (the placement of the buttons needs to be swapped):
https://ebms.nci.nih.gov/citations/search
https://ebms.nci.nih.gov/citations/not-list
https://ebms.nci.nih.gov/review/record
https://ebms.nci.nih.gov/node/add/ebms-event
(Please make the same change to the page to EDIT an event)

Comment entered 2013-11-11 17:39:28 by Kline, Bob (NIH/NCI) [C]

I've taken care of the pages we created ourselves, and I have reached out to the folks who implemented the event pages for the system for assistance in modifying things that appear to be buried more deeply within the bowels of Drupal.

Comment entered 2013-11-12 10:43:02 by Kline, Bob (NIH/NCI) [C]

Implemented on DEV.

Comment entered 2013-11-14 08:37:15 by Kline, Bob (NIH/NCI) [C]

By the way - just so everyone remembers: the reason some of the submit buttons used to be first (before the cancel or reset buttons) was so that the default action triggered by the Enter key would be the main submission of the form. From a certain perspective, having the cancel or reset action be the default could be viewed as the preferable, safer option. I just want to make sure you're aware of this change in behavior which will result as a side effect of this change in button order.

Comment entered 2013-11-19 15:08:39 by Juthe, Robin (NIH/NCI) [E]

The most notable side effect of this change is that a search can no longer be initiated by hitting the enter key. Is it correct to assume that the button on the left-hand side of the page is the "default" (and its action would be triggered by hitting enter)?

I'd like to discuss the search page with the other Board managers in our meeting tomorrow. I've also added Cynthia and Minaxi as watchers to this issue in case they have a preference about the location of the buttons and the default action on the search page.

Comment entered 2013-11-19 15:50:51 by Kline, Bob (NIH/NCI) [C]

Right - that's what I was pointing out in my Thursday comment.

Comment entered 2013-11-21 16:48:25 by Juthe, Robin (NIH/NCI) [E]

We would like to reverse the change to buttons on the search page, but leave the other changes as implemented. This will also us to hit the Enter key to perform a search (rather than resetting all of the search criteria fields). Thanks.

Comment entered 2013-11-21 17:02:55 by Kline, Bob (NIH/NCI) [C]

Switched back on DEV only (other changes have been made to the search code, and I'm reluctant to push just this file without knowing what might break; this will get picked up when we push the code for iteration II to QA).

Comment entered 2013-11-22 12:13:21 by Juthe, Robin (NIH/NCI) [E]

Verified on DEV.

Comment entered 2014-01-07 10:27:34 by Kline, Bob (NIH/NCI) [C]

This is on QA now.

Comment entered 2014-02-14 16:16:21 by Juthe, Robin (NIH/NCI) [E]

Verified on production.

Elapsed: 0:00:00.000749