| Issue Number | 451 |
|---|---|
| Summary | [Full Citation] Display note about entering review on behalf of a Board member in italics |
| Created | 2017-06-22 12:12:19 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2019-08-12 19:19:52 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.210469 |
The note that gets programmatically added beside a Board member review that was entered by one of us on their behalf include the italics tags, rather than displaying the italicized text.
Per Bob's comment in OCEEBMS-439:
"Looks like a bug in the monster citations.inc file. You can file a
ticket to get that bug fixed, but it won't help the way the report looks
for comments which were entered before the fix. As far as I can tell, it
only happens when you enter the review directly on the "full citation"
page instead of going through the Record Responses interface."
Thanks!
This is not a bug but an improvement. Didn't catch that in time.
Let's clarify what we want to do here. It appears that the "on behalf of" note is appended to the review comment in two different ways, depending on the page from which the review is posted. If the review is posted from the kitchen sink "citation" page, the HTML markup, which consists of two line breaks (to separate the note from the main comment, assuming the comment wasn't empty to start with) plus the italic tags, is added to the string stored in the comment column. If the review is posted on the review page, then the note is appended in parentheses to the rest of the comment without any HTML markup.
We want to add the italic tags to the "on-behalf-of" note in both places, sanitizing the user's own comment to which the the note is appended, and avoid escaping the markup when the comment is displayed, right? (As far as I know, the only place where the escaping was happening, causing the tags to display instead of enabling the italics display, was on the big "citation" page, and it looks like that bug has already been fixed, probably as part of OCEEBMS-439).
Do you want the layout to be the same, regardless of which page the review is posted from? If so, which layout is preferred (inline inside parentheses, or separated from the rest of the comment by a blank line, with no parentheses)?
Should we go back and find the notes which didn't get the italics markup and add it?
Over to you, Robin.
Yes, it looks like this is just an issue of consistency on both the full citation page and on the Reviewed packets - Show Details page. I'll attach screenshots. Please use italicized text separated from the rest of the comment by a blank line with no parentheses (as in the first example on the full citation page on the screenshot posted above). Thanks.
There were three questions. You answered two. 🙂
Oops. We don't need to go back and fix the others. It's OK to modify the appearance moving forward. Thanks.
Implemented on DEV.
Verified on QA.
Verified on PROD
| File Name | Posted | User |
|---|---|---|
| Full Citation page.png | 2019-08-09 14:15:20 | Juthe, Robin (NIH/NCI) [E] |
| Reviewed Packets Show Details Page.png | 2019-08-09 14:15:10 | Juthe, Robin (NIH/NCI) [E] |
Elapsed: 0:00:00.000712