EBMS Tickets

Issue Number 340
Summary [Import] Add "Published" as a placement level for fast track citations
Created 2015-11-12 11:56:00
Issue Type Improvement
Submitted By trivedim
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2015-12-04 09:11:03
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.173606
Description

At present the default placement level is blank and if we use the arrow for pull down option, it displays other options.
We would like to add “Passed Medical Librarian’s Review” as a placement level when we use the TAG “Core Journals Search”. I don’t think we need other placement levels for importing core journals.
Also we would like the citations to be automatically “Published”.

Comment entered 2015-11-17 10:28:18 by Juthe, Robin (NIH/NCI) [E]

Minaxi, thanks for entering this ticket. It looks like the first part of your request is already being handled on QA without needing to select a decision from the placement level picklist. Citations that are imported with the "core journals search" tag automatically receive a "passed medical librarian review" decision. For example, see EBMS ID: 404772 on QA. I just imported this with the "core journals" box checked and this applied both the tag and the passed medical librarian review decision. I believe the only thing that isn't happening is that the citation is automatically published (I just published this citation manually).

Comment entered 2015-11-18 16:58:23 by trivedim

Yes that is correct. It would save us a lot of time if it is automatically published.
Also it would help to add “Passed Medical Librarian’s Review” as a placement level.

Comment entered 2015-11-18 17:04:47 by Juthe, Robin (NIH/NCI) [E]

Thanks, MInaxi. Would you use the "passed medical librarian review" placement level for imports in other situations? It's fine to add it if this would be helpful for other situations, but if it's just for these core journal imports, then I'm not sure if it's necessary since the system is already applying that placement level for these citations (based on applying the tag) without you needing to select it.

Comment entered 2015-11-19 09:33:22 by Juthe, Robin (NIH/NCI) [E]

Added Cynthia to this issue. Cynthia, since Minaxi is out, could you please clarify what is needed for this ticket? (please see my question in the previous comment) Thanks!

Comment entered 2015-11-30 07:51:59 by Kline, Bob (NIH/NCI) [C]

Holding off on estimating this ticket until the requirements are clarified.

Comment entered 2015-11-30 08:23:37 by Boggess, Cynthia (NIH/NCI) [C]

Yes I think we could use this "Passed Medical Librarian review" placement level in other ways in additiona to the core journal search result. I think it could also be used for special search requests that Minaxi and I review before we import. And therefore save us the step of having to re-review them after import just to get them bumped up to the NCI Reviewers queue.

Comment entered 2015-12-04 09:11:03 by Kline, Bob (NIH/NCI) [C]

Enhancement implemented on DEV.

Comment entered 2015-12-04 09:16:23 by Juthe, Robin (NIH/NCI) [E]

Bob, could you please use sentence case - "Passed medical librarian review" to match (most of) the other labels in the drop-down list? If you're able to do this at the same time, please lowercase the "a" in "On Agenda" in that list, too. If not, we can handle that another time. Thanks.

Comment entered 2015-12-04 09:28:39 by Kline, Bob (NIH/NCI) [C]

Capitalization adjusted as requested.

Comment entered 2015-12-04 09:34:53 by Juthe, Robin (NIH/NCI) [E]

Thanks! Sorry, but "Board" should remain capitalized...we always capitalize it when we're referring to the Boards.

Comment entered 2015-12-04 10:26:17 by Kline, Bob (NIH/NCI) [C]

Capitalization tweaked again (as requested).

Comment entered 2015-12-14 12:04:48 by Boggess, Cynthia (NIH/NCI) [C]

This worked the first time but then the option disappeared. The pull down menu disappeared from the import screen. I clicked on several other things (publishing and searching) and came back to the import page and the placement level pull down menu was still gone. I had to exit and log back in to get it to reappear.

Comment entered 2015-12-14 12:09:59 by Boggess, Cynthia (NIH/NCI) [C]

I can also get it to reapear when I select a board.
If this is going to appear selectivly, shouldn't it only appear when the core journals or fast track boxes are checked?

Comment entered 2015-12-14 12:17:15 by Kline, Bob (NIH/NCI) [C]

The timing of the appearance of the picklist for placement hasn't changed (it's behaving the same way in production). To have this modified, please file another ticket.

Comment entered 2015-12-14 14:30:35 by Juthe, Robin (NIH/NCI) [E]

I'll file a separate ticket for the behavior of the placement level menu. It seems to be working okay for me, but that may be because I have a default Board that is always selected when I go to that page. Or perhaps I'm just used to it's sporadic appearance! I'll look into a bit more and put in an issue. I agree that it should only appear when relevant, but I think it should just be added when the "fast track" option is selected since what happens with the core journal tag is a bit different. Citations tagged with "core journal" both pass the medical librarian review AND get published for the imported topic.

Cynthia, did you try importing any citations with the new placement level? I have tried that and it seems to work fine.

Bob, did you say this will work for importing a string of PMIDs but NOT batch import files? Just wanted to capture that in the ticket if I have that right.

Thank you both,
Robin

Comment entered 2015-12-14 14:36:21 by Kline, Bob (NIH/NCI) [C]

I'm pretty sure it will work both with a string of PMIDs and with batch import files. Let me know if it's not behaving that way.

Comment entered 2015-12-14 14:38:16 by Juthe, Robin (NIH/NCI) [E]

OK, sorry to confuse things - thank you for clarifying. It will be good for Cynthia to test the batch part then since I am not accustomed to working with batch import files.

Comment entered 2015-12-14 15:55:48 by Boggess, Cynthia (NIH/NCI) [C]

I imported a batch of 9 childhood liver citations from a file. I checked the box for core journals and choose passed med lib rev. They show as passing my review but are awaiting publication. The citations did not get automatically published. See 404782.

Comment entered 2015-12-14 16:00:23 by Boggess, Cynthia (NIH/NCI) [C]

I just imported 2 citations using the pmid in a string. I checked the box for core journals and selected passed med lib rev. They also show as passing my review but are also awaiting publication. These citations did not get automatically published either. See 404790

Comment entered 2015-12-14 16:10:15 by Juthe, Robin (NIH/NCI) [E]

Looking back at the history for both tickets, it appears the publishing part has not been implemented. Shall I file a separate ticket for that Bob, or do you want to handle it as part of this ticket? It's mentioned in Minaxi's original description, but then I think we lost it when clarifying the requirements (and I forgot it hadn't been implemented already!).

Cynthia, do you want the citations to be automatically published in both cases (i.e., when selecting either "core journals" or "passed medical librarian review"), or just when you select the core journal checkbox?

Comment entered 2015-12-14 16:16:57 by Boggess, Cynthia (NIH/NCI) [C]

Yes, both. Core journals because these are citations that have been selected and reviewed prior to import so they are ready to immediately get published. And any citation that we want to automatically pass my review, can get published. This just saves us a few extra steps.

Comment entered 2015-12-14 16:56:08 by Kline, Bob (NIH/NCI) [C]

I see. So, really the placement level for OCEEBMS-281 should have been "Published," not "PassedInitReview"?

Comment entered 2015-12-15 09:41:13 by Kline, Bob (NIH/NCI) [C]

Changed placement level of articles imported with the core journals flag to "Published" (confirmed verbally with Robin). Changed on both DEV and QA (and in Subversion).

Comment entered 2015-12-15 09:58:15 by Juthe, Robin (NIH/NCI) [E]

Thanks, Bob. I just tested that on QA with a single PMID and it worked well! Cynthia, please see what you think and try a batch also.

I think Cynthia is saying above (referring to her comment yesterday at 4:16) that she would like the placement level selection (this ticket) to also result in the citations being published. Given that change, I think we should consider rewording the placement level to "Published" since it's no longer just passing her review. Would you like a separate ticket for that?

Comment entered 2015-12-15 10:48:13 by Kline, Bob (NIH/NCI) [C]

Tell you what: you change the title of this ticket, and I'll make the change to the software. :-)

Comment entered 2015-12-15 10:50:28 by Juthe, Robin (NIH/NCI) [E]

Done. Thank you, Bob!!!

Comment entered 2015-12-15 10:54:37 by Kline, Bob (NIH/NCI) [C]

Replaced "PassedInitReview" with "Published" in placement level picklist on DEV and QA.

Comment entered 2015-12-16 08:50:26 by Boggess, Cynthia (NIH/NCI) [C]

This looks good. I have tested with batches of citations from a text file and with strings of pmids as well as single pmid. placement level works, core journals check box does what it is supposed to. This feature will save Minaxi and I alot of extra steps!

Comment entered 2015-12-16 17:51:19 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2016-01-08 10:48:03 by trivedim

This is in response to comments by Cynthia and Robin regrding the placement level disappearing after importing one citation. I tested it today and experinced the same. If I have 10 core journals citations to import for PediatricBoard, it allows me to select placement level for the first cittaion. After that I have to select another Board and then come back to Pediatric Board to import next citation. So Basically the placement level should stay at all the time as long as the Core Journals tag is selected.
Robin, would you like me to open the new ticket for the issue?

Comment entered 2016-01-08 10:51:15 by Juthe, Robin (NIH/NCI) [E]

Thanks for testing this Minaxi! I've added a separate ticket for the problem with the disappearing placement level - see OCEEBMS-351. We hope to tackle this is iteration 3 of this release.

Comment entered 2016-01-08 11:21:08 by trivedim

Thanks, Robin!
Hope to see this working soon. It will save a lot of time for me.

Comment entered 2016-04-06 15:35:39 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.000660