EBMS Tickets

Issue Number 339
Summary [Printing] Small Fixes to Coversheet
Created 2015-11-10 17:35:41
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2016-09-30 13:49:48
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.173539
Description

A few minor fixes to the coversheet:

1. I believe we limited the number of authors appearing on the coversheet to three. Please add "et al." after the last author if there are more than three authors on the publication.

2. Page numbers do not appear to be displaying on any of the coversheets. They should display after the volume and issue numbers.

3. Please add the closing parenthetical note to the third disposition.

Thanks!

Comment entered 2015-12-10 11:58:41 by Juthe, Robin (NIH/NCI) [E]

Just had a question about another possible fix to the coversheet. We recently made a few changes to the list of exclusion reasons (see OCEEBMS-323) - will those changes automatically be reflected on the coversheet, too, or does this need to be updated manually?

Comment entered 2016-09-08 10:55:33 by Kline, Bob (NIH/NCI) [C]

Ready for user review on DEV.

Comment entered 2016-09-12 10:01:12 by Kline, Bob (NIH/NCI) [C]

Ah! I bet you weren't asking for page numbers to be added to all the cover sheets. You wanted article pagination to show up in the citations, right?

Comment entered 2016-09-12 10:23:05 by Kline, Bob (NIH/NCI) [C]

Article pagination for citations fixed on DEV.

Comment entered 2016-09-29 12:06:32 by Juthe, Robin (NIH/NCI) [E]

Bonnie tested this on QA and the citation page numbers aren't showing up on the coversheet. She printed packet #14875, which includes the following citations:
PMID 25071104
PMID 25728526

Comment entered 2016-09-30 10:46:57 by Kline, Bob (NIH/NCI) [C]

There was a bug in the original code which I fixed, but I didn't realize the software was using the original brief citation value calculated with the buggy code for articles imported before the bug fix. My solution is to replace the existing values in the brf_citation column of the ebms_article table with empty strings, modify the software to build up the brief citation value on the fly when it finds an empty value in the column (as it will for the older articles) but use the stored value for the newer articles. Ready to test on DEV. Note that for some articles there is still no pagination, because NLM didn't give us any.

Comment entered 2016-09-30 13:49:48 by Kline, Bob (NIH/NCI) [C]

Waiting for user review on DEV.

Comment entered 2016-09-30 14:54:56 by Juthe, Robin (NIH/NCI) [E]

Bonnie confirmed that the citations now have page numbers on DEV. Thanks!

Comment entered 2016-10-04 14:23:59 by Kline, Bob (NIH/NCI) [C]

Ready for testing on QA.

Comment entered 2016-10-04 15:51:45 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2016-12-09 10:35:25 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.000695