EBMS Tickets

Issue Number 193
Summary [Literature] Articles from other packets incorrectly included on Reviewed Packets Page
Created 2014-05-30 16:25:13
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2014-06-26 09:52:34
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.128045
Description

Some of the articles included in a packet are not displaying on the reviewed packets page, despite having the option to show all archived articles selected.

For example, the following packet on EBMS-prod shows four articles on the reviewed packets page (3 of which are archived) while the view/edit packets page reveals that there are 10 articles.

Genetics of Breast and Ovarian Cancer (July 2013) - Group B [Packet #13101]

We can't seem to determine what is causing some articles not to show up, but we have this (older) example as well as one from the Adult Tx Board since the last release.

Comment entered 2014-05-30 16:26:39 by Juthe, Robin (NIH/NCI) [E]

Adding Victoria.

Comment entered 2014-05-30 16:46:43 by Shields, Victoria (NIH/NCI) [E]

The Non-Small Cell Lung Cancer (April 2014) packet is an example of this. (Making a note of this now so I don't have to go looking for an example later.)

Comment entered 2014-06-04 16:23:36 by Kline, Bob (NIH/NCI) [C]

There is a bug on this page, but it's a different bug. We're only showing articles that have at least one review (see Ashleigh's design mockup). However, the bug is causing an article to show up if it has a review for any packet (and the one you were looking at for packet #13101 had a review of article 294648, but from another packet to which it had been assigned). For the Non-small cell lung cancer (April 2014) packet, only four of the articles had any reviews at all.

Comment entered 2014-06-26 09:52:34 by Kline, Bob (NIH/NCI) [C]

This bug has been fixed on DEV. Logged in as Test Board Manager, you will see only the three articles which have at least one review for the packet for https://ebms-dev.nci.nih.gov/review/reviews/13101?sa=1 but you will see an extra article (because it has a review for another packet) at https://ebms-qa.nci.nih.gov/review/reviews/13101?sa=1 (because the fix has not yet been installed on QA).

Comment entered 2014-07-29 07:57:57 by Kline, Bob (NIH/NCI) [C]

This fix is on QA (along with all of the changes for this release).

Comment entered 2014-07-29 11:10:11 by Juthe, Robin (NIH/NCI) [E]

I verified what you've done on QA, but unfortunately this wasn't what we were intending to have happen. The problem in our eyes is “articles missing” – we need to see all articles for a reviewed packet, including articles that haven't been reviewed, in order to inform our decision of whether to archive the packet. If we only see articles with a completed review, we could archive the packet prematurely. We may need to fix this in one of the later iterations of this release. Sorry I didn't see this earlier.

Comment entered 2014-07-29 17:47:42 by henryec

Robin, Can we close this one and open a new improvement request for showing all articles?

Elapsed: 0:00:00.000764