EBMS Tickets

The original version of the function that retrieved the articles sorted them by descending import dates, i.e., most recently imported first.

I modified that to sort by journal title first in alphabetical order, then by descending import dates.

I tested with the one packet that exists for Test Board Member and it appears to work.

I've marked it as resolved fixed, ready for testing on DEV. I can move the fix to QA but we may want to leave QA the old way for comparison until initial testing is done.

I'm not sure which issue to post this to, but I figured this one was the closest since it has to do with the Board member packet page. Anyway, I'm getting an error message sporadically on this page on QA (see attached screenshot).

Is this sort by journal expected to work for all existing packets or just newly created packets since the change was made? We are fine with either, just trying to determine if it is working as intended. Thanks.

It should work for all packets. If it's not, let me know about one or more packets for which it's not working and I'll investigate.

I'm working on the error message in the attached screenshot. I don't think it's a sort issue.

There may be something different in some article records that is not being handled properly. I'm thinking it's more likely the article than the packet, but I'll find out.

The two packets on the assigned packets page for "Test Board Member 2" contain articles that are not alphabetized by journal (or so it seems). There may be a hidden "The" in front of some journal names?

Both of the sort confusions are indeed caused by "The", just as you suspected:

"The American journal of bioethics : AJOB"
"The American Journal of dermatopathology"

This could be overcome in various ways but it would take some thinking. I don't think our brief citations are the same everywhere in the system. We could pick one as the canonical format for sorting and then construct a new index for all of the journals. However that's enough work that I think we'd want a new issue for it.

OK - we can discuss whether to do that in the future, but this is fine for now. So, the journal sort is verified on QA. I'll move this over to "QA verified" once the error message has been resolved. Thanks.

I can reproduce the error on QA using the packet shown in the screen shot, but that packet doesn't exist in Dev so I'm going to do a little testing on QA.

I'll be changing some program files, hopefully not breaking anything, but please bear with me if something goes wrong in the board member review area.

Thanks.

I think I see the problem. The article with EBMS ID 331928, Pubmed ID 25006622, has no author field. The software that formats the citation assumes that there is an author field and attempts to format it. So it is indeed caused by software not handling an unusual record correctly. It's not related to the sorting by journal title. It's a bug that's been there but we probably very rarely encounter records like this with no author.

I'll fix this case and check the search results and single citation display/edit pages to see if they have a similar bug. If so, I'll fix them too.

If you can think of any other displays that need to be checked, please check them with the above article and I'll fix them.

Thanks, Alan. I see which article it is. I'll search for other pages and post screenshots if I find any.

Edit Packet page

I'll fix that one.

I fixed the assigned packets display. Search and citation edit are okay. They display "[No authors listed"].

I haven't done that on the review page but can if that's better. Please let me know and I'll fix both review pages that way instead of just leaving out the authors.

Yes, please add "[No authors listed]" if possible. That will be clearer and consistent with other pages.

I will post a screenshot of one more - the reviewed packets page.

The following pages look fine (with respect to this problem):
-Search Results
-Full Citation
-Citations by Status Report
-Literature Reviews Report
-Articles Without Responses Report

I verified the changes and saw no error message on the reviewed packets page, the packet page, and the review page for a single article. Thanks! I'm marking this QA verified.

Verified on prod.