CDR Tickets

I'm address this by removing our dependency on jQuery altogether, using plain vanilla JavaScript instead. In Publish Preview for summary documents (both CIS and DIS), we weren't using jQuery anyway. As far as I can tell, removing links to jQuery, jQuery UI, and jPlayer have no undesirable effects on publish preview for glossary terms. The WCMS team has given us a link which we can use if problems arise. We'll add it to SCRIPT below if any incorrect behavior is reported. Some testing will be required, but I have all the automated tests passing again.

One thing you'll notice on DEV, ~volker, as a result of the purge of jQuery the fancy tooltips showing the documentation of the options and fields for creating a publishing job now appear when you hover over a question-mark icon instead of the field. The USWDS framework has tooltip formatting, but there's a bug which breaks radio buttons, so I had to add the icons and attached the tooltips to them. We've done it that way before. You're probably pretty happy with this change, since (a) you don't need the tooltips at all, because you use the Publishing system so frequently; (b) now they only appear when you hover over the icon; and (c) the jQuery implementation obscured more than the USWDS tooltips do when they appear (the latter are intelligent enough to figure out which offset direction obscures the field the least depending on things like the browser window size and the proximity of the tooltip to the edge of that window). Also, please take a look on DEV at the Summary QC Report form, which is one of the more tricky users of client-side scripting (and with which you're most familiar), to make sure I didn't break anything there.Oh, and the Manage Filter Set page. That one's a doozy!

I looked at these pages on DEV and didn't see anything odd.  It appears that everything I looked at is working as expected.

I thought it was a little odd, when looking at the Summary QC Report and checking the "Include Images" checkbox that the option "Use publishable version" was added directly underneath.  I remember this option to be a little indented as a child element of the "Include Images" parent.

I think I don't like the page being so "jumpy".  I'll get used to it. 🙂

This might jog your memory.

Dependency on jQuery has been removed on CDR DEV.

https://github.com/NCIOCPL/cdr-admin/commit/46f3d671
https://github.com/NCIOCPL/cdr-admin/commit/413fd777
https://github.com/NCIOCPL/cdr-admin/commit/065fc716
https://github.com/NCIOCPL/cdr-lib/commit/2929aa0
https://github.com/NCIOCPL/cdr-lib/commit/bca266c