| Issue Number | 5279 |
|---|---|
| Summary | [GovDelivery] Add Total Numbers to Tables Within Weekly GovDelivery Report |
| Created | 2023-09-07 14:36:29 |
| Issue Type | Task |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2023-09-14 17:08:39 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.357528 |
We would like to add totals to each of the health professional summary tables within the weekly GovDelivery email report in both English and Spanish.
We'd like to have the total reflect the number of substantive changes, if possible, since editorial changes are not listed in the weekly GovDelivery email updates.
For the English GovDelivery report, please do not count summaries that have the following statement in the Changes to this Summary section: "Editorial changes were made to this summary."
For the Spanish GovDelivery report, please do not count summaries that have the following statement in the Changes to this Summary section: "Se incorporaron cambios editoriales en este resumen."
Please add the totals in parentheses after the title of each table. For the revised summaries, please say the number, followed by "excluding editorial changes" for clarity.
Please let me know if you have any questions.
Just confirming: for the tables of new summaries, we're just giving the total number of summaries in the table, right (without looking for a Changes to this Summary section)?
that's correct. Thank you!
Installed on DEV. Sample output for reports forwarded to ~juther .
https://github.com/NCIOCPL/cdr-scheduler/commit/7e4fc2d
https://github.com/NCIOCPL/cdr-scheduler/commit/9841f3e
Thanks, Bob! These look great, although there's an additional type of editorial change that I'd like to exclude from the numbers. This additional type of change is editorial changes to modules.
Please also do not count summaries that have the following statement in the Changes section:
English: "Editorial changes were made to this module."
Spanish: "Se incorporaron cambios editoriales en este módulo."
Modification to skip modules with only editorial changes has been installed on DEV.
~bkline Would you mind forwarding samples of the emails to me? Thanks!
Done. As I pointed out to Robin, the data were such that the latest modification didn't get tested.
Verified on DEV. Thanks!
I am not sure how effective a test on QA for this ticket will be since we have not run a publishing job on QA for a while. Or maybe, we have, and I don't know.
If we can test with the data on QA, then please run the report and send me the email. Thanks!
The GovDelivery job uses the last two weekly publishing events to create the report output. If your goal is to check a change in the display I would think you can do that with a dataset that isn't current.
Volker forwarded some of them to me. I think the English looks good but for the Spanish, it seems like they have a different way of stating the editorial changes "Se incorporaron cambios editoriales en este sumario.", So, one Spanish summary was counted. I will talk to the Spanish team tomorrow just to confirm.
Unlike the English, the Spanish summaries have multiple variations of the editorial changes. However, the most common one is the one provided in this ticket. However, the test on QA was able to find one Spanish summary with editorial changes that was countered. Linda said that is a rare case so, I think it is safe to proceed with this change. If it becomes a problem in the future, we will create another ticket to deal with it.
Verified on QA. Thanks!
Verified on PROD. Thanks!
Elapsed: 0:00:00.001926