| Issue Number | 5208 |
|---|---|
| Summary | Modify Summaries QC reports to display unpublishable version changes |
| Created | 2023-02-22 10:00:23 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2023-03-09 12:36:25 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.339161 |
As a CDR summary editor, I want to be able to run the summaries QC reports (B/U and RL/SO) to review changes within a linked QC report before making the Misc. Doc publishable.
Given: I am a CDR summary editor
And I have permissions to create or edit Misc. Documents
When I create or edit a Misc. Doc
And I link it to a summary doc.
Then I want to be able to run the summaries QC reports to review the changes before making the Misc. Doc. publishable
We had made similar adjustments to our filters before but because the denormalization is shared between multiple filter sets (for QC reports, PublishPreview, and publishing) we will need to decide on the specific rules for the different processing paths to ensure we're not ending up with versions that aren't publishable in our PDQ partner output or on Cancer.gov.
For the denormalization of our glossary terms we implemented the following rules:
QC report --> CWD
PP report --> /last version
publishing --> /lastp (publishable) version
The denormalization rules listed in my previous comment are applied for GTN and GTC QC reports. Looking at the denormalization filters for summaries, I realize that we are using different denormalization rules for the summary QC reports. Here the rule is
QC report --> CWD
PP report --> /lastp version
publishing --> /lastp version
This rule is applied, for instance, used when processing the SummaryModuleLink. Given that the Special Consideration Misc. doc section is similar to a module link I implemented the same rule for MiscellaneousDocLink elements. The following filter has been modified:
CDR335424 - Denormalization Filter: Summary
This is ready for review on DEV.
Verified on DEV. Thanks!
The following filter changes have been copied to QA to use the CWD for QC reports:
CDR335424 - Denormalization Filter: Summary
https://github.com/NCIOCPL/cdr-server/commit/ea43da3
For my information:
The filter changes are part of the git branch cdr5133-special-consid.
Verified on QA. Ready for PROD.
Since these changes are part of the OCECDR-5133 branch I cannot copy the filter to PROD independently.
Can this be promoted to PROD now? Thanks!
The changes were part of the filter changes for OCECDR-5133.
Please verify on PROD and close this ticket if everything looks OK.
We have an unpublishable but valid Misc Doc CDR0000813292 * ** lined in this summary CDR0000799767. When you try to run a B/U report for the summary you get an error message that seems to indicate that CDR0000813292 needs a publishable version. *
filtering error: Unable to resolve uri 'CDR0000813292#_2/lastp'
It appears that I had copied the filters from the "master" branch for the ticket OCECDR-5133 instead of the branch with the changes to PROD. I corrected this and have now copied the filter changes from the "master" branch - which do contain the changes now - to PROD.
Please verify on PROD and close the ticket if it's working OK now.
Verified on PROD. Thanks!
Elapsed: 0:00:00.001798