CDR Tickets

Issue Number 5100
Summary Schema Validation for SummaryURL
Created 2022-03-03 11:05:12
Issue Type Bug
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2022-06-08 14:35:44
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.312316
Description

Under certain conditions we identified that the validation for the SummaryURL does not work correctly.  It should not be possible to validate a document if another document with the identical cdr:xref attribute value already exists.
In other words, the SummaryURL attribute has to be unique across active documents (with the exception of one of the documents containing the WillReplace element).

This bug requires Python as well as filter changes.

Comment entered 2022-03-03 11:27:43 by Kline, Bob (NIH/NCI) [C]

Python portion fixed on DEV.

 

https://github.com/NCIOCPL/cdr-lib/commit/1bdd7994

Comment entered 2022-03-03 17:16:06 by Englisch, Volker (NIH/NCI) [C]

The following filter has been modified:

This filter is used in three filter sets:

  • Denormalization Organization Set

  • Denormalization PDQBoardMemberInfo Set

  • Denormalization Person Set

In order to run diff reports for the three doctype QC reports I had to modify one of our publishing control files because these reports were missing from the set:

A diff report for the QC reports for all three document types showed no differences (except for the time stamp).

This is ready on DEV.

Comment entered 2022-03-03 17:53:03 by Kline, Bob (NIH/NCI) [C]

Just to make the record clear: the filter modification made for this ticket was not directly related to the summary duplicate URL custom validation rule, but was to correct a bug found when we were reviewing all of the CDR source code to find anything which the fix for the bug breaking the validation rule might itself break.

Comment entered 2022-03-08 14:10:46 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2022-06-02 16:44:12 by Osei-Poku, William (NIH/NCI) [C]

We need to discuss how to address this issue due to the problem we encountered with SVPC summaries during testing. Currently some of the SVPC SummaryURLs are duplicated with the partner summaries. We had to remove WillReplace elements from the SVPC summaries because they were preventing publishing of the SVPC summaries when we were testing on QA. So, we need to come up with a better solution of handling duplicate SummaryURLs.

Comment entered 2022-06-06 17:57:15 by Englisch, Volker (NIH/NCI) [C]

I've added the ticket OCECDR-5120 to address this issue.

Comment entered 2022-06-07 20:09:17 by Osei-Poku, William (NIH/NCI) [C]

I tried to re-verify that I with two summary documents sharing one SummaryURL, it will trigger the validation warning message but I am not able to reproduce that on DEV. 

These are the two documents with same SummaryURL.

CDR0000805710

CDR0000062906

Comment entered 2022-06-08 14:35:10 by Englisch, Volker (NIH/NCI) [C]

I tried to create a publishable version for document CDR805694 and got the expected error. 

 

The reason why your two summaries don't fail validation is because CDR805710 includes the WillReplace element.  As you know that element will exclude the document's URL from being included in the validation check.

Comment entered 2022-06-08 15:29:27 by Osei-Poku, William (NIH/NCI) [C]

Thank you I was able to get the validation error message to show after removing the WillReplace element. 

 

Verified on DEV. Thanks!

Comment entered 2022-06-23 11:54:02 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2022-10-10 14:19:54 by Englisch, Volker (NIH/NCI) [C]

The related tickets are on PROD and are closed.

I'm closing this one, too.

Attachments
File Name Posted User
Screen Shot 2022-06-08 at 14.15.55.png 2022-06-08 14:17:57 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.001368