CDR Tickets

Issue Number 5070
Summary Modify publishing filters to not require top-level section title for SVPC summaries
Created 2021-11-16 14:23:34
Issue Type New Feature
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2021-11-23 18:43:42
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.302682
Description

As a patient summary editor, I want to be able to create or modify a SVPC summary so that a section title is not required for the first top-level section. This will ensure that the title of the summary is not duplicated as the section title on cance.gov.

 

This applies specifically to the Diagnosis SVPC summary which has only one top-level section and is not an introductory text. This approach will ensure that in a case where a top-level section title is not required for publishing to cancer.gov, the summary title would be used as the top-level summary section title for the partner document.

 

Acceptance criteria:

Scenario: CDR Publishing filters has been modified to make the first top-level section title of a summary optional.

Given I am a CDR patient summary editor

  And I have permissions to create summaries

  And I have permissions to edit summaries

  And I create or edit a SVPC summary

  And I do not enter a summary section title for the first top-level section

When I run publish preview for the SVPC summary

Then pub preview should not require that I enter a top-level summary section title

 

Scenario: CDR Publishing filters has been modified to make the first top-level section title of a summary optional.

Given I am a CDR patient summary editor

  And I have permissions to create summaries

  And I have permissions to edit summaries

  And I create or edit a SVPC summary

  And I do not enter a summary section title for the first top-level section

When I run publish preview for the partner document

Then pub preview should display the summary title as the section title for the first top-level section.

Comment entered 2021-11-23 18:13:32 by Englisch, Volker (NIH/NCI) [C]

The following filter has been modified to adjust for the different options of displaying top-level SummarySection Title data:

  • CDR000157.xml - Vendor Filter: Summary

When testing this ticket, please keep in mind that for testing the behavior of top-level sections alone there are 16 different options to look at.  If you include testing second level SummarySections and testing summaries including other SummaryModuleLink elements, the number goes up.  I've created a spreadsheet to keep track of the different options and prepared several documents in the CDR to be able and run test reports.

Comment entered 2021-11-23 18:22:44 by Englisch, Volker (NIH/NCI) [C]

I'd like to highlight a couple of the options.

SVPC - Single Section with Title (no intro text): Both the document title and the section title will be displayed 

Comment entered 2021-11-23 18:26:33 by Englisch, Volker (NIH/NCI) [C]

SVPC - Section title without a title will create an error.  The error points to the section ID.

Comment entered 2021-11-23 18:31:38 by Englisch, Volker (NIH/NCI) [C]

Partner Doc - Section without a title will create an error.  The error points to the SVPC document causing the error.

Comment entered 2021-11-23 18:42:43 by Englisch, Volker (NIH/NCI) [C]

Partner Doc - Intro text including intro title overwrite:  This title will overwrite the document title but will be ignored for the SVPC/Cancer.gov output:

 

SVPC Output:

Comment entered 2022-01-04 20:24:24 by Osei-Poku, William (NIH/NCI) [C]

Hi  I have been testing these changes and I see that you created sample documents on DEV for testing some of them. I know we don't need all the different scenarios for at least the liver cancer svpc summaries. What I am wondering is, if I need to test all the different scenarios you have in the spreadsheet?

Comment entered 2022-01-05 15:28:53 by Englisch, Volker (NIH/NCI) [C]

As discussed earlier, if you know that one of the examples included on the spreadsheet will not make sense from the user point-of-view you could skip that one.  Also, if you're only interested in testing those samples that are reflected as part of the Liver Cancer summaries we're currently working with, that would be OK to some degree as well, keeping in mind that any problems we might find down the road for the other scenarios we may not be able to fix right away depending on currently ongoing work at that time.

Comment entered 2022-01-31 18:35:46 by Osei-Poku, William (NIH/NCI) [C]

I have completed testing all the various combinations and they seem to be working as expected. I do have one question that needs confirmation from you in the attached spreadsheet. If it is a yes, then I can mark this ticket as DEV verified. Thanks!

 

SVPC_Title_Tests _comments.xlsx

Comment entered 2022-02-01 17:21:45 by Englisch, Volker (NIH/NCI) [C]

There is a question(mark) on line 5, 9, and 21 of the spreadsheet.  I'm guessing your question you need to have answered would be line 21.

Yes, the optional intro text title will be used to display the Intro text section and overwrite the document title.

Comment entered 2022-02-01 18:38:34 by Osei-Poku, William (NIH/NCI) [C]

OK. Thanks! I just needed that confirmation.

Comment entered 2022-05-26 13:45:39 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA and PROD. Thanks!

Attachments
File Name Posted User
Screen Shot 2021-11-23 at 18.21.24.png 2021-11-23 18:21:44 Englisch, Volker (NIH/NCI) [C]
Screen Shot 2021-11-23 at 18.24.25.png 2021-11-23 18:25:32 Englisch, Volker (NIH/NCI) [C]
Screen Shot 2021-11-23 at 18.30.47.png 2021-11-23 18:31:07 Englisch, Volker (NIH/NCI) [C]
Screen Shot 2021-11-23 at 18.35.43.png 2021-11-23 18:41:09 Englisch, Volker (NIH/NCI) [C]
Screen Shot 2021-11-23 at 18.38.41.png 2021-11-23 18:39:06 Englisch, Volker (NIH/NCI) [C]
SVPC_Title_Tests _comments.xlsx 2022-01-31 18:35:19 Osei-Poku, William (NIH/NCI) [C]
SVPC_Title_Tests.xlsx 2021-11-23 18:14:10 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.002015