CDR Tickets
| Issue Number | 5052 |
|---|---|
| Summary | Modify QC Report filters to indicate if “On This Page” is needed for a summary |
| Created | 2021-10-18 12:39:57 |
| Issue Type | New Feature |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2021-10-29 20:41:53 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.300718 |
As a CDR patient summary editor, I want to be able to run a QC report for a SVPC summary so that if the summary has been marked to not have “On This Page” section, then the QC report will display the summary with the “On This Page” section of the summary or the QC report will indicate that the "On This Page" has been marked as needed for the summary.
We are currently making changes to mark some SVPC summaries to display the “On This Page” section of the summary on Cancer.gov (OCECDR-5047). We will need the summaries QC report filters to be modified so that when a SVPC summary is marked to indicate that the “On This Page” is needed for the summary, the QC report will indicate that the “On This Page” section is marked for the the summary.
Scenario: Summaries QC report has the ability display the “On This Page” as optional
Given I am a CDR patient summary editor
And I have permissions to create summaries
And I have permissions to edit summaries
And I create or edit a SVPC
When I mark the “On This Page” section as needed for the summary
And I run a QC report for that summary
Then the QC report should display the “On This Page” section in the QC report
Or the QC report will indicate that the "On This Page" has been marked as needed for this summary.
~oseipokuw, I think we had already mentioned this elsewhere but I want to make sure:
if the summary has been marked to not have the “On This Page” section, then the QC report will display the summary without the “On This Page” section
We had said that the rule for SVPC summaries would be not to display the "On This Page" section and that the display of the "On This Page" section would be the exception to the rule. Therefore we would mark the page if we want the section to display and we will suppress it in the general case (in the absence of an "ShowOTP" (or similar) attribute).
Is that correct?
The following filters have been modified to implement the default behavior of suppressing the TOC/OTP for SVPC summaries.
CDR000158.xml - Patient Summary QC Report Filter
CDR441144.xml - Patient Summary QC Report - Bold/Underline
The second portion - display of TOC if an attribute indicates to do so - will be done once the attribute has been created.
I believe that was what we learned on Thursday so the approach seems right to me. Thanks!
The following filters have been updated to suppress the display of the On This Page (TOC) for the QC reports and to display a "partner doc" banner:
CDR000158.xml - Patient Summary QC Report Filter
CDR339576.xml - Module: InLine Markup Formatter
CDR380958.xml - Module: STYLE QC Summary
CDR441144.xml - Patient Summary QC Report - Bold/Underline
https://github.com/NCIOCPL/cdr-server/commit/d2a6cfd
This is ready for review on DEV.
Verified the Merged partner banner on DEV. However, I am unable to confirm that the TOC is displayed when the attribute "SVPCOnThisPage' is set. Using CDR0000805698 as my test doc and I get the attached screenshot.
The following filters have been modified to display the TOC if the attribute SVPCOnThisPage="Yes" option has been selected.
CDR000158.xml - Patient Summary QC Report Filter
CDR441144.xml - Patient Summary QC Report - Bold/Underline
We decided to change the name of the attribute to
SuppressOnThisPageSection.
The filter have been adjusted due to the attribute change.
Verified on DEV. Thanks!
Verified on QA and PROD. Thanks!
| File Name | Posted | User |
|---|---|---|
| SVPC on this page.png | 2021-10-26 15:07:48 | Osei-Poku, William (NIH/NCI) [C] |
| SVPC TOC missing.png | 2021-10-26 15:07:48 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001945