CDR Tickets

Issue Number 5050
Summary Pruning of Drupal PDQ nodes skips some nodes
Created 2021-10-15 16:24:22
Issue Type Bug
Submitted By Kline, Bob (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2021-10-15 16:28:56
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.300680
Description

We submit the requests to prune the nodes we just published in batches, so we don't overwhelm poor Drupal with too many at once. Inside that loop we have a nested loop which tries again a certain number of times in the face of failures on the Drupal end so we can recover and keep going. Unfortunately, the offset is moved forward by the batch size inside both loops. So unless a publishing job were pretty small (10 summaries or fewer) we could be skipping the pruning for half the summaries published. Or more, in the uncommon case of failures on the Drupal end. A fairly benign bug, as these things go (though way up there on the silly meter), since in most cases a node which got skipped for the pruning in one job could catch up in the next job. The worst-case scenario for the bug is some nodes have incredibly back luck and never get pruned, and take up more space in the database than we want them to.

Comment entered 2021-10-15 16:28:56 by Kline, Bob (NIH/NCI) [C]

Fixed on CDR DEV.

Elapsed: 0:00:00.001717