| Issue Number | 5018 |
|---|---|
| Summary | [Summary] Summary Title Includes Trailing Space |
| Created | 2021-08-12 19:28:06 |
| Issue Type | Bug |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2021-08-19 18:39:31 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.296486 |
Some of our summaries include a trailing white space. This can, for instance, change the display of the order in which the HP and the Patient version of the same document pair are displayed.
We may want to modify our DocTitle filter to strip the extra space from the title when creating the document's title field.
The following filter has been updated to fix the spaces in the Summary title:
CDR000064.xml - DocTitle for Summary
https://github.com/NCIOCPL/cdr-server/commit/d937a76
I'm wondering if we want to adjust the other DocTitle filters, too? Attached is the count of document types with a space before the colon.
Since ~vshields noticed this issue, too, I'm making her a watcher.
You can test the filter changes on DEV by pulling up one of the documents with the extra space in XMetaL and save it once. That save will correct this particular summary in the sorted list of summaries when searching for it.
Verified on DEV. Looks good!
Seems to be working on DEV. I am able to search in cases where there are trailing spaces, so the changes seem to be working. On a related note, It looks like the changes are only to the filters, right? In XMetal, I see that I cannot purposely create a leading space in a title and when I save it, the trailing space remains. I am just wondering if we can also get rid of the trailing space in XMetal. I can't think of any reason why we would want to keep the tailing space after the document is saved.
This ticket is addressing the issue of spaces being included in the Summary DocTitle element which is populated/updated by the DocTitle filter. If you'd like to modify the content of the documents (i.e. content of the SummaryTitlle element) we would either need to create a global change ticket and/or modify the schema validation to prevent users from saving the document when there are leading or trailing spaces part of the title.
The modified filter has been copied to QA and STAGE. Please verify on QA before I'll copy the changes to PROD.
Verified on QA. Please proceed to copy to PROD. Thanks!
The filter change has been copied to PROD.
Please verify and close this ticket.
~oseipokuw will verify on PROD and close the ticket.
Verified on PROD. Thanks!
| File Name | Posted | User |
|---|---|---|
| Screen Shot 2021-08-19 at 18.31.52.png | 2021-08-19 18:38:19 | Englisch, Volker (NIH/NCI) [C] |
Elapsed: 0:00:00.001420