CDR Tickets

Issue Number 5015
Summary Modify display of Spanish Synonyms
Created 2021-08-11 17:32:33
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2021-08-16 17:42:02
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.296352
Description

Please modify the display of Spanish synonyms on Cancer.gov such that when there are two or more also called terms (synonyms) and the last term starts with an “hi”, use an “e”  conjunction instead of "i". 

Currently this rule is applied when a term starts with an "i". [Please see OCECDR-4808]

So, apply this rule to terms that start with "hi" also.  Examples on PROD. 

GTN: 476307

GTC:620135

Comment entered 2021-08-16 17:41:43 by Englisch, Volker (NIH/NCI) [C]

The following filter has been modified to correct the Spanish conjunction for synonyms:

This is ready for review on DEV.

Comment entered 2021-08-18 10:29:12 by Osei-Poku, William (NIH/NCI) [C]

There seems to be a problem with PP for Glossary Terms on DEV. Please see attached error message:

Comment entered 2021-08-18 11:56:21 by Englisch, Volker (NIH/NCI) [C]

I'm in the middle of working on OCECDR-4992.  Please try again.

Comment entered 2021-08-18 14:00:26 by Osei-Poku, William (NIH/NCI) [C]

It is working for the most part.  However, one of them isn't displaying as expected : CDR0000635811

Also, note in the attached screenshot where it says "More bold nodes:0" It shouldn't be there. 

Comment entered 2021-08-18 14:26:46 by Englisch, Volker (NIH/NCI) [C]

Please ignore the "MORE bold Nodes" since this is part of my testing OCECDR-4992.

When you say "It is working for the most part" does that mean it is working when there are only 2 terms or do you also see it working for 3 or more terms?

I will take a look.

Comment entered 2021-08-18 14:40:25 by Englisch, Volker (NIH/NCI) [C]

Good catch, ! One of those copy/paste bugs.  This is fixed again.

Comment entered 2021-08-18 14:52:32 by Osei-Poku, William (NIH/NCI) [C]

It is showing correctly now. Thanks!


When you say "It is working for the most part" does that mean it is working when there are only 2 terms or do you also see it working for 3 or more terms?

My comment was generally about how PP was working. There were a couple of instances where PP temporarily failed to display the definitions at all. We have not yet tested with more than 2 or 3 terms.

Comment entered 2021-08-18 16:06:36 by Osei-Poku, William (NIH/NCI) [C]

Looks good on DEV. Ready for QA. Thank you!

Comment entered 2021-08-18 17:54:59 by Englisch, Volker (NIH/NCI) [C]

The filter change has been copied to QA.

Comment entered 2021-08-18 18:54:30 by Englisch, Volker (NIH/NCI) [C]

I ran a diff report on QA and saw 37 occurrences where the text is now changed.  There were no other changes reported by the diff.

Comment entered 2021-08-24 12:16:36 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Ready for PROD.  Thanks!

Comment entered 2021-08-24 12:58:25 by Englisch, Volker (NIH/NCI) [C]

The updated filter has been copied to PROD.  Please verify and close this ticket.

Comment entered 2021-08-24 14:55:25 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
Glossary Synonyms.PNG 2021-08-18 14:00:24 Osei-Poku, William (NIH/NCI) [C]
image-2021-08-18-10-29-06-184.png 2021-08-18 10:29:06 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001443