CDR Tickets

Issue Number 4903
Summary Glossary Terms with diacritics need to be sorted properly
Created 2020-09-24 22:29:19
Issue Type Bug
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-09-25 09:27:53
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.275536
Description

Currently, the A-Z list for the dictionary of cancer terms is sorting all terms starting with the characters A-Z under the appropriate character and all terms starting not with an ASCII character are sorted under the letter "#" which should be reserved for terms beginning with a number or a special character like an open parentheses or open bracket, etc.

Especially for the Spanish terms, where many terms start with an accented character, those terms are sorted within the "#-group" rather than the respective letter group.

Comment entered 2020-09-25 08:07:44 by Kline, Bob (NIH/NCI) [C]

This isn't really a bug, as the requirements have changed. The original requirements explicitly stated that every term whose name did not begin with a character which when lowercased matched the regular expression [a-z] was to be displayed under #. The current implementation matches those requirements. The new requirements call for mapping of letters with diacritics to ASCII letters before matching the regular expression.

Comment entered 2020-09-25 09:27:53 by Kline, Bob (NIH/NCI) [C]

Changed requirements implemented on DEV.

Comment entered 2020-09-25 14:18:16 by Englisch, Volker (NIH/NCI) [C]

I can see the correct "first_letter" character in the database for the Spanish terms starting with a diacritic.  The first letter entry was specified as "#" before but is now the corresponding ASCII character.

Comment entered 2020-10-29 07:36:18 by Kline, Bob (NIH/NCI) [C]

 can this be moved to TASK REVIEWED (DEV)?

Comment entered 2020-10-29 18:30:02 by Englisch, Volker (NIH/NCI) [C]

Yes, looks good on DEV.

Comment entered 2020-11-23 13:54:31 by Englisch, Volker (NIH/NCI) [C]

The terms starting with diacritics (Spanish terms) are correctly sorted on QA.

Comment entered 2020-12-17 13:29:03 by Englisch, Volker (NIH/NCI) [C]

Confirmed on PROD.

Elapsed: 0:00:00.001928