CDR Tickets

Issue Number 4902
Summary [DIS] Drug Descriptions Report - Modifications for FDA Approval element attributes and Drug Type
Created 2020-09-24 13:21:05
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-10-26 15:34:11
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.275515
Description

We'd like to make some changes to the Drug Description report to allow for filtering and the display of the new FDA approval element attributes and drug type information.

Comment entered 2020-09-24 13:26:48 by Juthe, Robin (NIH/NCI) [E]

Requirements attached.

Comment entered 2020-10-09 12:46:55 by Kline, Bob (NIH/NCI) [C]

Same questions as for OCECDR-4878.

Comment entered 2020-10-22 13:26:33 by Juthe, Robin (NIH/NCI) [E]

Same answers for this one. OCECDR-4878

Comment entered 2020-10-23 13:56:58 by Kline, Bob (NIH/NCI) [C]

: What is supposed to happen if the user selects the By FDA Approval Information method but doesn't check either the Accelerated approval or the Approved in children boxes?

  1. The report is generated showing every drug in the CDR.

  2. The report is generated as if both boxes had been checked.

  3. Nothing

If we go with #2 the obvious question would be: why not start off with both boxes checked?

Comment entered 2020-10-26 13:22:54 by Juthe, Robin (NIH/NCI) [E]

Good point. Why don't we have the two boxes checked automatically if the FDA Approval Information radio button is selected. It seems to be most likely that a user would be interested in both types of FDA approval status values, but the user could unselect one of the two options if they aren't interested in seeing that information. Technically, a user could unselect both options and in that case I think there should be an error message indicating that one of the options needs to be chosen.

Comment entered 2020-10-26 13:40:46 by Kline, Bob (NIH/NCI) [C]

So, option #4: throw an error?

Comment entered 2020-10-26 13:55:45 by Juthe, Robin (NIH/NCI) [E]

Yes, but I propose that we have them selected be default IF the FDA approval radio button is chosen.

Comment entered 2020-10-26 14:26:07 by Kline, Bob (NIH/NCI) [C]

OK, got it.

As an aside, Jira really is behaving strangely. I no longer see the Reply option for following up on a comment.

Comment entered 2020-10-26 15:34:11 by Kline, Bob (NIH/NCI) [C]

Implemented and installed on DEV.

Comment entered 2020-10-27 13:01:15 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2020-11-12 15:20:41 by Osei-Poku, William (NIH/NCI) [C]

The drug type picklist is missing from the interface on QA.

 

 

This is what is on DEV.

Comment entered 2020-11-12 15:34:38 by Kline, Bob (NIH/NCI) [C]

What happens if you add drug types to the documents?

Comment entered 2020-11-12 15:40:52 by Juthe, Robin (NIH/NCI) [E]

Right, I think it's dependent on there being values in the documents to draw from since that's a new element.

Comment entered 2020-11-12 15:53:48 by Kline, Bob (NIH/NCI) [C]

See the discussion on this question in https://tracker.nci.nih.gov/browse/OCECDR-4878.

Comment entered 2020-11-17 15:47:58 by Osei-Poku, William (NIH/NCI) [C]

Thanks! This works as expected. 

Verified on QA.

Comment entered 2020-12-21 11:15:21 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
DrugDescriptionReport_DEV.PNG 2020-11-12 15:19:28 Osei-Poku, William (NIH/NCI) [C]
DrugDescriptionReport_QA.PNG 2020-11-12 15:19:28 Osei-Poku, William (NIH/NCI) [C]
DrugDescriptionReport_QA-1.PNG 2020-11-12 15:20:04 Osei-Poku, William (NIH/NCI) [C]
OCECDR 4902 Requirements.docx 2020-09-24 13:26:40 Juthe, Robin (NIH/NCI) [E]

Elapsed: 0:00:00.001132