CDR Tickets

Issue Number 4898
Summary [Glossary] Pub preview for glossary terms
Created 2020-09-23 17:35:48
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-12-18 14:53:23
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.275444
Description

We decided to find a another solution for running pub preview for glossary terms in cases when there is no publishable version for the GTC. Please see OCECDR-4773 The initial thought was to use the GTC full QC  report to serve as pub preview but it looks like it will be better to have a new report for this purpose.

Comment entered 2020-11-19 13:57:29 by Englisch, Volker (NIH/NCI) [C]

Apply the same rule we've implemented for images to allow non-publishable versions in the PubPreview report.

Comment entered 2020-12-11 23:58:27 by Englisch, Volker (NIH/NCI) [C]

Since this question of "Which version of a denormalized document do we display in which situation?" is always a little confusing I'd like to spell out again what exactly we are going to modify as part of this ticket.

  • The change should only affect the PP report for GTN - i.e. no changes to the vendor output.

  • The vendor output will pick up the publishable version of the GTN and the GTC

  • The PP report will use the CWD (current working document) of the GTN and the latest version of the GTC
    This means the PP report will not necessarily display what will be published to Cancer.gov.

For my information:
I am testing with CDR630963, CDR512740, CDR803014, CDR630962

The change requested in this ticket is to use the last version of the GTC document to be used for the PP report instead of the last publishable version.

Please speak up if I misunderstood this ticket, .

Comment entered 2020-12-14 13:27:20 by Osei-Poku, William (NIH/NCI) [C]

That is my understanding as well. The current PP requires a publishable version of the GTC and we want to "go around" that and not require a publishable version of the GTC. Using the latest version should should work.

Comment entered 2020-12-16 19:21:20 by Englisch, Volker (NIH/NCI) [C]

The following changes have been implemented:

  • CDR616047.xml - Denormalization Filter: GlossaryTermName

  • cdrFilter.html

I will still need to run some publishing jobs for testing purposes.

Comment entered 2020-12-16 19:26:10 by Englisch, Volker (NIH/NCI) [C]

Just to emphasize one more time: With this change it is possible that a user sees a different concept definition for all three reports:

  • QC report –> current working document

  • PP report –> last version 

  • Cancer.gov –> last publishable version 

I know, it's confusing. 🙂

Comment entered 2020-12-17 21:45:29 by Englisch, Volker (NIH/NCI) [C]

It turns out the change was not completely release independent.  Besides the modifications to CdrFilter.html which is only used internally, a change to the PublishPreview.py script was necessary as well meaning that this ticket should be moved to Newton.

The following changes are ready for review on DEV:

Comment entered 2021-04-29 10:13:35 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2021-05-25 14:19:17 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2021-06-24 09:14:38 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Elapsed: 0:00:00.002209