PDQ Issues

Issue Number	4830
Summary	QC Filter Sets command broken
Created	2020-05-15 08:43:04
Issue Type	Bug
Submitted By	Kline, Bob (NIH/NCI) [C]
Assigned To	Kline, Bob (NIH/NCI) [C]
Status	Closed
Resolved	2020-05-27 10:44:52
Resolution	Fixed
Path	/home/bkline/backups/jira/ocecdr/issue.262271

Description

The QC Filter Sets button on the CdrFilter.html page crashes under two conditions.

the Use Cache option is selected and the the file d:/cdr/Reports/expanded-filter-sets is missing
the Refresh Cache option is selected

This means that the button cannot be used on the upper tiers, since expanded-filter-sets is not present, causing the first condition, and it can't be generated, because of failure in the face of the second condition.

Comment entered 2020-05-15 08:44:36 by Kline, Bob (NIH/NCI) [C]

The following is the error which occurs when the Refresh Cache option is selected.

Traceback (most recent call last):
  File "D:\inetpub\wwwroot\cgi-bin\cdr\Filter.py", line 354, in &lt;module&gt;
    Control().run()
  File "D:\inetpub\wwwroot\cgi-bin\cdr\Filter.py", line 133, in run
    self.qc_filter_sets()
  File "D:\inetpub\wwwroot\cgi-bin\cdr\Filter.py", line 170, in qc_filter_sets
    filter_sets = cdr.expandFilterSets("guest")
  File "D:\cdr\lib\Python\cdr.py", line 3094, in expandFilterSets
    opts = dict(host=host, port=port)
NameError: name 'host' is not defined

Comment entered 2020-05-26 20:54:16 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV. I'm hoping you'll be able to give it a shake, ~volker, to make sure I haven't broken anything.

Comment entered 2020-05-27 10:46:48 by Kline, Bob (NIH/NCI) [C]

Added to release as the work to fix the bug is complete.

Comment entered 2020-05-27 18:12:19 by Englisch, Volker (NIH/NCI) [C]

What is the purpose for these two options?

It sounds from the description of the ticket that the filter job should fail if the Refresh cache option is selected. However, I'm unable to make the filter job fail for a summary on either QA or STAGE.

Comment entered 2020-05-27 18:50:34 by Kline, Bob (NIH/NCI) [C]

Comment entered 2020-05-27 18:52:38 by Kline, Bob (NIH/NCI) [C]

As part of the fix, I removed the caching altogether. The file permissions swamp on the CBIIT servers made the caching unreliable, and it's no longer needed anyway.

Comment entered 2020-05-27 19:55:05 by Englisch, Volker (NIH/NCI) [C]

I see, I almost never use that third option on this page, which is probably why I never ran into the error.

I was able to recreate the error on QA but not on DEV. This looks good to me.

Comment entered 2020-07-24 16:47:23 by Englisch, Volker (NIH/NCI) [C]

Tested successfully on PROD.

Closing ticket.

Attachments

File Name	Posted	User
image-2020-05-27-18-50-15-299.png	2020-05-27 18:50:15	Kline, Bob (NIH/NCI) [C]
image-2020-05-27-18-50-28-577.png	2020-05-27 18:50:29	Kline, Bob (NIH/NCI) [C]

Elapsed: 0:00:00.001634

CDR Tickets