| Issue Number | 4827 |
|---|---|
| Summary | Board members without summary assignments skipped |
| Created | 2020-05-12 16:48:11 |
| Issue Type | Bug |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-05-14 11:19:45 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.262109 |
On the PDQ Board report there is a typo which prevents the code from doing what it says it is doing, namely to ensure that board members to whom no summaries are currently assigned for review still show up on the Group by Board Member version of the report. Fixed on DEV.
~juthercan you confirm that the fixed version of the report works correctly on DEV? To verify look at the Supportive and Palliative Care Editorial Board (HP) board using Group by Board Member with the broken version and the fixed version of the report. In the broken version, Alison Palumbo comes immediately after Tammy Kang, whereas Shello Lo should come between them.
~jutherAnother anomaly I stumbled across for this report is that it's showing reviewers of a board's summaries even if the reviewers are not current members of the board. See, for example, Yehuda Patt and Gisele Sarosy on this report. Do you want to have me retain the (non-member) designation I have temporarily appended to their names on this version of the report?
I'm asking for confirmation on these questions because I've dug all the way back and can find no copy of the original requirements for this report. OCECDR-1007 (from 2003) is the first (converted) Bugzilla ticket I could find for it, and that's a request for a modification to the report after it was already in the system.
Good question. Thanks for digging into this.
Yes, the Board should include members that do not have assigned summary topics (this is a good reminder to us that we need to associate them with summaries).
Please retain non-members on the report. (Similarly, it's good to see them on the report so we know where they need to be removed as reviewers.) The non-member designation you're displaying after their names looks good to me. Could you please display the "non-member" designation on the "Group by topic" version of the report as well for consistency? Thanks.
Done. Since the fix is implemented, I'm adding it to Leibniz.
Verified on DEV.
Verified on PROD.
Elapsed: 0:00:00.001749