CDR Tickets

Is this part of the QA2 testing or is this on PROD?

This is on PROD. Thanks!

It appears there is a bug in the filter that is creating the "Glossary Terms" table.  The filter that needs to be updated is CDR409593 - Copy XML for Summary Report.

The filter doesn't pick up the HP concept definitions for Spanish summaries but only the patient definitions.  Since the concept CDR782630 only includes an HP definition and doesn't include a patient definition, the cell for the glossary term Sistema de clasidication de Reese-Ellsworth (CDR782667) is left blank.

~juther, when we talked about this ticket at our status meeting it seemed that you and Margaret had issues with my explanation of the problem I listed here.  What you see in the sample output is actually wrong in two ways:  (1) the definition for the first term should be displayed and (2) the definition displayed for the second and third term is actually the patient definition instead of the HP definition that should be displayed.

Please let me know if you have any other glossary terms or summaries I should be looking at to confirm the fix to the filter I was proposing.

The filter has been fixed and the HP definitions are now correctly displaying for this summary.

The following filter has been updated:

• CDR409593 - Copy XML for Summary Report

This is ready for review on DEV.

Verified on DEV. Thanks!

The following filter has been copied to PROD and STAGE:

• CDR409593 - Copy XML for Summary Report
  https://github.com/NCIOCPL/cdr-server/commit/ec18bc0c

The diff report for the summary QC reports did not show any problems.  Please verify on PROD and close this ticket.

The Patient RLSO report is not displaying definitions for linked glossary terms.

Examples:

CDR256800
CDR632891

Is it correct that this problem is not limited to RLSO and it's a problem for BU as well but only for Spanish documents?

This was interesting. In the past when we only selected "Patient" definitions this worked fine.  The I made the selection dependent on the audience value.  Unfortunately, our summary audience value is "Patients" while the glossary attribute is "Patient" (no plural 's') and those two don't match.  

I've adjusted the filter to work for both, the HP and the patient summaries again.

This is ready for review on DEV.

Please ensure to double-check: HP, patient, English, Spanish summaries.

The following filter has been updated:

• CDR409593 - Copy XML for Summary Report

It looks like it works fine for all except for the Spanish HP IACT summaries - example - 765468

The code for the Spanish HP summaries never worked.  This has been fixed on DEV.

The same filter as above has been updated:

• CDR409593 - Copy XML for Summary Report

Please verify on DEV.

Since I missed most of yesterday's meeting I just wanted to make sure you saw this ticket being ready for your review on DEV, ~oseipokuw.

Verified on DEV. Thanks!

The modified filter has been updated on QA and STAGE.  Please verify before I push the changes to PROD.

• CDR409593 - Copy XML for Summary Report
  https://github.com/NCIOCPL/cdr-server/commit/da2c1a7

Verified on STAGE. Please install on PROD when you're ready. Thanks!

The filter changes have been copied to PROD.  

Please verify on PROD and close this ticket.

Verified on PROD. Thanks!