| Issue Number | 4712 |
|---|---|
| Summary | Detect failure to find summary's board |
| Created | 2019-11-16 14:13:39 |
| Issue Type | Improvement |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2019-12-06 15:58:52 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.252455 |
The summary denormalization filter does not check to ensure that it has a board ID when it tries to load the DOM for the summary's board. Add a test (before line 162 of CDR0000335424.xml) to make sure the database query has found the board ID, and if it has not, use an xsl:message (terminate="yes") to abort processing with a useful failure message.
The filter has been modified to terminate if the English board ID is not available to retrieve the board information.
Has this been checked into version control?
No, it's not in version control yet. As you probably remember, I was in the middle of testing on Friday when I ran into the problem that my testing triggered a different issue. That's where I stopped.
Ah, OK. I just saw that the ticket had moved into the Completed column, so I assumed you were all done with your testing.
I've tested all summary export/QC reports on QA and diffed the output of the before and after filter change. The output was identical. The only difference was the error message displayed after the filter change was in place.
Marking this ticket as verified. The filter change has been pushed to GH.
We don't want to artificially create an error on PROD in order to test this feature. I'll therefore close this ticket.
Elapsed: 0:00:00.001515