CDR Tickets

Issue Number 4694
Summary [Summaries] Embedded Video in para tags prevents publishing
Created 2019-10-30 19:26:20
Issue Type Inquiry
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-02-24 16:45:05
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.251863
Description

The Patient Summaries team reported that 4 summaries failed to publish because the Embedded video set of elements were placed in para tags. Publishing succeeded after removing them from the para tags and placing them outside para tags. This is surprising because it looks like the embedded video is allowed in the para tags as well.

I have not been able to verify this so we may have to run some test publshing on QA. the affected summareis are below:

Childhood Adrenocortical, CDR 798740
Childhood Pancreatic, CDR 798745
Childhood GI Carcinoid, CDR 798747
Childhood GI Stromal, CDR 798749

Comment entered 2019-10-31 10:29:07 by Englisch, Volker (NIH/NCI) [C]

The Vendor DTD defines the EmbeddedVideo as a "ParaLevelElement" which means it can be used as a sibling to a "Para".  It is not, however, defined as a ParaElement.  Those are elements allowed to be used within a ParaLevelElement.

This behavior has always been this way but is likely an oversight because, as you said, the schema does allow the EmbeddedVideo element to be used within a paragraph.

Comment entered 2019-10-31 11:06:38 by Osei-Poku, William (NIH/NCI) [C]

Thanks for looking into this Given that we don't get a validation error when making the document publishable, can we make changes to the schema to disallow placement of the Embedded Video Link in a para element or alternatively get a validation error in XMetal ?

Comment entered 2019-10-31 11:26:34 by Englisch, Volker (NIH/NCI) [C]

You have two options here:

a) Modify the DTD to allow publishing without a failure or
b) Modify the schema to force a validation error.

Changing the schema could be done without a release; changing the DTD would make the EmbeddedVideo behave similar to the MediaLink element.

Comment entered 2020-02-24 16:44:40 by Englisch, Volker (NIH/NCI) [C]

I've modified the DTD to ensure the documents won't fail anymore during publishing.  This change requires a release, therefore I'm moving this ticket to Leibniz.

These two files have been modified:

  • pdq.dtd

  • pdqCG.dtd

https://github.com/NCIOCPL/cdr-publishing/commit/4712405f

Comment entered 2020-04-30 12:33:34 by Osei-Poku, William (NIH/NCI) [C]

The real test for this fix is publishing the affected summaries. Would hot-fixing them on DEV be okay?

Comment entered 2020-04-30 12:58:15 by Englisch, Volker (NIH/NCI) [C]

Sure, that should work or we're running a weekly publishing job on DEV once you have the documents ready.

Comment entered 2020-04-30 16:08:58 by Osei-Poku, William (NIH/NCI) [C]

Thanks! Below is the message from the hot-fix of 789589

Job failed: GateKeeper: Error (Failed DTD Validation: The element 'Para' has invalid child element 'EmbeddedVideo'. List of possible elements expected: 'DrugName DrugRef Emphasis ExternalRef ForeignWord GeneName GlossaryTermLink GlossaryTermRef InterventionName LOELink LOERef MediaLink MediaRef Note ProtocolRef ProtocolLink Quote Reference ScientificName Strong Subscript SummaryLink SummaryRef Superscript TT'.
RequestID: 17736
Packet #: 1
CDRID: 789589)

Comment entered 2020-04-30 17:00:59 by Englisch, Volker (NIH/NCI) [C]

We will need to remember that the Leibniz ticket requires a few manual tasks like this one.  The updated DTD file will need to be copied to the DEV server BLUE (or later the PROD GK processing server).

I've updated the DTD on BLUE and re-started the push job.  Please see the result of the job here
https://cdr-dev.cancer.gov/cgi-bin/cdr/PubStatus.py?id=17739

Comment entered 2020-05-01 10:37:13 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2020-06-12 13:42:51 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Elapsed: 0:00:00.001439