CDR Tickets

When I first read this request I was thinking in terms of GlossaryTerm QC report where both languages are within one file but I now realize the Spanish and English media documents are separate files.

Is it correct that you are looking for a report like the report that is displayed when you're clicking "Launch Media File" in XMetaL?

How would you like to call this report?  As a button within XMetaL or as an option on the Admin menu or both ways?

We will want a report on the Admin menu.

~oseipokuw, other than adding the report to the Admin Menu how would this report be different from OCECDR-4821?

This request 

• OCECDR-4623  

is an images "ONLY" report while   OCECDR-4821  is a request for a "FULL" images QC report. Meaning it will have some of the other text elements that is currently in the media QC report.

This ticket needs some discussion as the button to display the image is not - as most of the other report buttons - creating a report.  Instead it's a mechanism to open the existing image.  In other words, the JPEG file is opened with an application capable of displaying images as opposed to using the browser to display an HTML document/report.  I don't think it is possible to display two JPEG files side-by-side using this process unless both images are within the same JPEG file.

I think we could either add a second button to open the Spanish image in another window or create a new report which includes just the two images side-by-side.

~oseipokuw, after talking about this report earlier I think I have a better idea of what you're looking for.  You would want to specify one document (by ID or title) and extract all the images from both the corresponding English/Spanish documents to be displayed on a side-by-side report.

Please let me know if the attached sample (created for the colon cancer treatment summary) is what you had in mind.

Thanks, Volker! Yes, this is what we had in mind but also with some other fancy things in addition. We want to be able to do this for summaries and also for media. If you can do both in this ticket, I can create another ticket for the media one since that one appears to be more involving. I have attached the specification so you have a better picture of what we expect. Requirements Document for Images Report.docx

I can create another ticket for the media one since that one appears to be more involving.

Please do.  In my opinion these reports are very different in how to process the data although the final output may seem fairly similar.  For the Summary version of the report you are limiting yourself to the media content of a single summary document.  The Media version, however, will have to search across all media documents irrespective to the documents the media is attached to.

Could you please explain from the requirements document how option "(5) Option to display caption and content description below each page" is different from option "(7): ii and iii  Display EN, ES captions or both"?

Sorry for the confusion. That is misleading. I have moved ii) and iii) to under 5. I think that is where they belong.

May I ask what the benefit would be to display only the English caption (or description) but not the other?  Would it hurt to always show English and Spanish captions when showing captions?  In my opinion, what you may want as options is:

• Option to enter CDR ID
  or
  Option to search by summary title

• Option for language: Both, EN, ES

• Option for caption display: Yes/No

• Option for description display: Yes/No

Is this correct?

Requirements Document for Images Report_upated_Defaults.docx

I have marked the defaults for some of the search options. Hopefully, this would be helpful but generally, we would want:

Default Language:  Spanish

Default Audience: Patient

Title search should be the default vs CDR Search. I know this will not be enough so if you let me know which other options you want us to determine the defaults, that would be great.

Since there will be no need to specify a language option if you're only displaying one document - you wouldn't specify an English summary and specify to only display the Spanish information - I will add an option to "show both languages" as a side-by-side display.  I'm assuming you would want this option to be the default display option.

It sounds to me you'd like the option to display the captions for one language but not the other.  I am guessing what you need is to turn the display of captions (or description and labels) on or off rather than "display only Spanish caption but not English or vice versa".

I've updated the ticket title to reflect which media report we are talking about here.  This report will display all the images within a single summary and - if selected - it's Spanish translation.

~oseipokuw, this report is almost ready.  What's left to do is adding the option to display one language only.

Please have a look at the interface options I mentioned at our last CDR meeting since these are different from what was listed in the requirements document.  You can find the report as part of the Media reports under "Media in Summary Report".

The following files have been created/updated:

• MediaInSummary.py

• MediaReports.py
  https://github.com/NCIOCPL/cdr-admin/commit/94ddfb

This is ready for review on DEV.

Thanks ~volker This report seems to be for one aspect of what we wanted- reporting on images in summaries. One of things we wanted for this report is to also compare files that are not necessarily in summaries but can be retrieved for a specified category. I am not sure if we talked about doing that part of the report in the next release or not.

This report seems to be for one aspect of what we wanted- reporting on images in summaries.

That's correct.  In your requirements document you had combined two very different types of report into a single Media report interface.  Except for the requirement of displaying English and Spanish media documents side-by-side their isn't much of a connection between both reports.  One report is searching for media documents within the CDR based on criteria like diagnosis, audience, date range, etc. while the other report is displaying images from a single document (and its language counterpart).  Because of this I had modified the title of the ticket and we discussed we would handle both of these reports separately.  On Sep 11, Sep 14 you suggested creating a separate ticket for the media search report.

We did not talk about "when" we would create the other report but given the fact that we're nearly at the end of Maxwell, a new ticket of this size would need to be handled as part of our next release.

Thanks for the clarification. I forgot about that discussion.

It looks like if you select a summary that does not have an image, you get the following error message:  Sample summary (CDR0000765469)

'Summary' object has no attribute 'bail'

 I think it would be good to have a more user friendly message that says the summary selected does not have images.

When I uncheck "Display English and Spanish Document" and enter 'CDR0000269044' leaving all the defaults intact, I get the following error message:

invalid literal for int() with base 10: 'CDR0000269044'

Good test!  I did not try to run the report on a document without an image.

I will fix that in a moment.

The error message wasn't trying to tell you that there weren't any media files but it was trying to tell you that it had problems telling you what the error was.

This has now been fixed.

Another good catch!  I didn't expect the CDR-ID to not be an integer value.  

This has now been fixed.

It is working now. Thanks!

It is working now. Thanks!

Is it possible to have the option to enlarge the image? I know this is a new requirement so it needs to wait until the next CDR release, that is fine. Also, please include the Title of the summary and the CDR ID in the header of the report.

Is it possible to have the option to enlarge the image? 

Yes, but I need more information of what you mean by "enlarge the image" as I can imagine several different approaches:

• Display the images bigger. The images are currently displayed with a width of 400px - the same size we're using for our side-by-side glossary report.  You may want to display the images larger as a whole but remember, since this is a multi-column report when the image size gets bigger than the column width itself the report might start to look bad as written.

• Implement an option to specify the size of the images

• Make the images a link to allow individual images to be displayed in full size

• Create an option or link allowing an image (and its language counterpart?) to be displayed at a larger size

• other

The amount involved to "enlarge the image" will vary greatly between these options and depending on the image size chosen there may be additional changes to the report necessary.

This is the option we'd like - 

Make the images a link to allow individual images to be displayed in full size

The report has been setup so that you can click on the image in order to display the full size version.

Bug fixes and additional changes are now on github:
https://github.com/NCIOCPL/cdr-admin/commit/1ad606d

Verified on DEV. Thank you!

Verified on QA. Thanks!

Verified on PROD. Thanks!