CDR Tickets

Issue Number 4620
Summary [Media] Modify Media QC report to include images
Created 2019-05-17 13:18:31
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-05-04 23:37:25
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.244289
Description

Currently the Media (images) QC report does not include the attached images. Please modify the QC report so that the image is displayed.

Comment entered 2019-05-17 13:49:15 by Englisch, Volker (NIH/NCI) [C]

This is an enhancement request and not a bug report, right?

In terms of displaying the image do you have any specifics in mind - size, position?

Comment entered 2019-05-17 14:24:17 by Osei-Poku, William (NIH/NCI) [C]

Yes, it is an enhancement. I am attaching a draft copy of what users have in mind (this shows only the Spanish content occupying the first half of the page)Media Doc QC report changes.docx. I think this is a case where it would be good to have an interface for an option to display side by side content of the English and Spanish

 

Media Doc QC report changes.docx

Comment entered 2019-05-17 14:31:29 by Englisch, Volker (NIH/NCI) [C]

I'm not sure what the value is of an option to display images side-by-side or not.
Wouldn't it make sense to display the images always side-by-side?

Also, if it needs to be an option I can see the possibility to add an option on the admin form or add a button on the QC report to toggle the side-by-side display using JavaScript.

Comment entered 2019-05-17 14:35:29 by Osei-Poku, William (NIH/NCI) [C]


I'm not sure what the value is of an option to display images side-by-side or not. 
Wouldn't it make sense to display the images always side-by-side?

The side by side display is for the use of the translators. The English users don't need a side by side display. 


Also, if it needs to be an option I can see the possibility to add an option on the admin form or add a button on the QC report to toggle the side-by-side display using JavaScript.

Yes, this is fine too.

Comment entered 2019-05-28 16:30:25 by Englisch, Volker (NIH/NCI) [C]

I'm noticing that this comment doesn't belong here.  It was meant for OCECDR-4623.

Comment entered 2019-05-28 16:42:09 by Englisch, Volker (NIH/NCI) [C]

Is this new report replacing the existing Media QC Report?

In your specs you're writing "EN and/or ES labels" which indicates the user will need to select this option.  This means you don't want this report as a button inside of XMetaL, right?  Also, the current QC Media report lists Media Title, Image Data, Image Dimensions, etc. but your sample does not include this information.  Is this correct and you don't need that information on the QC report anymore or would this point to a new QC report in addition to the currently existing one?

Comment entered 2019-05-28 20:08:58 by Osei-Poku, William (NIH/NCI) [C]

  In your specs you're writing "EN and/or ES labels" which indicates the user will need to select this option.  This means you don't want this report as a button inside of XMetaL, right?

That is right. We are looking for an interface where the user will choose the different parameters. 

 

Also, the current QC Media report lists Media Title, Image Data, Image Dimensions, etc. but your sample does not include this information.  Is this correct and you don't need that information on the QC report anymore or would this point to a new QC report in addition to the currently existing one?

Please include all that information that is in the current QC report. 

Is this new report replacing the existing Medica QC Report?

The preference is for the current report to stay and have this report as an option.

Comment entered 2020-04-29 13:50:32 by Englisch, Volker (NIH/NCI) [C]

It's been a while since this ticket has been entered and I'm having trouble understanding exactly what is asked.  The ticket title indicates "Include image for Media QC report" but then we've been talking about a new report allowing to display English and Spanish information in a two-column display. 

Let's discuss these changes (or new report) at our meeting tomorrow, .

Comment entered 2020-04-29 15:50:38 by Osei-Poku, William (NIH/NCI) [C]

You're right. This is essentially two requests in one 😃.

1. Include images in the report.
2. Change the display of the report so it is no longer displayed vertically (English followed by Spanish) but rather horizontally.

Comment entered 2020-04-30 17:48:44 by Englisch, Volker (NIH/NCI) [C]

As discussed in our meeting today we will update the Media QC report to include the image as part of this ticket and  will create a new ticket for the Maxwell release to create a new Admin report for the side-by-side English/Spanish report.

Comment entered 2020-05-04 23:37:08 by Englisch, Volker (NIH/NCI) [C]

As part of adding the image to the Media QC report I've also rewritten large parts of the report in order to remove many of the tables that had been created for layout purposes.  These tables have been replaced with "div" sections and I believe the report looks now a bit cleaner.  Some of the code has been consolidated and modularized.  I did not remove all of the HTML tags used within the code but a large part of it.

The following filters have been modified:

  • CDR433163 - Media QC Report Filter

  • CDR430928 - Module: QC Filter Templates

This is ready for review on DEV.

Comment entered 2020-05-07 15:57:42 by Osei-Poku, William (NIH/NCI) [C]

The English Caption and Content Description are missing from the two tables. Could you please include them? You may take a look at 761775.

Comment entered 2020-05-08 11:43:47 by Englisch, Volker (NIH/NCI) [C]

I'm not certain what you are asking.  Looking at the document CDR761775, I see that this is a Spanish image and the Spanish Content Description and Spanish Caption is displayed.  Isn't this identical to the display of the information on PROD?

Please see the two screenshots from PROD and DEV.

Comment entered 2020-05-08 12:33:42 by Osei-Poku, William (NIH/NCI) [C]

You're right about the current display. However, the English documents do have for both Spanish and English. Please take a look at CDR415502. However, wait for me to confirm with the Spanish team that this is what they want.

Comment entered 2020-05-08 15:05:20 by Englisch, Volker (NIH/NCI) [C]

Are you thinking about including the English Caption/Content Description from the English document when running the QC report for the Spanish image?  If so I'd suggest to add a ticket for that change request to Maxwell since it's not related to including the image to the QC report.

The English QC reports for CDR415502 displays both languages because both languages are part of the media document.

Comment entered 2020-05-11 11:49:17 by Osei-Poku, William (NIH/NCI) [C]

Yes, that was would be a good thing to have. I will create a ticket for Maxwell. Thanks!

 

Verified on DEV. Thanks!

Comment entered 2020-06-10 13:51:46 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Attachments
File Name Posted User
media_dev.png 2020-05-08 11:44:01 Englisch, Volker (NIH/NCI) [C]
media_prod.png 2020-05-08 11:44:01 Englisch, Volker (NIH/NCI) [C]
Media Doc QC report changes.docx 2019-05-17 14:22:29 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001603